From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 082E0C433E0 for ; Mon, 29 Jun 2020 11:09:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8D1C239EF for ; Mon, 29 Jun 2020 11:09:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PK1yK27Q"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=pascalroeleven.nl header.i=@pascalroeleven.nl header.b="yMmYS8Vg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8D1C239EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=pascalroeleven.nl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a61dKMYi7oNrQY5s9I632TXheFQB3nBj959wbRvwsG0=; b=PK1yK27QJ51pRL/HuwKodCzEy DbzTiFZDKAUJslw/z7lPs7Y3zbloPgij2iqOLfm9ETNMCHgIyDw8JbK8egpxV/SvKvULbcjJY7e01 wjOQPAZ+E9GEPK+SgyNPfpiKmMGu1ktLLT24FuJV8UHW9YMHKGt9QjhACh9gu8PVcAX+tfIe24gb2 TVpEqSA/Yzj3WQ2gRTE6TOUbGTwQfuzG8JwxczU4yphFsS3zqbk59vIVZPWcQR9rI8xvVIR+11EMg FcdwZRmLBVVde2qO9uBsRcPn7nVlTMlszbSVumNYmLYgfEcksPW1sk3wHF4l4BiV+uEctsHnczoOh 8SfZCEHmQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jprda-0003OU-7g; Mon, 29 Jun 2020 11:07:46 +0000 Received: from pmg01-out1.zxcs.nl ([2a06:2ec0:1::ffeb]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jprdW-0003Nu-PG for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 11:07:44 +0000 Received: from pmg01.zxcs.nl (localhost.localdomain [127.0.0.1]) by pmg01.zxcs.nl (Zxcs) with ESMTP id BE0761035FD; Mon, 29 Jun 2020 12:59:04 +0200 (CEST) Received: from web0081.zxcs.nl (web0081.zxcs.nl [IPv6:2a06:2ec0:1::81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pmg01.zxcs.nl (Zxcs) with ESMTPS; Mon, 29 Jun 2020 12:59:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=pascalroeleven.nl; s=x; h=Content-Transfer-Encoding:Content-Type:Message-ID :References:In-Reply-To:Subject:Cc:To:From:Date:MIME-Version:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BeEd1bjgVqI+6WM8IxHn3yBv6gBN5vUlSzEvbSv2GPY=; b=yMmYS8VgDQ27kiSVRfsNHb29iE LPmdLaagH+bhjYa54+X3DMcJw/nqLZV5COm0Da2zOkefygoaxdrpUEvEHZmBtFVSzEFG9x1NIuXin I1E5JmsDND6n2nkV9HZuv+1p5MFjUc+FoJDbKytPhTvY0MRa2F7TDed2QfZrlyxmEPFezW39If8ZR llTMADSiNPRmBiZ72ZBx/mxD1WsEvyqYe2WHWTx83dzz1qTw7J73QFk0CDdeDSqELEzDMvAGMy+OK 9/A/IOH366nZ3vtIYr10sHMVvuSCsLkY1HJ6TRYo0Gx2ZTuUb633j1zBZovb0Pz192M3r0YlsTIN3 zIejNerg==; Received: from spamrelay.zxcs.nl ([185.104.28.12]:48016 helo=mail-slave02.zxcs.nl) by web0081.zxcs.nl with esmtp (Exim 4.93.0.4) (envelope-from ) id 1jprV9-004AMs-6x; Mon, 29 Jun 2020 12:59:03 +0200 MIME-Version: 1.0 Date: Mon, 29 Jun 2020 12:59:02 +0200 From: Pascal Roeleven To: laurent.pinchart@ideasonboard.com Subject: Re: [linux-sunxi] Re: [PATCH v2 2/5] drm: panel: Add Starry KR070PE2T In-Reply-To: <20200628072819.GB8391@pendragon.ideasonboard.com> References: <20200320112205.7100-1-dev@pascalroeleven.nl> <20200320112205.7100-3-dev@pascalroeleven.nl> <20200628072819.GB8391@pendragon.ideasonboard.com> User-Agent: Roundcube Webmail/1.4.6 Message-ID: X-Sender: dev@pascalroeleven.nl X-AuthUser: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , Mark Brown , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , Rob Herring , Thierry Reding , dri-devel@lists.freedesktop.org, Daniel Vetter , Sam Ravnborg , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent, Good catch. It's actually the connector type which is wrong. The connector_type should be DRM_MODE_CONNECTOR_DPI. If you would include this in your patch series, you can have my acked-by. Regards, Pascal On 2020-06-28 09:28, Laurent Pinchart wrote: > Hi Pascal, > > On Fri, Mar 20, 2020 at 12:21:33PM +0100, Pascal Roeleven wrote: >> The KR070PE2T is a 7" panel with a resolution of 800x480. >> >> KR070PE2T is the marking present on the ribbon cable. As this panel is >> probably available under different brands, this marking will catch >> most devices. >> >> As I can't find a datasheet for this panel, the bus_flags are instead >> from trial-and-error. The flags seem to be common for these kind of >> panels as well. >> >> Signed-off-by: Pascal Roeleven >> --- >> drivers/gpu/drm/panel/panel-simple.c | 29 >> ++++++++++++++++++++++++++++ >> 1 file changed, 29 insertions(+) >> >> diff --git a/drivers/gpu/drm/panel/panel-simple.c >> b/drivers/gpu/drm/panel/panel-simple.c >> index e14c14ac6..b3d257257 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -2842,6 +2842,32 @@ static const struct panel_desc >> shelly_sca07010_bfn_lnn = { >> .bus_format = MEDIA_BUS_FMT_RGB666_1X18, >> }; >> >> +static const struct drm_display_mode starry_kr070pe2t_mode = { >> + .clock = 33000, >> + .hdisplay = 800, >> + .hsync_start = 800 + 209, >> + .hsync_end = 800 + 209 + 1, >> + .htotal = 800 + 209 + 1 + 45, >> + .vdisplay = 480, >> + .vsync_start = 480 + 22, >> + .vsync_end = 480 + 22 + 1, >> + .vtotal = 480 + 22 + 1 + 22, >> + .vrefresh = 60, >> +}; >> + >> +static const struct panel_desc starry_kr070pe2t = { >> + .modes = &starry_kr070pe2t_mode, >> + .num_modes = 1, >> + .bpc = 8, >> + .size = { >> + .width = 152, >> + .height = 86, >> + }, >> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, >> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | >> DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, >> + .connector_type = DRM_MODE_CONNECTOR_LVDS, > > I'm trying to fix inconsistencies in the panel-simple driver, and this > caught my eyes. MEDIA_BUS_FMT_RGB888_1X24 isn't a correct format for > LVDS panels. MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > MEDIA_BUS_FMT_RGB888_1X7X4_SPWG or MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA > should be used instead. As I couldn't find documentation for the panel, > I can't tell which format is correct. Could you please help ? > >> +}; >> + >> static const struct drm_display_mode starry_kr122ea0sra_mode = { >> .clock = 147000, >> .hdisplay = 1920, >> @@ -3474,6 +3500,9 @@ static const struct of_device_id >> platform_of_match[] = { >> }, { >> .compatible = "shelly,sca07010-bfn-lnn", >> .data = &shelly_sca07010_bfn_lnn, >> + }, { >> + .compatible = "starry,kr070pe2t", >> + .data = &starry_kr070pe2t, >> }, { >> .compatible = "starry,kr122ea0sra", >> .data = &starry_kr122ea0sra, > > -- > Regards, > > Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel