From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFFEAC19F2C for ; Tue, 16 Aug 2022 06:28:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:CC:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=VSVNajbyQl6Y5qkRbJPy7iy3apUKNtqWcp2o15P5RXY=; b=zCfeEPnxjDgAmKXGX/I06oSQh0 90V4XyQc4mPy9Qs0pBYYPNcYaxEMnCVNirYrgp8gPbnBay4S/iFFBV1IDH4np5YM0g1Fx7HnJPdY1 AyMuZxfieWTnhVMBI8uNEQop0kxcdBjRVrcUl5+mzJwWw2ByC6uFOwOpbyRlJBi9H0vkrwDq4JrK0 x438zRFe1FseOgRCaJD1WcDaAYtnHImirL860E/PAukygvLEZwzRz/A8hVwtx8r0lsIcHb63/sBgc aPmdu/EVKGL+VtI+dqrn3stgvIxW1NZoKNEYhKPtL1IMCNJKcEGr+zmltfq7jsEYw2Me3I0S+B5Bf qulih6Yg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNq2Y-00DbM6-Ae; Tue, 16 Aug 2022 06:27:02 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNq2R-00Db1Q-HH for linux-arm-kernel@lists.infradead.org; Tue, 16 Aug 2022 06:26:59 +0000 Received: from canpemm500009.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4M6Lfn3YgtzXdjl; Tue, 16 Aug 2022 14:22:41 +0800 (CST) Received: from [10.67.102.169] (10.67.102.169) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 16 Aug 2022 14:26:52 +0800 CC: , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH] drivers/perf: Change WARN_ON() to dev_err() on irq_set_affinity() failure To: Greg KH References: <20220815092815.11597-1-yangyicong@huawei.com> From: Yicong Yang Message-ID: Date: Tue, 16 Aug 2022 14:26:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.67.102.169] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220815_232656_031250_C7DDCE2B X-CRM114-Status: GOOD ( 18.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/8/15 18:47, Greg KH wrote: > On Mon, Aug 15, 2022 at 05:28:15PM +0800, Yicong Yang wrote: >> From: Yicong Yang >> >> The WARN_ON() on irq_set_affinity() failure is misused according to the [1] >> and may crash people's box unintentionally. This may also be redundant since >> in the failure case we may also trigger the WARN and dump the stack in the >> perf core[2] for a second time. >> >> So change the WARN_ON() to dev_err() to just print the failure message. >> >> [1] https://github.com/torvalds/linux/blob/master/include/asm-generic/bug.h#L74 >> [2] https://github.com/torvalds/linux/blob/master/kernel/events/core.c#L313 > > Please point to git.kernel.org links, we do not control github.com and > it's random mirrors. > Got it. Will update with a git.kernel.org link. Thanks for point it out! >> >> Suggested-by: Greg KH >> [https://lore.kernel.org/lkml/YuOi3i0XHV++z1YI@kroah.com/] >> Signed-off-by: Yicong Yang >> --- >> drivers/perf/arm-ccn.c | 5 +++-- >> drivers/perf/arm_dmc620_pmu.c | 3 ++- >> drivers/perf/arm_smmuv3_pmu.c | 6 ++++-- >> drivers/perf/fsl_imx8_ddr_perf.c | 3 ++- >> drivers/perf/hisilicon/hisi_pcie_pmu.c | 6 ++++-- >> drivers/perf/hisilicon/hisi_uncore_pmu.c | 6 ++++-- >> drivers/perf/qcom_l2_pmu.c | 8 ++++++-- >> drivers/perf/xgene_pmu.c | 6 ++++-- >> 8 files changed, 29 insertions(+), 14 deletions(-) >> >> diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c >> index 728d13d8e98a..83abd909ba49 100644 >> --- a/drivers/perf/arm-ccn.c >> +++ b/drivers/perf/arm-ccn.c >> @@ -1210,8 +1210,9 @@ static int arm_ccn_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node) >> return 0; >> perf_pmu_migrate_context(&dt->pmu, cpu, target); >> dt->cpu = target; >> - if (ccn->irq) >> - WARN_ON(irq_set_affinity(ccn->irq, cpumask_of(dt->cpu))); >> + if (ccn->irq && irq_set_affinity(ccn->irq, cpumask_of(dt->cpu))) >> + dev_err(ccn->dev, "Failed to set interrupt affinity\n"); >> + >> return 0; > > Why are you returning with no error, if an error happened? > > Same everywhere else, you need to explain this in your changelog text. > This patch intends no functional change but to switch the way on the error notification to avoid crash the box. So just keep the current handling behaviour. Will mention this in the commit in v2. I think whether we should actually reponse to the error should be according to the driver. Thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel