From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53A7EC433F5 for ; Mon, 13 Dec 2021 22:46:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yR2aUKpmeSItJh5kBhuITZGSay0KVN3PEqa7C8u2mgM=; b=SbmcHSB4Qw1n9C +/eWin8J2XrFLx6Zi0MnFudjlxunwDbFTHt+3UP/po66Hi95EJS7/mpy0ScdHXXKeBZTcuszy7Pim mnBSDxIqYeEtqfWDo6cqwMUw4b046lYH3sVFgZD7kWWdakJh6Uk50ls5nF9kjWDsvEaapl8Dzmdmt PHxhOirx7ezAz1M6cEfMQZdVkJRlYyIy+NKDxZ5prw5Sl9CJyFHUOMxMU2e5eBxuuZ6Ti5IaCy5ek TzLiVSWCYrhNP0A1fq4XneytmmKmKAiS9xIIWFiroiCK98QnQZurNCUuNoIcbHPyxKugI0Rl7lBd2 b68iuUibHX0XgzYwdWnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwu3q-00Bppn-1A; Mon, 13 Dec 2021 22:44:46 +0000 Received: from mail-io1-xd2c.google.com ([2607:f8b0:4864:20::d2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwtvN-00BmiK-9g for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 22:36:03 +0000 Received: by mail-io1-xd2c.google.com with SMTP id z26so20742436iod.10 for ; Mon, 13 Dec 2021 14:35:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=g56lY2uZHfW8VuQb8w+7vuXp1OUfSK44r08Ap3amQlI=; b=XtPPRXIBsShqS0QNIdOKkK7eoeW0R/M0Bb/Zd7YLdbXp4DIUpqZ3sDLinT6XzbdMnO j38b+MEYzQCxmIT/0GmMlwa0mb5cM4m1oESIN3D8iRX5CxhLLvTx22NFuAm1Ye5tyQq6 HY3OFV/1bJEGfd6vZzcdejo3+lLnnCZ1FYUC4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=g56lY2uZHfW8VuQb8w+7vuXp1OUfSK44r08Ap3amQlI=; b=o39HlglcIQGCiXoWEyqraZ+PqB6pH0SzSYvMxRMFH2cdJIPRZJIY8e+4iPmLvTgM3N g6XHkzIu+CCh88EBABF8oLEGazSUH2IRI2WDRHDAkFtLr+5lHWlH3LsFMMVqhMgse/DQ 57WY/CQxXySPxM4DpjIJ0QtHoC4gKTAuJNb1YAgKQcDupcM/qHUAl754Y4gQQ5kI+rb2 tLOYmnlKdfPf6FuVZ1zG4yOwUurQaj8lWJrrDvS9JhSFSKbVMaqv/0Ccm4qCA0sxoyNq 4XZu9Sp0TlPHJEGMXrsNLME15yZVxMaVO9b+T07mAZmdfndJvyUpPMvUuOUBjAcRdYmp inJg== X-Gm-Message-State: AOAM5331pL2In3Hjp1kTpCls+bDpoKd5mGpdwBO7OXGMuke40d77XBF3 PqSQAAkGWFYGS8G3I1kxquta6Q== X-Google-Smtp-Source: ABdhPJzqPTbNv/Y0INIGTu2ApU1UUda2oXCk6Y9BzHyhtuxNTFNX7LW0gOeGKHGi85PMOaN1Fgo6/w== X-Received: by 2002:a5d:8999:: with SMTP id m25mr1049672iol.185.1639434958287; Mon, 13 Dec 2021 14:35:58 -0800 (PST) Received: from [172.22.22.4] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-2faa6b4da11sm107913173.27.2021.12.13.14.35.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Dec 2021 14:35:57 -0800 (PST) Message-ID: Date: Mon, 13 Dec 2021 16:35:57 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH V6 1/7] dt-bindings: Added the yaml bindings for DCC Content-Language: en-US To: Souradeep Chowdhury , Andy Gross , Bjorn Andersson , Rob Herring Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sai Prakash Ranjan , Sibi Sankar , Rajendra Nayak , vkoul@kernel.org References: <1765c436635ecc05fc463524c1e7517297660728.1628617260.git.schowdhu@codeaurora.org> From: Alex Elder In-Reply-To: <1765c436635ecc05fc463524c1e7517297660728.1628617260.git.schowdhu@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_143601_422723_E4AEF8A5 X-CRM114-Status: GOOD ( 18.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/10/21 12:54 PM, Souradeep Chowdhury wrote: > Documentation for Data Capture and Compare(DCC) device tree bindings > in yaml format. Even though Rob has already reviewed this... I think it would be nice if you gave these memory regions names, such as "config" for the first one and "sram" or something for the second one. It's a little more descriptive than just looking them up using their positions. -Alex > Reviewed-by: Rob Herring > Signed-off-by: Souradeep Chowdhury > --- > .../devicetree/bindings/arm/msm/qcom,dcc.yaml | 43 ++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > > diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > new file mode 100644 > index 0000000..b7a6619 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > @@ -0,0 +1,43 @@ > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Data Capture and Compare > + > +maintainers: > + - Souradeep Chowdhury > + > +description: | > + DCC (Data Capture and Compare) is a DMA engine which is used to save > + configuration data or system memory contents during catastrophic failure > + or SW trigger. DCC is used to capture and store data for debugging purpose > +properties: > + compatible: > + items: > + - enum: > + - qcom,sm8150-dcc > + - qcom,sc7280-dcc > + - qcom,sc7180-dcc > + - qcom,sdm845-dcc > + - const: qcom,dcc > + > + reg: > + items: > + - description: DCC base register region > + - description: DCC RAM base register region > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + dma@10a2000{ > + compatible = "qcom,sm8150-dcc","qcom,dcc"; > + reg = <0x010a2000 0x1000>, > + <0x010ad000 0x2000>; > + }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel