From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 919DEC433EF for ; Fri, 10 Jun 2022 12:31:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=slHyYyBKuiXlz/E9/BLTNattuZJLODM9tagvBZuM384=; b=L8BAyl1DGOITxp GEgF4Bm2XT8CEUMT4j8R/e64Vuap2lYefZ4ied7x6Vnj7FZY3h0fqpagFcK6kEDllNrUtX7u4jbwZ 21NdwWNeItJTFuwR65x540F6oyepkA3ERpvXP4zOcLh1FoOmjPBhqzY4Fq6aiNpVbhhewoAnHHY/I jtJx2kT70/gqOEfaN6zBvF2Tk3315gOWPOKD/MLOQXhB/PB/WnijqugrluIFl9trhvt0zgor1DyFo RKHd+xR01cXU1TSuzH7XKKT8eBmbfawtE2VP4y2y1A2mshpMK/l2sW9Wsutm2obwqIZsM+hHGduwo fj61odHDEJfXQ2dMiStQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzdmc-008BpW-83; Fri, 10 Jun 2022 12:30:34 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzdmX-008BnA-PV for linux-arm-kernel@lists.infradead.org; Fri, 10 Jun 2022 12:30:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1654864229; x=1686400229; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=svmW5U0Z9he2HzIeK/J2Y/ziJeZ++fzfGueyuSPD3ko=; b=XB0z7+ZEJWyyfvAbzA+bK3/ywMkMLQrFAprXI+rNs2XAwPCcxrGvbryY pmJ+QHxQATE4viRgadijsxWfhQC5bKwnf+7RKhpQnM6gNzRJVcZfdDjaN 3yeuP3WXhZZfpiPwmPkSPF4Xza7o8E4E9zcm4eptybmPPaFEcYVjRKx3W BDdW8GQhBIQXOgueNOV76prIAADqh4YTXk7N78XmVsfoAlOp09hz8bIKq Gy3ybvmdWufUQJxvrtAYItiZJLfcsYVBr0V5MaE2NySAyWt0aDymbr6Yv iHPqPNwHaEUzVB4fbIYMkrtwDVrMEOmKammAaCUZ39yTI3Ar7t/7HPB2p w==; X-IronPort-AV: E=Sophos;i="5.91,290,1647327600"; d="scan'208";a="167906512" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 10 Jun 2022 05:30:24 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Fri, 10 Jun 2022 05:30:24 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17 via Frontend Transport; Fri, 10 Jun 2022 05:30:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lT+9pG6bVAULNjkzDPLWTyBE+sRnsycQNbKutJ6uihVS/ti+wtZa6GHsrM+0Sjo7dxl3erur4oyVaRrj7RW7KOi+mX6lCCAYmGoZDBKy9Yhuo9eRJVtyKjxgjbdwKqNxoWZoOzX2InzCL7MQ2DtdEH6QuP8x1CArRjGb4SIq0H6kMqkw7ngfG7fv4f8tb/PpS8nYDo2CmSwgrZsO8BmNfln0ZYPk2hiHGtztRphqaUbdvNuyc7kjZJKUopedNMFTYGZJ2SCpQKMi5WBcH8fD4QHODQZDr/fO11ecdLnNHOGiNK+KCc3wib7ulvE+3+68NbijJpDo4X/NyExnVhakmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=svmW5U0Z9he2HzIeK/J2Y/ziJeZ++fzfGueyuSPD3ko=; b=aq/GHPZdSxoK/CZSs/oSfmaiTOtgwu+BxuxOzqLDs/AD6oL/G80KHZrqey3whEZ1iLpuugpXYfrMN80DcJWRpO5TZ1D/4jogpRqImpl66xVSn8aCnM6gqhWS4YAMd2BGNTD+sD1pgBXEG1MBtz9z9iSG33kfBAeO9127K8iUJygloZ0YMjhlPAAqpDVSItX6BflBWdvELX3E/prL+J+h12U/Kv+cqu/MONq1Qt1sgmimY6Oi+0c4Lyb7OByEx7z4Tyd3eqlilzaabCbXMYEWmG+AlGzJzAsIpEl+zhrQ6m4LKEAN7qSbp6mdFYk4U2eKVCzTHfHtDMuvWIYy0gEHRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=svmW5U0Z9he2HzIeK/J2Y/ziJeZ++fzfGueyuSPD3ko=; b=aieAZuCvymjIUCahJk8q7CN/SAjFlgcO6QAMou6HzVp0FprOOwkDsa7XDsyMF/zu41SCsA2CzA3uIY9dbLgFudbnvzmpJe5SaIbw00/mGo/irJ/gYUyTLOw2/BfIvCy5sVasRqXD+t2tJvrHUsJrOpXsF3jcZo7s3S5eLMilMVg= Received: from BN6PR11MB1953.namprd11.prod.outlook.com (2603:10b6:404:105::14) by MW3PR11MB4697.namprd11.prod.outlook.com (2603:10b6:303:2c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.13; Fri, 10 Jun 2022 12:30:19 +0000 Received: from BN6PR11MB1953.namprd11.prod.outlook.com ([fe80::5cfe:8088:aa93:fce8]) by BN6PR11MB1953.namprd11.prod.outlook.com ([fe80::5cfe:8088:aa93:fce8%3]) with mapi id 15.20.5332.014; Fri, 10 Jun 2022 12:30:19 +0000 From: To: , , , , , , , , , , , , Subject: Re: [PATCH v2 44/48] ARM: dts: at91: align gpio-key node names with dtschema Thread-Topic: [PATCH v2 44/48] ARM: dts: at91: align gpio-key node names with dtschema Thread-Index: AQHYfJlzLzmpENQpa0qlfZV/GJNK/A== Date: Fri, 10 Jun 2022 12:30:19 +0000 Message-ID: References: <20220609113721.379932-1-krzysztof.kozlowski@linaro.org> <20220609114047.380793-5-krzysztof.kozlowski@linaro.org> <42e8f573-cfc2-dfa4-1740-b0a29521628e@microchip.com> <537986d4-376e-d787-1581-cf0b0d525daa@linaro.org> In-Reply-To: <537986d4-376e-d787-1581-cf0b0d525daa@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 97cbd04f-7f29-400a-df98-08da4adcfafa x-ms-traffictypediagnostic: MW3PR11MB4697:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y/0KXdACLqWz55PWhLlSvtqkCResrMYIU/HWOl91rl3GfF8juJjLDbwCIs8iEbTsMsH1B1qhM2emnvRvucsQQADHXX7LNMMdTekkNNttxR/MnYMqBIatmamLUnkEiRPf2pkF7TtoywxDb4lKSJMVCT8gXpN7mRO77EOZiqkgoygR5wlTqF/43QARiEgzkkE1e9MtA1ezum5E9gcjELQB+P6tZhK3Dp750mQmZBZcGg23E8H1qFun13fHHARCq23xIFEaxY4vOKN/NUU4AYXSkobVBqXClqOWJVFqsaF4Bid0nIH0P5jo3Dc1NNmWyTwdRR3Jna9q/crnXBDF5hsAufaLoR5QTe5GaJkiurnT+6+WYXBSRnQov0+oylVMbz2ZvkouBsvnotcgA90PaUttnDRAovlHjDesetOFriI+1QQcUFhSR5jkXaMReO6YQjpJVf8RgQPrw45E8AZ8/kVCSF1EIGbbti1k/zUXQMIRSLJXg0ucKdS4UVcrkjQe7cQIVQDTkp8JOaYxq5E915EuzzVmU4YLCDMeDAcfC6goU7t8LScsX90mrzSCd+0R95S/qPGtnZwLZkWhy+FexaF2Nmh5x0x8xhuH8/SqY0XT/PgTpigZNjOV9CiIuMf6Bca35HWlfp0vU/5/D7u0sWCGssSZrEBDTthhyGiSJVWYhSz24w9VWkzU+ROyMusFzjAO2pXEmNCrESeDwlLo3SlHBEHV/u4j8tpZZEwCXD5x8LfDwnsO/xht0wqUlXpANE6dfOKPUv5YuGmNMLT674/c0aagjMssThWaT6jk5oORYuU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1953.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(7416002)(6506007)(26005)(6512007)(31696002)(53546011)(86362001)(5660300002)(508600001)(2906002)(6486002)(2616005)(186003)(71200400001)(66476007)(66946007)(38100700002)(76116006)(38070700005)(110136005)(66556008)(36756003)(91956017)(31686004)(316002)(8936002)(921005)(122000001)(8676002)(64756008)(66446008)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Qk40YW11NXpIT3ZqRDRaQ3c5OWZhUHhjOUxhTnA3YkRKa0QyTHhDR1RsdFlo?= =?utf-8?B?bm1oQ1A3b1F1RTRhR256R3ZWS3QrRkZnbGphRnRJY2Y2VFBvVlRieDhneXdS?= =?utf-8?B?dFdSdm1Wc3ZjekU0UGV0Y1RQV2pEQWdiN3piWXdGdUZQbmdRODZ0UDFyNEpy?= =?utf-8?B?ZUc4Zy9uRFhrT0M2bmp4Z2J6SnFHMFBva1NxbDllRlpnMHNvbTVqdkRpWDV0?= =?utf-8?B?QjlnMmJsSWtOVjluSWJCR1BQZmk2NGJCN2VKV0lPTGFqZjA0RDVWcTM0WEtX?= =?utf-8?B?bTZsTk5kUzh4U2VLR1I4U3VvTWg1d0RDazdVRUh0UlRxbzNRWjZOSVRWWm1V?= =?utf-8?B?MjV2VnFGMzJ5c3NwWDJ2Q055VmdkQXlKNUZLVEcxVmJQUVFoZ1JRc0swY2x2?= =?utf-8?B?VWtWYlhJV01hdDkzZWNIaXhFK24ySTRvcnMycjJuQXRKWXc1STEzYTRld2Q3?= =?utf-8?B?SklyaWpRL0syTU5oUzA2enNGSEhXRitxZXoxUEZWSlM3OGNxMU43Rld5T3p6?= =?utf-8?B?d3A0Vi9NUFZQclM2TDZ6OGFIekhHNGRuT24wT1NnSmxwOVN5VmMwVU1FeWlS?= =?utf-8?B?Q3FCVThmTXV1angra1lEUjJTdkk2Zy9KclRjVlRVMUI3K0JRcEdPaUdVRTdG?= =?utf-8?B?eFgybDAyRGhwUXc0QjI1SkZOTDdiWEVLYTdaKzdDNHpaeHcxRTIxMkQ0K2l1?= =?utf-8?B?SjNJS1NJZnhHY1NRYnFnNThUdFVtN3U4MStxWHpJaDhxa3h1RHgrZkVkbmJw?= =?utf-8?B?OTN4bU9LczhKTzdOSmd4S3h5cXBkUTNYWm14ZE15QmIxNytHS3AwUEN0VXgr?= =?utf-8?B?YWF2SkVINDZMNXRHOWhoNUJGL1BDN1ZadkN5Myt3bjFBaFF2ZDdodnFQbVBq?= =?utf-8?B?a0s5V3RLNVdIWkZuODN4bVhydlhSRkwxM3NhbVJnTStRUXlINUV4cm16OEhi?= =?utf-8?B?dks3OUQ4a3M0a21FVUFmeXpKV2FDc1lzeEtaQ3NkVnQzUDBRbkVmZmxKUVRi?= =?utf-8?B?TzF4TzFqcU1CQWg0UENUTmJaaGJ4VTJSKzNvNnpLS3JGL29jdUo4VU1UZFVt?= =?utf-8?B?dWluMUQwMVQ0QjRYM3hPbE9MWEREbDJEcnQxUlZJaUE0eXJDREJuaEtmWlQ2?= =?utf-8?B?Rk5kcUNtVSt6b1lBU1RjYUYybHhmQzJHM2RBTDc0bDVyamQySjFadG14NG9n?= =?utf-8?B?dER1SVpBZ0YyaTNodzZoZXFnKzhqamd2c0Q4akVjeDQ4M1JhUnVjcHZYS0J0?= =?utf-8?B?NlBLMmlFcktQNWtLNVA0blBRUmprc0ZvdW1qOW4ydVdMa25UV3dRTjQybTRs?= =?utf-8?B?UmtEZllJWERGa0VoYlN4ZzlabnZOTTluYUVLVUtrZ0Z4YUlvbHVPQkRGbjZ2?= =?utf-8?B?bjk1R3hIaG02U3RmcGh0UDNYZGExYTlQTlpuWWZhckJrTmdUaUVjU3gwbGlK?= =?utf-8?B?L2gySXQrVDVoQnl5cTdMOGlXVFE0akJYRzR5T0hlZ3RBOGNoZSsrMmRSTll1?= =?utf-8?B?VzZEbCtFdDFCS1lNNUVwOGwveVNsaUIyTkhZcnhwaGpLc2xiVkdIbURFYVBK?= =?utf-8?B?KzJmcFNKT2h2d2NrTXVVa3JvSjdQVFhYR041SjBnS0gwbnZKOGZVWW1LbCt6?= =?utf-8?B?Qk1vdzgvdkgyR0ZBZ0w5ZUpiQU9ZVFh0R3RMSzNkajlEV1RTNXNuOEJTT3F2?= =?utf-8?B?cUVKSGkra2lqaGcxUEdMMHdTL2dtUW1vQU9kYk5zUEZoVmR0M1VobXV2aXIw?= =?utf-8?B?YXhXTFpEUGFZWS9PeVpZZDFvVllheWtzWHZUaUUyL2FiUklISVF1M2ROeFhj?= =?utf-8?B?aG83dkkyUmZMUnZCazdlWm04UkYxTHhmc2FQczdGOHhUc25WdnhNaXRCK0VZ?= =?utf-8?B?MkZLVXdhR2UyeHZyY051dE5rUDF0R3ovRWsrL0J3bjJHQlUyVXljYUJXeklB?= =?utf-8?B?V0JWU09hazNVUmxCVy9wTTQzL3hOV2VLMWJTd2lEVzBYeEplTW52anlWajR4?= =?utf-8?B?V0VCSndHQ3hnL0E0TE9LbmxObG1wWFhKTnVXa2M2RGdSL2dqU0pSRlNDbUZ6?= =?utf-8?B?a0hjN2YrTkE2UzhWdFdwRGxkTlVLeWo3NDJTejI1VTd1Z1Y2TDhNS1NqSnl4?= =?utf-8?B?MzJOWlArS1pmeFh2QmVGODl6K3YwTnVLZDhHNWJZLzZwOXlYWWhSWGUzUUpY?= =?utf-8?B?dWkzb29CNFR0Yk9PYis3bFJoTlJmeHpmTTREbDdwRG5OOWc1R2JHam5rVGxr?= =?utf-8?B?Sm1waFI1RllBWloxQ1NmQzBzbGFObHhTamZjUHoyYmt0d0x4VURKR29rdVQv?= =?utf-8?B?T2I1Mm05VS91NmRTNFZPMVR1WVJ0MzNmNkhIYTVMMWRlOW44QUFlRE9TWWJ2?= =?utf-8?Q?VjxQ7zErSvBVC0eQ=3D?= Content-ID: <48BDD764058EB9458810DDEE090A846D@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1953.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97cbd04f-7f29-400a-df98-08da4adcfafa X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2022 12:30:19.0196 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /0x7cZKFqdDz4KXEotMFqn5bQx/9R657GwrbALGW+FQho7DPYKPzSytakqApWFq7KBXhkBxAqn/TFHWiIWsLH53dgifC/wZ46xNpNjjbaqU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4697 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220610_053030_105979_F7D212C1 X-CRM114-Status: GOOD ( 18.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10.06.2022 13:05, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 10/06/2022 09:12, Claudiu.Beznea@microchip.com wrote: > >>> compatible = "gpio-keys"; >>> pinctrl-names = "default"; >>> pinctrl-0 = <&pinctrl_key_gpio_default>; >>> status = "okay"; >>> >>> - sw1 { >>> + switch-1 { >> >> This is acutally a button labeled on board as SW1. It has been wrongly >> carried over from older DTSes. Maybe it would worth to have it now here as >> button instead of switch. > > Sure, I'll name it "button-1". Could be also "button-sw1" if ou prefer. button-1 should be enough. > >> >>> label = "SW1"; >>> gpios = <&pioD 18 GPIO_ACTIVE_LOW>; >>> linux,code=; >>> diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts >>> index 08f0d4b995ff..96c9290007a8 100644 >>> --- a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts >>> +++ b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts >>> @@ -478,13 +478,13 @@ can1: can@fc050000 { >>> }; >>> }; >>> >>> - gpio_keys { >>> + gpio-keys { >>> compatible = "gpio-keys"; >>> >>> pinctrl-names = "default"; >>> pinctrl-0 = <&pinctrl_key_gpio_default>; >>> >>> - pb4 { >>> + button { >>> label = "USER"; >>> gpios = <&pioA PIN_PA29 GPIO_ACTIVE_LOW>; >>> linux,code = ; >>> diff --git a/arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dts >>> index 5e8755f22784..d5652c974748 100644 >>> --- a/arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dts >>> +++ b/arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dts >>> @@ -26,14 +26,14 @@ chosen { >>> stdout-path = "serial0:115200n8"; >>> }; >>> >>> - gpio_keys { >>> + gpio-keys { >>> compatible = "gpio-keys"; >>> >>> pinctrl-names = "default"; >>> pinctrl-0 = <&pinctrl_key_gpio_default>; >>> status = "okay"; >>> >>> - sw4 { >>> + switch-4 { >> >> Same here, this is a button not a switch. > > Sure, then button-1 or button-sw4 I would say button-1. Thank you, Claudiu Beznea > >> >>> label = "USER BUTTON"; >>> gpios = <&pioA PIN_PB2 GPIO_ACTIVE_LOW>; >>> linux,code = ; >>> diff --git a/arch/arm/boot/dts/at91-sama5d2_icp.dts b/arch/arm/boot/dts/at91-sama5d2_icp.dts >>> index 806eb1d911d7..d7b59e16a081 100644 >>> --- a/arch/arm/boot/dts/at91-sama5d2_icp.dts >>> +++ b/arch/arm/boot/dts/at91-sama5d2_icp.dts >>> @@ -42,14 +42,14 @@ main_xtal { >>> }; >>> }; >>> >>> - gpio_keys { >>> + gpio-keys { >>> compatible = "gpio-keys"; >>> >>> pinctrl-names = "default"; >>> pinctrl-0 = <&pinctrl_key_gpio_default>; >>> status = "okay"; >>> >>> - sw4 { >>> + switch-4 { >> >> Same here, button not switch. >> >> Other than this, looks good to me. > > Thanks for checking > > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel