From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EB9ECD3431 for ; Wed, 4 Sep 2024 11:47:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wTREUnJxyoCNhIqHFTVGv6xTm49QnNFwwAlK4goyToQ=; b=MCaaxmqDmr6I47AnuUAQtpEf15 przHZ4poWbjkYd4GOC21lCAqx8oyiZESqbeeDLme+Ajo7dLcB8YKe3KtEpGyzKTMHpEZm4U3TUxBN hljGDcF1v03hVvfNmBTMpuxrD6Pe08KgKEjnCro2BXdpViEqlCY7t+xJy3yFGIIG/CBbRnIQCaqWS w5fiADH7Yyw7OPFuitmbs/llrGN7qHsJj+GDUuRjJ8GSKv81hIHsvwLD9JGx5d+B5lUrKsv14612h yQQI7ECPdJ0GKzEJBUZK/AxuC1r6q7ZQ7aVH/WXq2A3ACQc9ulzk3BOgWLMruTkuMwqRMA2txCHU4 EzgJUibg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sloTS-00000004DeA-3G1G; Wed, 04 Sep 2024 11:46:58 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sloCe-000000049LU-0BkE for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2024 11:29:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id DA257A43FAF; Wed, 4 Sep 2024 11:29:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6BB6C4CEC2; Wed, 4 Sep 2024 11:29:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725449374; bh=IbTO/VrN9chRHIbadlaqKaZrqY35Ivbs3FjR5xZuAkE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GlOlmIXI5IRmIy4MvvV51X9PeO9cBBWw1dSsdJ/A/fZNZVyUAKv8lOYlcImwOzgaQ oA7h4heWcFj2VsAb7QD6shcmnfi9Ou3EPTo4lkQU3A+XeUht+OOqFcv+0p9CDQNMKo bx802WS9+9vAMg5qThbA9bOklo8qz4px1Q1fMqgEC5ceZRM+JJ6zO0Ni0RojPJDADl VeZCfzxoUgjtHaMcubBlxXAp2vBRsgYQq6WW0OQ2UkIqbQDHoxr2Rwf/LXI+1xZSZc bV3khTAcZq1DkkjOvIp92b58eljiGp5h124ERqsM+PWfSqGEoU2XS3cpHSWwBoqf1g EZfQ9Y9s5yjhg== Message-ID: Date: Wed, 4 Sep 2024 13:29:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 1/2] firmware: arm_scmi: Ensure that the message-id supports fastchannel To: Johan Hovold , Sibi Sankar Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, konradybcio@kernel.org References: <20240904031324.2901114-1-quic_sibis@quicinc.com> <20240904031324.2901114-2-quic_sibis@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_042936_183419_189C714F X-CRM114-Status: GOOD ( 15.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4.09.2024 9:00 AM, Johan Hovold wrote: > On Wed, Sep 04, 2024 at 08:43:23AM +0530, Sibi Sankar wrote: >> Currently the perf and powercap protocol relies on the protocol domain >> attributes, which just ensures that one fastchannel per domain, before >> instantiating fastchannels for all possible message-ids. Fix this by >> ensuring that each message-id supports fastchannel before initialization. > > Please include the warnings that I reported seeing on x1e80100 and that > this patch suppresses to the commit message: > > arm-scmi firmware:scmi: Failed to get FC for protocol 13 [MSG_ID:6 / RES_ID:0] - ret:-95. Using regular messaging. > arm-scmi firmware:scmi: Failed to get FC for protocol 13 [MSG_ID:6 / RES_ID:1] - ret:-95. Using regular messaging. > arm-scmi firmware:scmi: Failed to get FC for protocol 13 [MSG_ID:6 / RES_ID:2] - ret:-95. Using regular messaging. > >> Fixes: 6f9ea4dabd2d ("firmware: arm_scmi: Generalize the fast channel support") > > And add: > > Reported-by: Johan Hovold > Link: https://lore.kernel.org/lkml/ZoQjAWse2YxwyRJv@hovoldconsulting.com/ > > (or use Closes: if you prefer). > >> Signed-off-by: Sibi Sankar >> --- >> >> v1: >> * add missing MSG_SUPPORTS_FASTCHANNEL definition. > > Unfortunately, this patch breaks resume from suspend on the x1e80100 crd: > > [ 26.919676] CPU4: Booted secondary processor 0x0000010000 [0x511f0011] > [ 26.960607] arm-scmi firmware:scmi: timed out in resp(caller: do_xfer+0x164/0x568) > [ 26.987142] cpufreq: cpufreq_online: ->get() failed > > and then the machine hangs (mostly, I saw an nvme timeout message after a > while). > > Make sure you test suspend as well as some of the warnings I reported > only show up during suspend. Eh it looks like PERF_LEVEL_GET (msgid 8) requires the use of FC, but the firmware fails to inform us about it through BIT(0) in attrs.. Konrad