From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C4DDC25B4E for ; Sun, 22 Jan 2023 18:08:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C1XDLnbgsX8k+6BSZ0K7SqJ4UMSFeoCp5C2RATuaE9s=; b=xiE3rhkb2F0K2V lHZGWy73JMQHOR6zghcr8HmKtFItcc4FNVinM8pw4+JsJROk2xhfozNGxR55YhR2/iMEvUXG+6ukg 84YWfmrS2vI6LJeZ394E6zUQ17hXM2cbEoMUqblwtZLcOskiOZt6fLZxJayGFtXfvdQ8fTPKTvCdp SSA+OQaxBguXyodzeZi5BeVuwqfKTHiy2IG2Q6AkC0/KUZMwyGIArTT7GVa4WCl00S9VfjMXtSySG VMPrHxhddshWEcNjSdNzjSiVtG/4iNE7VdlHuHdhfWiiKIWoeoyI2UgGL60gPxo7hPSz+LgXElMtG dwQweagrm7XTV2tskf3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJekO-00FdaP-2e; Sun, 22 Jan 2023 18:07:16 +0000 Received: from mout.kundenserver.de ([212.227.126.134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJekJ-00FdYK-2j; Sun, 22 Jan 2023 18:07:12 +0000 Received: from [192.168.1.140] ([37.4.248.41]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MCbZL-1pSh2J2Lr9-009h6S; Sun, 22 Jan 2023 19:07:04 +0100 Message-ID: Date: Sun, 22 Jan 2023 19:07:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [RFC PATCH 0/4] Drop custom logging Content-Language: en-US To: Kieran Bingham , Umang Jain Cc: Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , linux-arm-kernel@lists.infradead.org, Laurent Pinchart , linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-media@vger.kernel.org, Phil Elwell References: <20230118115810.21979-1-umang.jain@ideasonboard.com> <167440481093.3533645.5465896340839457121@Monstersaurus> From: Stefan Wahren In-Reply-To: <167440481093.3533645.5465896340839457121@Monstersaurus> X-Provags-ID: V03:K1:3LoHo9gwT8fEKNlygma/ZKXx+M0p0Msa87/rCMrJWR2nOAMsnFj kpv26zOg2019DjFdnNbqXVwOU/FE36Daqkm6klbrqr01/uqS2JqWeyew4008xxGgDaicyLn py948NXoDqWDoJijgM9zA0ZHlJlr2sknEdgz/z0punD+byCwo3D3Usv0MH9Vwut6R7tHx9m HeMYMYOkDYwHNsSvf6nkw== UI-OutboundReport: notjunk:1;M01:P0:DmJxfvGQ3b8=;0h25chXEKwuSz9LG60C6pfR5XX7 /67lhnZG600Mof7qx+8AJc2bqITkyyxWQYYq0PAgAZKyjwQ4MZkQn2mpxYU0eqcEYdFgzmzW6 SJmjlW/4hqeGVnYdiq4VOJ2+HlFx0wcZ0KrcQ7J4fFlrc+44Xm3q25PHWOgeTxoCiwTFjb1fN 8XK15t1RVyg+vzq5Hk5gAeesy5/Tz4iuPoUH28RV85E3K3kFRIkVqZiWwBQPZfoSC6pQAGzUP ghkMM+2Q7yS93+oDI4Jk4C3Dk3+/CoU7ejUwYFa/EfAsyEd15iIEMQS8xBsco6odUG6uJeMR5 ZgALARGj5GO1XXKnkkYTNlOolpWHqGUQbZF/Nf1/854/6EGDw9dslRAeOpdW0DLEM35EFw+fx 2BSa0M3LftzTOL9M8+V1YAMx6B9L60pgWXrB5RchPOGLI1Nkucn7LO+JKyVE2Yjjw9O5hGEKh u5ZMJD5UliiAD9S0/+3YH2bSrMhbK9nAolVJhlsZMhnT/V2UEd1p+EEjmDBe6hn8zOX/mss36 nkg27j1f/BllBCpa1arx1uBUkf8u2FiquzP253KgEWD/lOJmtPitI0SGTxkvN4jWAOnx3Ps90 y3IV9XAQqmojEdPorGtcTStcFNBwyQpv7y6NO/HFFhqjuzIgdTJbaYZo9dZazGUjeq0+StlzO FFM4ysKS/dib30gQYz1S9W4l63FbujUe39g45YEBRQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230122_100711_444459_CB402016 X-CRM114-Status: GOOD ( 19.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Kieran, Am 22.01.23 um 17:26 schrieb Kieran Bingham: > Hi Stefan, > > Quoting Stefan Wahren (2023-01-22 14:21:05) >> Hi Umang, >> >> Am 18.01.23 um 12:58 schrieb Umang Jain: >>> Drop custom logging from the vchiq interface. >>> Mostly of them are replaced with dev_dbg and friends >>> and/or pr_info and friends. >>> >>> The debugfs log levels (in 4/4) are mapped to kernel >>> logs levels (coming from include/linux/kern_levels.h) >>> Would like some thoughts on it as I am not sure (hence >>> marking this is RFC) >>> >>> From drivers/staging/vc04_services/interface/TODO: >>> >>> """ >>> * Cleanup logging mechanism >>> >>> The driver should probably be using the standard kernel logging mechanisms >>> such as dev_info, dev_dbg, and friends. >>> """ >> at first i want to thank you for the work on vchiq so far. >> >> There is something which is not directly related to this series, but it >> is also about debugging. The driver has a buffer which is accessed by >> it's own DEBUG_* macros. The content of this debug buffer can be dumped >> via the /dev/vchiq which is also used by ioctl. I would appreciate to >> move this dump feature into a new debugfs entry. > Do you have a full list of the tasks you'd like to see completed ? > (including/or above drivers/staging/vc04_services/interface/TODO) i consider every point except of point 1 (importing new drivers) as necessary to leave staging. Additionally there is the additional point (i can add them to the TODO) above. Unfortunately i don't have a complete insight, how vchiq should be to be acceptable. Sorry, if i can't help you further with possible resource planning. Are some points on the TODO list unclear? Thanks > > It would help to have a clear picture of tasks needed to get this driver > destaged, so that we can support the ISP upstream. > > Regards > -- > Kieran _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel