From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70444D3C927 for ; Sat, 19 Oct 2024 17:46:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PRj6wTpD75QHed7bSW8YYhEbTeWgjrOBfGGAMImrNsQ=; b=zYZOoG08HzOEZTHfhXzuCJYI8F Z/3Oql0SVfERX1T1SdsyqHrFMbFgFp8g5FZUVSFWUBTJoSPew7Fdhqa/M/kqQJTIi0ohYz+yfTWFN 6A15seLS7hF6bRFGuimcnCIt6y3LIWeCLNRWwMpE/B5eIR8JE5KBP4t93TcTlM4S0KUgrvNelNaLc tXAG7LeyUdVPQrrs7kfAK2mW+v/sguVpybs2cR0tBb07+5a0yPb/oWtzRz7unmocSxxCCnfmGhHrA vD4fYBnj4MD2otOIi0xnQk7zu+NM4nEc++IdLIVeVcSIkB8ive/XYxsdVmnYbq46vyHC7meNS7NwO bZXzk5QQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t2DX5-00000003irr-2ot1; Sat, 19 Oct 2024 17:46:31 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t2DVa-00000003ifU-2NMR; Sat, 19 Oct 2024 17:45:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1729359896; bh=NZE8zSnUWmDXLsUVhD56gHK8qtI4r/t43Zp/rgthYv4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ncLvRWwyS8rIrN2bKTiI/fsu2q66JQH4rEBbEW/WUACLWcqYhrbV2WQ7f87gi/aVN VKlBxPCk3c6V6KXoFU47xRhYk0lU9bjAu0fpCokbvbHRcatfoKtT+Pah+scR4tblfv Ih7tIBIqwLi7kuTpGmcP1TIXkkRCnKYuOs0r/FhnhHbOX304xlvHJhIm9gQywLIZmd yQfNTwxeXUu36dCDlfxr+Hrw3aABFKjjBMz6mLqgx4tb4A0OXotwPwJTvfhXBKlT0r IdgNGZVUY9MSo+6bXpW5I6kv4en23W6ZhXEtgwSRlt2kGAZG/1NhXJZkyivPLEZE8y 0ysbkTdNiyBiw== Received: from [192.168.1.90] (unknown [188.24.146.62]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id DF67517E3692; Sat, 19 Oct 2024 19:44:55 +0200 (CEST) Message-ID: Date: Sat, 19 Oct 2024 20:44:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] arm64: dts: rockchip: Enable HDMI0 on rock-5a To: Jonas Karlman Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Sebastian Reichel , Luis de Arquer , Alexandre ARNOUD , kernel@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20241019-rk3588-hdmi0-dt-v2-0-466cd80e8ff9@collabora.com> <20241019-rk3588-hdmi0-dt-v2-5-466cd80e8ff9@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241019_104458_807754_C2D44201 X-CRM114-Status: GOOD ( 11.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jonas, On 10/19/24 4:02 PM, Jonas Karlman wrote: > Hi Cristian, > > On 2024-10-19 12:12, Cristian Ciocaltea wrote: >> Add the necessary DT changes to enable HDMI0 on Radxa ROCK 5A. >> >> Signed-off-by: Cristian Ciocaltea >> --- >> arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 52 ++++++++++++++++++++++++ >> 1 file changed, 52 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts >> index 87fce8d9a964cd53d179ce214ae1c0ff505a2dce..2b141af5e709b0bc2193dbfb2327e6bc1fdaa502 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts >> @@ -5,6 +5,7 @@ >> #include >> #include >> #include >> +#include >> #include "rk3588s.dtsi" >> >> / { >> @@ -35,6 +36,17 @@ chosen { >> stdout-path = "serial2:1500000n8"; >> }; >> >> + hdmi0-con { >> + compatible = "hdmi-connector"; >> + type = "a"; > > ROCK 5A use micro HDMI connector type, so this should be type = "d". Indeed, good catch, will fix in v3. Thanks, Cristian