From: <Conor.Dooley@microchip.com>
To: <Ryan.Wanner@microchip.com>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>, <Claudiu.Beznea@microchip.com>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] ARM: dts: at91: sama5d2: Fix typo in i2s1 node
Date: Thu, 7 Jul 2022 22:11:46 +0000 [thread overview]
Message-ID: <d4de4dca-de58-2e7f-ad49-dc2cb1d275aa@microchip.com> (raw)
In-Reply-To: <20220707215812.193008-1-Ryan.Wanner@microchip.com>
Hey Ryan,
Just a couple of nit-pick comments:
On 07/07/2022 22:58, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>
> Typo in i2s1 causing errors in dt binding validation.
> Changed assigned-parens to assigned-clock-parents and
> to match i2s0 node formatting.
Commit messages are usually written in the imperative, so rather
than "changed", we usually say "change" etc.
>
> Fixes: 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers")
>
The blank line here isn't needed.
I wouldn't respin a v4 for this unless Nicolas/Claudiu request one.
Thanks,
Conor.
> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
> ---
> changes in v2:
> -corrected subject and tags
> changes in v1:
> -corrected formatting issues
>
> arch/arm/boot/dts/sama5d2.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 89c71d419f82..659a17fc755c 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -1124,7 +1124,7 @@ AT91_XDMAC_DT_PERID(33))>,
> clocks = <&pmc PMC_TYPE_PERIPHERAL 55>, <&pmc PMC_TYPE_GCK 55>;
> clock-names = "pclk", "gclk";
> assigned-clocks = <&pmc PMC_TYPE_CORE PMC_I2S1_MUX>;
> - assigned-parrents = <&pmc PMC_TYPE_GCK 55>;
> + assigned-clock-parents = <&pmc PMC_TYPE_GCK 55>;
> status = "disabled";
> };
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-07 22:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 21:58 [PATCH v3] ARM: dts: at91: sama5d2: Fix typo in i2s1 node Ryan.Wanner
2022-07-07 22:11 ` Conor.Dooley [this message]
2022-07-08 15:16 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4de4dca-de58-2e7f-ad49-dc2cb1d275aa@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Ryan.Wanner@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox