From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D220C54E58 for ; Wed, 13 Mar 2024 22:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fElzmVw+W2bKzoA5EB+HGLQ0DpPABtWjp+inNZNuC0A=; b=3wLXVD6mrc2gNn e2jAugs3Wyf+blROKy35S5ivQ21v1OFtbfoR+Nr2ccaW8F+3VAuM9u2eQXFaucw5spwRmUEA+uub/ q6hk3urn80ANwRWtx2nWY94bBx9ndnFfv8Tasdnd0kZ+pyXlAySUobLKRuW/AxgNN01ll9a9QbGuC hPVTGfxcjkrag1sok3IyWfaVSAETG+fB3yEKamyytyiYf6ILg75uRmgJ9tVcBxMi0YUy58M0sIhd5 Q9roqqHg8YC4kE4pEWpJoBOrKeTWKi2Xl3ETLVDcNcDr2FZtgIx6TwZJhc7N/NjybJ9qCUp/YFuWV bK1n8iNMgZP+Q2OiAJDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkXTd-0000000CBY8-4B5R; Wed, 13 Mar 2024 22:53:38 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkXTa-0000000CBXA-062W for linux-arm-kernel@lists.infradead.org; Wed, 13 Mar 2024 22:53:36 +0000 Received: from [192.168.68.112] (203-57-215-238.dyn.iinet.net.au [203.57.215.238]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id E87FF20016; Thu, 14 Mar 2024 06:53:20 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1710370403; bh=cydJ+54ejYfm2ccD8VUDb0oN12f6pOX+IdLF5Scs4ZU=; h=Subject:From:To:Date:In-Reply-To:References; b=c1n9XKbH/6lW50DxBCP1ItTvWdZUdzXu80aKJMcl/eQXsVGJao7gTCPR0ZAtsspFM yaL9NCQUNariN9hQUNmQsdAPu6ZWyof8NAbYLW8AzZNg0JhWK2AxbKztzfmMlYGemg kPa4//0YoQ3W+sVBorHsl5oUjIpR/YoVax5y1WOhPuMujNkaYEp0ihl4FNwh8Xq8hY TPQfujU6ga2JshXEJFZjFXHLd1cIJa1Busv8hzy6NBIQDKicvQgXZwcRLeDHA8g4Fn ZPZSczdrSm/EScL244f8p5EuKO0gYUhBcUXOeAM5V/RBCyDpmusstUk1+SQGLvympv tM+NxB+/6AXjw== Message-ID: Subject: Re: [PATCH v2] pinctrl: pinctrl-aspeed-g6: Fix register offset for pinconf of GPIOR-T From: Andrew Jeffery To: Billy Tsai , linus.walleij@linaro.org, joel@jms.id.au, johnny_huang@aspeedtech.com, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, BMC-SW@aspeedtech.com, Ricky_CX_Wu@wiwynn.com Date: Thu, 14 Mar 2024 09:23:19 +1030 In-Reply-To: <20240313092809.2596644-1-billy_tsai@aspeedtech.com> References: <20240313092809.2596644-1-billy_tsai@aspeedtech.com> User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240313_155334_678734_46E3BAEA X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2024-03-13 at 17:28 +0800, Billy Tsai wrote: > The register offset to disable the internal pull-down of GPIOR~T is 0x630 > instead of 0x620, as specified in the Ast2600 datasheet v15 > The datasheet can download from the official Aspeed website. ... if you're a customer with an account enabled to access it :) > > Fixes: 15711ba6ff19 ("pinctrl: aspeed-g6: Add AST2600 pinconf support") > Signed-off-by: Billy Tsai Reviewed-by: Andrew Jeffery Not sure what the history is exactly. Could have been a typo or a change in the SCU register layout given it was likely written against A0 (A3 is mass-production). Andrew > --- > drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c | 34 +++++++++++----------- > 1 file changed, 17 insertions(+), 17 deletions(-) > > diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c > index d376fa7114d1..029efe16f8cc 100644 > --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c > +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c > @@ -43,7 +43,7 @@ > #define SCU614 0x614 /* Disable GPIO Internal Pull-Down #1 */ > #define SCU618 0x618 /* Disable GPIO Internal Pull-Down #2 */ > #define SCU61C 0x61c /* Disable GPIO Internal Pull-Down #3 */ > -#define SCU620 0x620 /* Disable GPIO Internal Pull-Down #4 */ > +#define SCU630 0x630 /* Disable GPIO Internal Pull-Down #4 */ > #define SCU634 0x634 /* Disable GPIO Internal Pull-Down #5 */ > #define SCU638 0x638 /* Disable GPIO Internal Pull-Down #6 */ > #define SCU690 0x690 /* Multi-function Pin Control #24 */ > @@ -2495,38 +2495,38 @@ static struct aspeed_pin_config aspeed_g6_configs[] = { > ASPEED_PULL_DOWN_PINCONF(D14, SCU61C, 0), > > /* GPIOS7 */ > - ASPEED_PULL_DOWN_PINCONF(T24, SCU620, 23), > + ASPEED_PULL_DOWN_PINCONF(T24, SCU630, 23), > /* GPIOS6 */ > - ASPEED_PULL_DOWN_PINCONF(P23, SCU620, 22), > + ASPEED_PULL_DOWN_PINCONF(P23, SCU630, 22), > /* GPIOS5 */ > - ASPEED_PULL_DOWN_PINCONF(P24, SCU620, 21), > + ASPEED_PULL_DOWN_PINCONF(P24, SCU630, 21), > /* GPIOS4 */ > - ASPEED_PULL_DOWN_PINCONF(R26, SCU620, 20), > + ASPEED_PULL_DOWN_PINCONF(R26, SCU630, 20), > /* GPIOS3*/ > - ASPEED_PULL_DOWN_PINCONF(R24, SCU620, 19), > + ASPEED_PULL_DOWN_PINCONF(R24, SCU630, 19), > /* GPIOS2 */ > - ASPEED_PULL_DOWN_PINCONF(T26, SCU620, 18), > + ASPEED_PULL_DOWN_PINCONF(T26, SCU630, 18), > /* GPIOS1 */ > - ASPEED_PULL_DOWN_PINCONF(T25, SCU620, 17), > + ASPEED_PULL_DOWN_PINCONF(T25, SCU630, 17), > /* GPIOS0 */ > - ASPEED_PULL_DOWN_PINCONF(R23, SCU620, 16), > + ASPEED_PULL_DOWN_PINCONF(R23, SCU630, 16), > > /* GPIOR7 */ > - ASPEED_PULL_DOWN_PINCONF(U26, SCU620, 15), > + ASPEED_PULL_DOWN_PINCONF(U26, SCU630, 15), > /* GPIOR6 */ > - ASPEED_PULL_DOWN_PINCONF(W26, SCU620, 14), > + ASPEED_PULL_DOWN_PINCONF(W26, SCU630, 14), > /* GPIOR5 */ > - ASPEED_PULL_DOWN_PINCONF(T23, SCU620, 13), > + ASPEED_PULL_DOWN_PINCONF(T23, SCU630, 13), > /* GPIOR4 */ > - ASPEED_PULL_DOWN_PINCONF(U25, SCU620, 12), > + ASPEED_PULL_DOWN_PINCONF(U25, SCU630, 12), > /* GPIOR3*/ > - ASPEED_PULL_DOWN_PINCONF(V26, SCU620, 11), > + ASPEED_PULL_DOWN_PINCONF(V26, SCU630, 11), > /* GPIOR2 */ > - ASPEED_PULL_DOWN_PINCONF(V24, SCU620, 10), > + ASPEED_PULL_DOWN_PINCONF(V24, SCU630, 10), > /* GPIOR1 */ > - ASPEED_PULL_DOWN_PINCONF(U24, SCU620, 9), > + ASPEED_PULL_DOWN_PINCONF(U24, SCU630, 9), > /* GPIOR0 */ > - ASPEED_PULL_DOWN_PINCONF(V25, SCU620, 8), > + ASPEED_PULL_DOWN_PINCONF(V25, SCU630, 8), > > /* GPIOX7 */ > ASPEED_PULL_DOWN_PINCONF(AB10, SCU634, 31), _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel