From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 315B7C5CFC1 for ; Mon, 17 Aug 2026 08:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Eq8SMRnl+krHyl5tGUy7vPAIIuXfNAkaAWBYuPBe/EU=; b=btV7hexszg6orTtqXguX38jqA0 43zba921AMsU0MI+vUM400Faqvyk26YCLzIa7OmTViAN+mlvUNx9gQBBKEtVhuHkSZ4SV730z+VJz pjAbwXpB5KUnLqymn+oSRoerwUIl3me2blKm0Oj113zS4+y/8bkSLnwGUqKz275h+fbjXWEvZy+8y vY3ifJFvMLfAt3MIXuhYtRuLSlLJHpZpG0cuooZKyNgQPaD+MBnOrFz8y+A1pRW/5cqeksSAzQECD N1KED8gR+Eko5pziTUivJu7jPY2nLRGMvkmQuGQXIn0eR9swg/OcufglhrqgjeZWg5d5jMy1pPkF5 24aw2B+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wvsID-00000005cFh-2bck; Mon, 17 Aug 2026 08:02:01 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wvsIA-00000005cDx-2Tvz for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2026 08:01:59 +0000 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67H7F9LC1636860 for ; Mon, 17 Aug 2026 08:01:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Eq8SMRnl+krHyl5tGUy7vPAIIuXfNAkaAWBYuPBe/EU=; b=WSA7haT7QLcAAVEt ONRKNoDofW1w8mN1KBhyv1VtIavVNsAZMGd6TJRH3nOCfCKgOgzvgeaMtyj8qscw vN7o/MPqQXOmHKRbcn/WW4nw3NJ+m0mi/2CQIzUefxe9K79ureQNZRJe0Dvw2imq Bbks4wdqt+M0oWPU2bd+HfNNz1QLxlmPeUOvThVnVCjFCNYZTtMdWz3f7UG4LJpn 1oX7x2Bv/3MXghQPecuKhF23mUOlAPpj/28IwdP7m7x2nV7xEJ/WMLSId12AqK/i sWUHbwxmPd7Dknd5ikp8Rw/cZTCULcXBI3eln8hs0CNTC5wMZVTu34IAdSu7Y2Jn Bbjbng== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g3wreg5ms-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Aug 2026 08:01:56 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5174a236220so29530261cf.3 for ; Mon, 17 Aug 2026 01:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786953716; x=1787558516; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Eq8SMRnl+krHyl5tGUy7vPAIIuXfNAkaAWBYuPBe/EU=; b=Y0vreCbuz5kWJbM4ysgdfbcfJlIYzYdgmeZTFXExSy8BnmcZ31liWY+/rcs1PXYzMm ZISMeTbDU99SVF/qLIqXj5CvmWhVUiP5WcBWnlLmsZO6sArPf705LPfdJFGTAuFRF1T+ dwHMrFvF8o4ieyo2OQl1UYbYu94eiM4sIBVjl6YE45UtEU+0eQFwipzmtc1LsmUpYfOb BlvVmNb1jjtXj/zB25+P2ZSZ/N97PBYFFiORxaorMIRBZjnkV3gqrVp4+05zGsvFW2oz wbvvODh7+pcOrlV74qQidYCUMrtfu6X53FR3G80r7Yjelq8odNyalieJ0UhyajvCQVug nyIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786953716; x=1787558516; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Eq8SMRnl+krHyl5tGUy7vPAIIuXfNAkaAWBYuPBe/EU=; b=ek+gsLDgpszEI6NGC56IIBgKnDJA8RidBrRp1roAuvu70GWe0QDp9tESv2M2Jbum53 5i/OdDhz3agOhxHLYsapQwS6W5lVSJHDq4gHtChEvi/VNe1D0bGsDvUM0VlGrdRzXsKG QZ8raFtKywocRV7BmqR3xBJHkwPIM/OPpljYFPDgT5HNPYKQzDd1WIPpEOhMZ19EK27M YRQ/liz4dAMtWsJKlvIoC9l3Ek3b+Ibgp0/PzWuEtvsN15IpaMwJRnXLScln/e1RjAfh BjjSm4jc3AfD7Sml5R+Ac+UW3HJ+13iGuv1LgbFu1FtApwvEJwnDtVudzufJIPqxIIiC 1+oA== X-Forwarded-Encrypted: i=1; AHgh+RqCqCTiD5Cusknd5gQgom2rddTQpeYk9kRJNoLB9+htXUf4qxTTJQCfJZ7eQAtm/03Ts2awXdmwPIVUzgVv84+8@lists.infradead.org X-Gm-Message-State: AOJu0YylBUwAdSna6ORlu1Au/RP2cwpTAh291qqF3v+vwOg02luYlhba k0PCkANFnI0e/3CbJQj5yiEZyIffToXsxsQMrSnTSXOuj8ouUb9zyMtDsJbC3DmzD8VUVpEZTRI eMHjmS/ZtUX1T3D/PJ/NfXpCQDZEtOOEROOXlwx9Z5bN+RXNpiNszfL+dTai75TqzZM5nWl/Igu aeZA== X-Gm-Gg: AR+sD10nN1h6l1uD+vaZgsRl6o39pZbjgso74VannjMMT1VMC3U2urNe1e0tVxkY7+A Zp7t5Sz3ob9fckp8RDVVhO3N4sWqbgSRNLwCrqE020UMnVFRktKY05lhF8Bn7pX0284UMY9UBFU 5b/o89wAwO38a88Q6U9+ZAHiZQoDbSb5DX5ZwJH6O6/drm5AfDKhMpGnAnT0gGe3p/wYrMJeswA yZEn7arJUH19bRVLbbTKEnYscrhH7OKiYdusNIq/3JVdB1ZeYBvbYbf3zfPzzTspC22QNxWS+xa zkbkaG+TPUkrjVZQoLZLNceeIBUvqpBDFDR0b46y2YEnyn12F+qWeXicFrbUamClAgZ8gbZunPh AfOYpr6kCqoDADSk97pB42/WHzgahuZ3pXXMmeu3Z3FWK7LZlxnKVU5ZFkz4KOuFFJw== X-Received: by 2002:ac8:6104:0:b0:51c:92a0:b2cb with SMTP id d75a77b69052e-52d854ce987mr241475991cf.26.1786953716274; Mon, 17 Aug 2026 01:01:56 -0700 (PDT) X-Received: by 2002:ac8:6104:0:b0:51c:92a0:b2cb with SMTP id d75a77b69052e-52d854ce987mr241474961cf.26.1786953715521; Mon, 17 Aug 2026 01:01:55 -0700 (PDT) Received: from [10.111.162.109] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52db612c2bfsm8319271cf.11.2026.08.17.01.01.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2026 01:01:55 -0700 (PDT) Message-ID: Date: Mon, 17 Aug 2026 16:01:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] drm/msm/dp: suppress bridge hotplug events during MST operation To: Dmitry Baryshkov Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Tomi Valkeinen , Bjorn Andersson , Konrad Dybcio , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org References: <20260629-msm-dp-msttypec-v1-0-646a10256233@oss.qualcomm.com> <20260629-msm-dp-msttypec-v1-3-646a10256233@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=FqI1OWrq c=1 sm=1 tr=0 ts=6a82bff4 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=4e0XemQSoReXIs4U_p4A:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: E5vAFPfY3jw2KDiHBW9UjFuGbX_sHRjq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE3MDA1OSBTYWx0ZWRfX9VIx9SbW8r/m S02JaFbP3efK0jDpz0cLOaEevnrkzkSbxWL4GiA+XNocGBwRktSV/cpEn4YN0lFgG5sMBBbdsBb 2zYoBxelDfNzrAvXsIlECvIdgmnDtzSvN5g7HaiYKyk8IEbsShEwg/6m0ZxZnmyvmfUs72HkOQf csLX7/Ljj1oxrIg+shlQhKdswzsrIO+Im9CRMbe+rdvqH2wcD8VMp9sllyihTwzEe9uoMq+Et2+ op2BzlLVDXlMRJgsbgNiNTrO4yD+FtW7ZtnYSw5pawGA8+nqiC3Vip0y9yZR8RmMaOEHTVWVmDc glV9CZJ9GOqMFlCyAHfgh8P9nHi8+39GIvEAdPxNKNdfGWvN+0PXyN1C0EMN2oZ4xf53zNwtIiH RrTK/tLhgBWZ1MIRrk2o6dwyGvnrkZfV7VgLuEhBkF/K9ilmVGXxzjUQJYATwvH6QAlRbA1iRCd cfCNVFpaUXGBxvWoudw== X-Proofpoint-GUID: E5vAFPfY3jw2KDiHBW9UjFuGbX_sHRjq X-Proofpoint-Spam-Info: AW1haW4tMjYwODE3MDA1OSBTYWx0ZWRfXxU/pRY1jka6w /YlSvs64qhbijESjvdOZHDZiB6t9ryQwqwW8hT+/I5wF+SYm2B/COpMR4IbsaQdX7X0gLKsQi+B PPl3pmb6vX5A+WGlTk4kt4hdb2Ixt84= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_06,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 adultscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608170059 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260817_010158_739698_EC3B6BF3 X-CRM114-Status: GOOD ( 27.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/12/2026 6:44 PM, Dmitry Baryshkov wrote: > On Mon, Jun 29, 2026 at 10:48:05PM +0800, Yongxing Mou wrote: >> The DP MST framework already generates the required hotplug events for >> MST topology changes. >> >> Suppress connector hotplug event generation from the bridge connector >> path while MST is active, and continue propagating HPD notifications to >> the DP driver. >> >> Signed-off-by: Yongxing Mou >> --- >> drivers/gpu/drm/display/drm_bridge_connector.c | 6 ++++-- >> drivers/gpu/drm/msm/dp/dp_display.c | 9 ++++++++- > > No, it can't go as this. The drm_bridge_connector part should have been > a part of the first patch. > Got it. >> 2 files changed, 12 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/display/drm_bridge_connector.c b/drivers/gpu/drm/display/drm_bridge_connector.c >> index 7334d6677604..82ed0dc450ab 100644 >> --- a/drivers/gpu/drm/display/drm_bridge_connector.c >> +++ b/drivers/gpu/drm/display/drm_bridge_connector.c >> @@ -162,6 +162,7 @@ static void drm_bridge_connector_handle_hpd(struct drm_bridge_connector *drm_bri >> { >> struct drm_connector *connector = &drm_bridge_connector->base; >> struct drm_device *dev = connector->dev; >> + bool send_hotplug = true; >> >> /* >> * IRQ-only notification: extra_status carries the event but >> @@ -179,9 +180,10 @@ static void drm_bridge_connector_handle_hpd(struct drm_bridge_connector *drm_bri >> connector->status = status; >> mutex_unlock(&dev->mode_config.mutex); >> >> - drm_bridge_connector_hpd_notify(connector, status, extra_status, NULL); >> + drm_bridge_connector_hpd_notify(connector, status, extra_status, &send_hotplug); >> >> - drm_kms_helper_connector_hotplug_event(connector); >> + if (send_hotplug) >> + drm_kms_helper_connector_hotplug_event(connector); > > But now I can also see that the idea seems to be incorrect. You are > preventing the kernel from sending the events, but it doesn't really > matter. If connection status oscillates, then other components might > notice it even without the event being sent. > Here our original intent behind suppressing the hotplug was that, under MST, hotplugs should be sent independently by the MST framework, rather than being emitted along the IRQ handling path. Following the extra_status approach you introduced, would it make sense to let the bridge_connector layer distinguish between long pulses (HPD) and short pulses (IRQ_HPD) -- a short pulse would not update connector->status and would not emit a hotplug, only forwarding the event to the bridge driver. Does this direction sound reasonable to you? > >> } >> >> static void drm_bridge_connector_hpd_cb(void *cb_data, >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c >> index 6835c68fe510..bc93b566fbca 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.c >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c >> @@ -1790,10 +1790,17 @@ void msm_dp_bridge_hpd_notify(struct drm_bridge *bridge, >> msm_dp_hpd_plug_handle(dp); >> } else { >> msm_dp_hpd_plug_handle(dp); >> + /* mst_active is set in plug_handle; suppress SST hotplug */ >> + if (send_hotplug && msm_dp_display->mst_active) >> + *send_hotplug = false; >> } >> } else { >> - if (hpd_link_status == ISR_DISCONNECTED) >> + if (!msm_dp_display->mst_active) { >> msm_dp_hpd_unplug_handle(dp); >> + } else if (send_hotplug) { >> + msm_dp_hpd_unplug_handle(dp); >> + *send_hotplug = false; > > Why? Disconnected events definitely should be reported further. > In MST case, MST DRM framework will send the discconnected hotplug by msm_dp_mst_display_set_mgr_state(&dp->msm_dp_display, false);. >> + } >> } >> >> pm_runtime_put_sync(&msm_dp_display->pdev->dev); >> >> -- >> 2.43.0 >> >