From mboxrd@z Thu Jan 1 00:00:00 1970 From: jarkko.nikula@linux.intel.com (Jarkko Nikula) Date: Thu, 13 Sep 2018 16:50:30 +0300 Subject: [PATCH v2] i2c: designware: select gpio/default pin when prepare/unprepare recovery In-Reply-To: <20180913162132.17c9c2b3@xhacker.debian> References: <20180913162132.17c9c2b3@xhacker.debian> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/13/2018 11:21 AM, Jisheng Zhang wrote: > On some platforms, the sda/scl pins are muxed with gpio functions, so > they could be used for recovery. Select the gpio/default pin function > when prepare/unprepare recovery. > > Signed-off-by: Jisheng Zhang > --- > > since v1: > - use IS_ERR_OR_NULL > > drivers/i2c/busses/i2c-designware-core.h | 3 +++ > drivers/i2c/busses/i2c-designware-master.c | 22 ++++++++++++++++++++++ > 2 files changed, 25 insertions(+) > ... > + pinctrl = devm_pinctrl_get(dev->dev); > + if (PTR_ERR(pinctrl) == -EPROBE_DEFER) > + return -EPROBE_DEFER; > + if (!IS_ERR_OR_NULL(pinctrl)) { > + dev->pinctrl = pinctrl; > + s = pinctrl_lookup_state(pinctrl, PINCTRL_STATE_DEFAULT); > + if (!IS_ERR_OR_NULL(s)) > + dev->pins_default = s; > + s = pinctrl_lookup_state(pinctrl, "gpio"); > + if (!IS_ERR_OR_NULL(s)) > + dev->pins_gpio = s; > + } > + Should these be documented in Documentation/devicetree/bindings/i2c/i2c-designware.txt? -- Jarkko