From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3CEBC38A2D for ; Tue, 25 Oct 2022 10:24:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1Vi/bX6EP2dzpilmUfcCZsa18dc66ScjDV1NfV5NbpQ=; b=A8KNIpvXpG3y11 dVOwv3R5StUpVCRkj3Yg6aq4/NAnF6xKjKwpHPFRYCIVRYta784cZfOyuxd8mjwBLqwDq2qM5VBB9 fzgcdZ+D7OSLAxVCmBNk7DcO9THGYKgDWnYxoVSuoSfToD9kL+Omv4ZbbpuwpL1BwTleNRbARoAqz BRR1OBJH612xyD4MQ/4JK65mKbWbxjoTrc5LFuM/qzZMEseOfqL/9JKTgM61cJdt4m+KBDoN2V+au blhGBiYvFrYv82ouDwJmkMzv79XS9w0Zd7ImrGalgGpQ7Qkj2Ez/QY+Oa0gF1PEWpCFNHeiQDRxWh fwNWKBiL8xMxtn+4A+Vw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onH5M-004lBr-BU; Tue, 25 Oct 2022 10:23:04 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onH5J-004l9g-3V for linux-arm-kernel@lists.infradead.org; Tue, 25 Oct 2022 10:23:02 +0000 Received: by mail-lf1-x136.google.com with SMTP id b2so21096373lfp.6 for ; Tue, 25 Oct 2022 03:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QFiuwIbv+bAoeutli0BiRLmAbI6CnnPeevj6u0N7M/w=; b=BGuPe5QcSnGzzHh+DjA2iAbyCVJqZVLdSh9ICX86csmBECrYkGIB6qFrUkobuh5dwW hMBosiwXdHYV9HHYzOjGqHiXdCHhodIZBtoORgtvGYpha7biEZQMO8OdxkKt5qcanQ+Z DfIsrJSNh7lqAn3cmcwL/G0AaMBi5FpyhjWAk0RufhFieiKKlbkJ84XhiCT3MYkH2SBd gKZxyNmfBkXYXQpjM+/w1pitxSxH5TYvlw3I8koYdomddhkGAV0/6g2BM6K6ZUD3Ikhz nttLEwOKHPz1seytHqgrvre2Hdds99Gi2M+FT98nagHKD07XgynFfWEIBYOJLL/s9A7p e5OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QFiuwIbv+bAoeutli0BiRLmAbI6CnnPeevj6u0N7M/w=; b=m3L369B7nuWEnc7J8cDrj7uN3VoNXqf12A9+Kg5lPMudoBmnqexhkwOHmdzCRXMMhs SnO6aUXe5lw86Fpc5KaCBaP10saiFnT0DG9F5ZDSQa+xe2FPj/Ek57CV+pqV2251YKOw Bbq2fKWVdefSwL122Zz9OsASCr+xnKwxpax9GNiPCDJR8JELNFTZi9PnpvB+Pcvc3/gh +rlBcP2CB9oKoXPM3EHy5trAYEvDv5OQKT0AwoXd5zaAs359Dp+CfV19UhpXjHrO3rD2 D4/QOssNbLeX87FIaXB/h+JShYvh7iK1gCd0G2sEewO9clzDf23RcM/dTFb2lrEBcw2o kNow== X-Gm-Message-State: ACrzQf1I+kFbpzz//TVpDZf05ccZOXOkn4SVKtIWyfiKViQJsvF9hEve x6VbJ2gjj35t5INrWRlmdR2c+w== X-Google-Smtp-Source: AMsMyM6Xv6Vk8YcvnuPbdV0vpeA7Q85xyPpOdCMt8HvyuufTj+fbTQYdSkFkiN0gdEyTb9qNUrj6bw== X-Received: by 2002:a05:6512:b0f:b0:4ac:fa40:63ff with SMTP id w15-20020a0565120b0f00b004acfa4063ffmr2141859lfu.336.1666693377412; Tue, 25 Oct 2022 03:22:57 -0700 (PDT) Received: from [10.27.10.248] ([195.165.23.90]) by smtp.gmail.com with ESMTPSA id n22-20020a2e8796000000b002770a7e320esm424486lji.81.2022.10.25.03.22.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Oct 2022 03:22:56 -0700 (PDT) Message-ID: Date: Tue, 25 Oct 2022 13:22:56 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH] firmware/psci: demote suspend-mode warning to debug level Content-Language: en-GB To: Johan Hovold , Mark Rutland , Lorenzo Pieralisi Cc: Ulf Hansson , Sudeep Holla , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221024143417.11463-1-johan+linaro@kernel.org> From: Dmitry Baryshkov In-Reply-To: <20221024143417.11463-1-johan+linaro@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221025_032301_171707_7DED0BC0 X-CRM114-Status: GOOD ( 20.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/10/2022 17:34, Johan Hovold wrote: > On some Qualcomm platform, like SC8280XP, the attempt to set PC mode > during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb > ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this > is now logged at warning level: > > psci: failed to set PC mode: -3 > > As there is nothing users can do about the firmware behaving this way, > demote the warning to debug level. > > Signed-off-by: Johan Hovold Acked-by: Dmitry Baryshkov > --- > > Note that a separate change to the cpuidle driver will start logging the > mode actually used: > > https://lore.kernel.org/all/20221020115513.93809-1-ulf.hansson@linaro.org/ > > Johan > > > drivers/firmware/psci/psci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index e7bcfca4159f..462f37fa6a86 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -165,7 +165,7 @@ int psci_set_osi_mode(bool enable) > > err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, suspend_mode, 0, 0); > if (err < 0) > - pr_warn("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err); > + pr_debug("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err); > return psci_to_linux_errno(err); > } > -- With best wishes Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel