From: sf84@laposte.net (Sebastian Frias)
To: linux-arm-kernel@lists.infradead.org
Subject: Adding a .platform_init callback to sdhci_arasan_ops
Date: Fri, 25 Nov 2016 16:24:02 +0100 [thread overview]
Message-ID: <d50dcd8a-2489-4e82-1dc7-13e93e38d5ff@laposte.net> (raw)
Hi,
When using the Arasan SDHCI HW IP, there is a set of parameters called
"Hardware initialized registers"
(Table 7, Section "Pin Signals", page 56 of Arasan "SD3.0/SDIO3.0/eMMC4.4
AHB Host Controller", revision 6.0 document)
In some platforms those signals are connected to registers that need to
be programmed at some point for proper driver/HW initialisation.
I found that the 'struct sdhci_ops' contains a '.platform_init' callback
that is called from within 'sdhci_pltfm_init', and that seems a good
candidate for a place to program those registers (*).
Do you agree?
Best regards,
Sebastian
(*): This has been prototyped on 4.7 as working properly.
However, upstream commit:
commit 3ea4666e8d429223fbb39c1dccee7599ef7657d5
Author: Douglas Anderson <dianders@chromium.org>
Date: Mon Jun 20 10:56:47 2016 -0700
mmc: sdhci-of-arasan: Properly set corecfg_baseclkfreq on rk3399
...
could affect this solution because of the way the 'sdhci_arasan_of_match'
struct is used after that commit.
next reply other threads:[~2016-11-25 15:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 15:24 Sebastian Frias [this message]
2016-11-28 7:32 ` Adding a .platform_init callback to sdhci_arasan_ops Michal Simek
2016-11-28 10:30 ` Adrian Hunter
2016-11-28 11:20 ` Sebastian Frias
2016-11-28 11:44 ` Adrian Hunter
2016-11-28 13:28 ` Sebastian Frias
2016-11-28 14:39 ` Sebastian Frias
2016-11-28 17:46 ` Doug Anderson
2016-11-28 19:32 ` Mason
2016-11-28 20:32 ` Doug Anderson
2016-12-05 12:28 ` Sebastian Frias
2016-12-05 16:13 ` Doug Anderson
2016-11-28 18:02 ` Doug Anderson
2016-12-05 12:29 ` Sebastian Frias
2016-12-05 16:30 ` Doug Anderson
2016-12-06 13:42 ` Sebastian Frias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d50dcd8a-2489-4e82-1dc7-13e93e38d5ff@laposte.net \
--to=sf84@laposte.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox