From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 258B0C77B61 for ; Thu, 13 Apr 2023 18:41:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mePzeSSTj8vUBTgPL96lrVczea4tUGUbp+caGMKrQQ8=; b=cLI7CelUzaUYFs Lf2E0l7dB4wVLrnKQgOmwuJFHpXzZ9OJBoxyjKsgzSPBkaSjn5rqpR3v0BC+n9of78ZaPtTlv7tpt 3lQZHtr0gWXyZlrFHEEp8JDp9R1kr1/dWyl1Y4GBoXvvLxDPAo9jak9UkicV1pw/g8v5TPnegN1pD rbkgMIhIoJM/fzM2Nbr+Pce37Y/Wj1C2HhLsmxkpS0UAZzNMCT9zol71K8BY4IwASt7MYWatqCXRq T/62NaAfA9pV1ncta9bQavGwzrpsScX6vDvOpT37W3y6KvbblIf+msFRbg3/g6bHJ9Ewtm9oo4fRM U+/I/++AyBW1IJzkbp4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pn1rn-006vUd-1Z; Thu, 13 Apr 2023 18:40:19 +0000 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pn1rk-006vTd-2O; Thu, 13 Apr 2023 18:40:18 +0000 Received: by mail-qt1-x82a.google.com with SMTP id ej15so5052099qtb.7; Thu, 13 Apr 2023 11:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681411214; x=1684003214; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rQtEpZle81hoaqTdpulwOdpw8KqXnAar/PVE+B9TICc=; b=P474q5oP2LI987/DecEQ3/p0SMtL1fQBQYFgk1hLlcvQfcEkyPCwiuFQgKQJlJ8cv0 5RSQfJi4CHGciKswyoG/HMwMgJ1SnD9UG0/O/PZXmSvBnGFVniVUlFQhDN0mOpjLn3Xq TFNkGhPUpB1JKX9bEzyx81ERg0NVLJGJ0q9LwENMjpqs0SB8Y+M5T+ZayRasX+2+62Bx EKI7b/XXyjUDkQ2SazxkmzrgNIIePmygmmSiOMVk23108Qfzz8Jy6DtjDFwgvhA4DVGp mOUvp5WnEzyh0hyRfkCSsVTEtQ3W46F3I8Nj3xReqXRyp/KCLnImi658/TiORcHtHbmL gQDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681411214; x=1684003214; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rQtEpZle81hoaqTdpulwOdpw8KqXnAar/PVE+B9TICc=; b=GkHW+Xre62qtUBhspyV4u+6ZE2zg22VF6uYhkDxijhOx1dhE6x5+vkvsgOoM8/9QJ5 j1DkJZcVTaXv9kxqEcHJLmSEhsHknBWh0h/UhvYx2Mo+jFSs3av31cQb5ks6dXQE8hw9 SzcL1aziuilEJSdEBIzQL1xUQafcpRRrTRIMywlhiV2BisDS5wojcohD42TtdJlVkOXz RQhYAlA0jx0FIrjw5vCHIeOjJ9EdN04ZfwrXFdBaxoH0SKNAsIqnZqcMlMtp0URodfTu y21NQmVj7cjsFYq/HeQqx29OYpDjSquReBtRdbVn44wBEhAWmbDzy/QX7HbMmtguchpf 1GcQ== X-Gm-Message-State: AAQBX9cyoZpXXkDK5f9+TlS9idzQXtxS3BqgfjJFIEcda6IDtUPM3peS nAHc2UJM+FlLqkTkILxq6Oo= X-Google-Smtp-Source: AKy350YwqLvGxuXkbQqYKS2m5/KfU0SKlQOgBQRBuWiZ05fsd0xL8BIuH7TjtWiwcrVwrdcZm5ozVw== X-Received: by 2002:ac8:5b87:0:b0:3ea:1206:b812 with SMTP id a7-20020ac85b87000000b003ea1206b812mr3703163qta.38.1681411214235; Thu, 13 Apr 2023 11:40:14 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id h18-20020a05620a285200b007425ef4cbc2sm654336qkp.100.2023.04.13.11.40.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Apr 2023 11:40:13 -0700 (PDT) Message-ID: Date: Thu, 13 Apr 2023 11:40:11 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 0/3] PCI: brcmstb: CLKREQ# accomodations of downstream device Content-Language: en-US To: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Rob Herring References: <20230411165919.23955-1-jim2101024@gmail.com> From: Florian Fainelli In-Reply-To: <20230411165919.23955-1-jim2101024@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230413_114016_798052_54A07727 X-CRM114-Status: GOOD ( 14.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/11/23 09:59, Jim Quinlan wrote: > v2 -- Changed binding property 'brcm,completion-timeout-msec' to > 'brcm,completion-timeout-us'. (StefanW for standard suffix). > -- Warn when clamping timeout value, and include clamped > region in message. Also add min and max in YAML. (StefanW) > -- Qualify description of "brcm,completion-timeout-us" so that > it refers to PCIe transactions. (StefanW) > -- Remvove mention of Linux specifics in binding description. (StefanW) > -- s/clkreq#/CLKREQ#/g (Bjorn) > -- Refactor completion-timeout-us code to compare max and min to > value given by the property (as opposed to the computed value). > > v1 -- The current driver assumes the downstream devices can > provide CLKREQ# for ASPM. These commits accomodate devices > w/ or w/o clkreq# and also handle L1SS-capable devices. > > -- The Raspian Linux folks have already been using a PCIe RC > property "brcm,enable-l1ss". These commits use the same > property, in a backward-compatible manner, and the implementaion > adds more detail and also automatically identifies devices w/o > a clkreq# signal, i.e. most devices plugged into an RPi CM4 > IO board. > > Jim Quinlan (3): > PCI: brcmstb: CLKREQ# accomodations of downstream device > PCI: brcmstb: Set PCIe transaction completion timeout > blah blah Tested-by: Florian Fainelli On a 7216 system test with: 01:00.0 Network controller: Intel Corporation Wireless 7260 (rev 73) and on the CM4 I/O board with: 01:00.0 Network controller: Intel Corporation Wireless 7260 (rev 73) 01:00.0 Ethernet controller: Intel Corporation 82574L Gigabit Network Connection 01:00.0 Network controller: Broadcom Inc. and subsidiaries BCM43224 802.11a/b/g/n (rev 01) 01:00.0 SATA controller: Marvell Technology Group Ltd. 88SE9125 PCIe SATA 6.0 Gb/s controller (rev 11) (prog-if 01 [AHCI 1.0]) 01:00.0 Ethernet controller: Broadcom Inc. and subsidiaries NetXtreme BCM5751 Gigabit Ethernet PCI Express (rev 21) 01:00.0 PCI bridge: PLX Technology, Inc. PEX8112 x1 Lane PCI Express-to-PCI Bridge (rev aa) 02:00.0 Multiport serial controller: Pepperl+Fuchs RocketPort EXPRESS 8-port w/Octa Cable 01:00.0 Ethernet controller: Qualcomm Atheros AR5008 Wireless Network Adapter (rev 01) 01:00.0 Network controller: Broadcom Inc. and subsidiaries BCM4311 802.11a/b/g (rev 01) 01:00.0 Network controller: Broadcom Inc. and subsidiaries BCM4322 802.11a/b/g/n Wireless LAN Controller (rev 01) 01:00.0 Network controller: Broadcom Inc. and subsidiaries BCM43602 802.11ac Wireless LAN SoC (rev 01) and finally with a 4 port switch: -[0000:00]---00.0-[01-07]----00.0-[02-07]--+-01.0-[03]----00.0 Intel Corporation 82574L Gigabit Network Connection +-03.0-[04-05]----00.0-[05]----00.0 Pepperl+Fuchs RocketPort EXPRESS 8-port w/Octa Cable +-05.0-[06]----00.0 Broadcom Inc. and subsidiaries NetXtreme BCM5751 Gigabit Ethernet PCI Express \-07.0-[07]----00.0 Intel Corporation 82574L Gigabit Network Connection And than I ran out of devices that I could plug, the others were x4, x8 or x16. Most (all?) would previously fail, so definitively an improvement! Thanks! -- -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel