From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69AE0C433EF for ; Fri, 22 Jul 2022 09:16:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E5gYxjyCpCW7dvNaKl/MAghNLb/2OPJsMmrtWrifpqg=; b=RpBwuAqdpzoRVA Y3m8vzYMQo6n6/W5bLsF97PXUQrwZUCJwv8BikysgA24zNN33/+5F7ilB8fB9scWdCQjbIHtOfsI5 E4LCcETqlEAhJo0LWIPxv1pSWlx8IhRlutNtA5sYq11vXVZBZBxHMQ1Oj7a1OnrNoVxafr6U0hAjI ZFB6DZpNke57v72S9jeEp7I2tlAk8VQzXYlosM0+tyxphHIfp4eAbYconyoOxHd2G/QHxp7AbeNjl 2vLNkXc53zrBnDfbbPsRCJbM9ajsjxt1ptf74rtg8VUqEHGAbEKBsaSsSsMfilvrKt2vZWQEuhctX JtMRwu495i4ooCtWlOvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEokR-001Teh-Ch; Fri, 22 Jul 2022 09:15:04 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEojE-001SPv-W0 for linux-arm-kernel@lists.infradead.org; Fri, 22 Jul 2022 09:13:51 +0000 Received: by mail-pl1-x62e.google.com with SMTP id z3so4098865plb.1 for ; Fri, 22 Jul 2022 02:13:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=OFu95XsV5rEYBt/DoXMJzDAz5PRwolc7OS134C8DnKc=; b=0fFghdJIPyc8ja/Ja4cKlCxsHImbwt+x6cqArGd1WjVLRO4xLsTp5Ca04dFVCKuBNy Ta+da7cU7Xo+M+dPdbyJDLrM5tL+bKeXEp3EcjbveyUQCvoKhmEVRi93T35xYtim1vv+ GSzumERbIJEqvSZ5EW9yMhkKCP8l/8QVrL8/DMr3lYL0Rd7KamuMNvpZ3iLlt5nFNDKL RfTayBaT+0CLhFuTN8dWH0NxsH0JbbpqgBHNgBx2p5qeUZzS4esMo94tI7Cu+0Kv6oiY Jn5cvW95wnOV/W8+XQk1skB9V70mIOsQdccwk69ISskNQCyRWGc+E/bJeEaHSwE9jTnU IeIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=OFu95XsV5rEYBt/DoXMJzDAz5PRwolc7OS134C8DnKc=; b=hJJon1ZslMLkBUf5N+e7qo5XqiURasfWdl+BaTdeRCZp8ZH3mBvPCqEzWB9/WLNDlc Ty0BdZDz+yxENFTenHFUeSMfGVjJSnr8MUgLukFKHCFG5swoGcj4Fmvf88l2ukTwvazo /qzXeqKsCFfdF1ugfgdB472pEkyCiOAawMKsFcxs+VHM9g0+pJSOeRAliwZV2pP4Mxds B6rRc5wicmQmOwe81hDQCxU/SwEV6ZOheQXPW3rkhSyfZgQ3hGrCqwLWQm83N/xektq3 drmul6PmkCGVrjX8QI34R2Bx2+fXfR+MDg6g/lUpslfjkEtSiQfr3P+tCgwltfgeoZ5P 5EmA== X-Gm-Message-State: AJIora9VgPT8W7WgYj/h2hEJsS1NhJ9CLXKa1jkmqAaxRv4IddbmnqiH W3ItROxMJvR7h+looQqxwCfwUjB74XxDUg== X-Google-Smtp-Source: AGRyM1v6F78+NCt09f2hsDWr95VGuj60HNdNaZDsiSJ72K0JCl0CYXqR5FUuwfkIkofOdUs4kEv6kw== X-Received: by 2002:a17:902:c94b:b0:16c:7289:b402 with SMTP id i11-20020a170902c94b00b0016c7289b402mr2486506pla.66.1658481224853; Fri, 22 Jul 2022 02:13:44 -0700 (PDT) Received: from [10.4.231.121] ([139.177.225.245]) by smtp.gmail.com with ESMTPSA id o12-20020a170902778c00b0016d1f474653sm2923403pll.52.2022.07.22.02.13.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 02:13:44 -0700 (PDT) Message-ID: Date: Fri, 22 Jul 2022 17:13:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0 Subject: Re: [PATCH v1 1/2] arm64: run softirqs on the per-CPU IRQ stack Content-Language: en-US To: Will Deacon Cc: arnd@arndb.de, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220708094950.41944-1-zhengqi.arch@bytedance.com> <20220708094950.41944-2-zhengqi.arch@bytedance.com> <20220722090440.GB18125@willie-the-truck> From: Qi Zheng In-Reply-To: <20220722090440.GB18125@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220722_021349_282186_A4E77597 X-CRM114-Status: GOOD ( 16.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/7/22 17:04, Will Deacon wrote: > On Fri, Jul 08, 2022 at 05:49:49PM +0800, Qi Zheng wrote: >> Currently arm64 supports per-CPU IRQ stack, but softirqs >> are still handled in the task context. >> >> Since any call to local_bh_enable() at any level in the task's >> call stack may trigger a softirq processing run, which could >> potentially cause a task stack overflow if the combined stack >> footprints exceed the stack's size, let's run these softirqs >> on the IRQ stack as well. >> >> Signed-off-by: Qi Zheng >> --- >> arch/arm64/Kconfig | 1 + >> arch/arm64/kernel/irq.c | 13 +++++++++++++ >> 2 files changed, 14 insertions(+) >> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index 4c1e1d2d2f8b..be0a9f0052ee 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -230,6 +230,7 @@ config ARM64 >> select HAVE_ARCH_USERFAULTFD_MINOR if USERFAULTFD >> select TRACE_IRQFLAGS_SUPPORT >> select TRACE_IRQFLAGS_NMI_SUPPORT >> + select HAVE_SOFTIRQ_ON_OWN_STACK >> help >> ARM 64-bit (AArch64) Linux support. >> >> diff --git a/arch/arm64/kernel/irq.c b/arch/arm64/kernel/irq.c >> index bda49430c9ea..c36ad20a52f3 100644 >> --- a/arch/arm64/kernel/irq.c >> +++ b/arch/arm64/kernel/irq.c >> @@ -22,6 +22,7 @@ >> #include >> #include >> #include >> +#include >> >> /* Only access this in an NMI enter/exit */ >> DEFINE_PER_CPU(struct nmi_ctx, nmi_contexts); >> @@ -71,6 +72,18 @@ static void init_irq_stacks(void) >> } >> #endif >> >> +#ifndef CONFIG_PREEMPT_RT >> +static void ____do_softirq(struct pt_regs *regs) >> +{ >> + __do_softirq(); >> +} >> + >> +void do_softirq_own_stack(void) >> +{ >> + call_on_irq_stack(NULL, ____do_softirq); >> +} >> +#endif > > Acked-by: Will Deacon > > Please can you repost this at -rc1 and we can queue it up for 5.21? Sure, will do. Thanks, Qi > > Thanks, > > Will -- Thanks, Qi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel