From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B632C433F5 for ; Fri, 29 Oct 2021 13:01:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB81461167 for ; Fri, 29 Oct 2021 13:01:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DB81461167 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iBL258o53OVj43GQ3mqCpGIL2cSSUuSkMDBFzzixlhM=; b=vt+MZupCETUC86Wm+N7HFfWfPP 5E3WOXXjpXMYPOuDQogDfn/8xe2ze8GVAiUwdM3WZmqxevX9whDxkYq6Gq5WAdwTuusCaWqcLeCPO 1sYYyLjkdiF/4VH/GmAKuBAVGar79/ihDk1ZxMxglfX8HDbV7olHZgI8pCQq1X7bGJMQgH8VzvvNf jz/iL4dr9iDFDNahb9iXM4SZJxQvpZHzKdhnxhaCxHdpR4A0DCaohYy11P3/LdSPYJy9NQbmtEt3E pLunjuTXbSE/U0+ZDaB8GN6iSMLV/5yA+jcLTlbVPOWZOOimHjDtkOcMFf9uZGVHYhWhvH9Kj5hAN PKlnw5gQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgRUn-00Azf6-AL; Fri, 29 Oct 2021 13:00:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgRUj-00AzeK-BE for linux-arm-kernel@lists.infradead.org; Fri, 29 Oct 2021 13:00:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 805A9ED1; Fri, 29 Oct 2021 06:00:23 -0700 (PDT) Received: from [10.57.25.71] (unknown [10.57.25.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CA00D3F73D; Fri, 29 Oct 2021 06:00:21 -0700 (PDT) Subject: Re: [PATCH v5 09/15] coresight: trbe: Add infrastructure for Errata handling To: Arnd Bergmann Cc: Will Deacon , Mathieu Poirier , Catalin Marinas , Anshuman Khandual , Mike Leach , Leo Yan , Marc Zyngier , coresight@lists.linaro.org, Linux ARM , Linux Kernel Mailing List References: <20211014223125.2605031-1-suzuki.poulose@arm.com> <20211014223125.2605031-10-suzuki.poulose@arm.com> From: Suzuki K Poulose Message-ID: Date: Fri, 29 Oct 2021 14:00:20 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211029_060029_486033_5F0F2EA8 X-CRM114-Status: GOOD ( 17.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd Thanks for the report. On 29/10/2021 11:31, Arnd Bergmann wrote: > On Fri, Oct 15, 2021 at 12:31 AM Suzuki K Poulose > wrote: >> >> +static void trbe_check_errata(struct trbe_cpudata *cpudata) >> +{ >> + int i; >> + >> + for (i = 0; i < TRBE_ERRATA_MAX; i++) { >> + int cap = trbe_errata_cpucaps[i]; >> + >> + if (WARN_ON_ONCE(cap < 0)) >> + return; >> + if (this_cpu_has_cap(cap)) >> + set_bit(i, cpudata->errata); >> + } >> +} > > this_cpu_has_cap() is private to arch/arm64 and not exported, so this causes > a build failure when used from a loadable module: > > ERROR: modpost: "this_cpu_has_cap" > [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > Should this symbol be exported or do we need a different workaround? This should be exported. I can send in a patch. Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel