Re: [PATCH] drm/exynos/fimd: fix register offset type in fimd_trigger()

[Marek Szyprowski <m.szyprowski@samsung.com>]

On 08.04.2026 08:50, Chen-Yu Tsai wrote:
> Sparse reports:
>
>     exynos_drm_fimd.c:992:39: warning: incorrect type in initializer (different address spaces)
>     exynos_drm_fimd.c:992:39:    expected void *timing_base
>     exynos_drm_fimd.c:992:39:    got void [noderef] __iomem *
>     exynos_drm_fimd.c:1005:33: warning: incorrect type in argument 1 (different address spaces)
>     exynos_drm_fimd.c:1005:33:    expected void const volatile [noderef] __iomem *addr
>     exynos_drm_fimd.c:1005:33:    got void *
>     exynos_drm_fimd.c:1007:33: warning: incorrect type in argument 2 (different address spaces)
>     exynos_drm_fimd.c:1007:33:    expected void volatile [noderef] __iomem *addr
>     exynos_drm_fimd.c:1007:33:    got void *
>
> Add "__iomem" to *timing_base to fix its type.
>
> Fixes: 3854fab24e89 ("drm/exynos: fimd: support LCD I80 interface")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>

Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>


> ---
> random warning I found while checking for the size_t warning.
> ---
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index b6abdc4f2b0a..695d3515d421 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -989,7 +989,7 @@ static void fimd_trigger(struct device *dev)
>  {
>  	struct fimd_context *ctx = dev_get_drvdata(dev);
>  	const struct fimd_driver_data *driver_data = ctx->driver_data;
> -	void *timing_base = ctx->regs + driver_data->timing_base;
> +	void __iomem *timing_base = ctx->regs + driver_data->timing_base;
>  	u32 reg;
>  
>  	 /*

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland