From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16D45C433F5 for ; Mon, 18 Apr 2022 12:35:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZFC1lod+as2yUAOz9v4CNMVa9Rd9S7dOLz9pO4d3Mf8=; b=jXL5sl+7kFS0oW OYeQvciSl5f796qF8zG/9Ew1aXqTOe5GGS7w8SJLpIJY/qTyq7TXDnndPAedmxe56C8kZ/GcACg0M 4fAkfTkeumwDsI02BdhuDa6YcvfnAMwAyz3yqrmlsHWuv/ZTvlZdkhlIaX58MvAZLUg7YqUxjjn67 pkAMqDqbitRi+hCSgsstIjOv6S4AgXY8nKEn0fakIy2QX0QjydoAmCZYkCuTQaRFNRVsd+umHwPTe sZ2/nnOStAnTBhFgX1JDXgPjtN6Hu1Aim2ZOWR11jSlvw3YrugfoaEtt+eHr8NaSSqSw6W1zfimm4 uQVQkvRx4dd9KXvUD2iA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngQak-00GnCo-R4; Mon, 18 Apr 2022 12:34:54 +0000 Received: from relay4.hostedemail.com ([64.99.140.36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngQaA-00Gmv6-Ag for linux-arm-kernel@lists.infradead.org; Mon, 18 Apr 2022 12:34:20 +0000 Received: from omf09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C98A621F48; Mon, 18 Apr 2022 12:34:10 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA id BABB22002B; Mon, 18 Apr 2022 12:34:03 +0000 (UTC) Message-ID: Subject: Re: [PATCH v4 2/5] fpga: fix for coding style issues From: Joe Perches To: Nava kishore Manne , "mdf@kernel.org" , "hao.wu@intel.com" , "yilun.xu@intel.com" , "trix@redhat.com" , Michal Simek , "linux-fpga@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , git Date: Mon, 18 Apr 2022 05:34:02 -0700 In-Reply-To: References: <20220416133719.3382895-1-nava.manne@xilinx.com> <20220416133719.3382895-3-nava.manne@xilinx.com> User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 X-Stat-Signature: epzo5oz5kfdybfgi53hfa7jj89tnxo9k X-Rspamd-Server: rspamout06 X-Rspamd-Queue-Id: BABB22002B X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+NFs9m+djNp+pOCjBVEkayfxYTc+TurQw= X-HE-Tag: 1650285243-748919 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220418_053418_459402_774C451C X-CRM114-Status: GOOD ( 18.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2022-04-18 at 09:54 +0000, Nava kishore Manne wrote: > Hi Joe, > > Please find my response inline. > > > -----Original Message----- > > From: Joe Perches > > Sent: Saturday, April 16, 2022 10:29 PM > > On Sat, 2022-04-16 at 19:07 +0530, Nava kishore Manne wrote: > > > fixes the below checks reported by checkpatch.pl Lines should not end > > > with a '(' > > > Alignment should match open parenthesis > > > > in fpga-mgr: > > Another possibillty would be to change the function arguments > > > > and > > > > in fpga-region: > > Ideally keep the include declaration and definition styles synced > > These changes are targeted to fix the checks reported by checkpatch.pl without touching the actual functionality. Hello. I am the checkpatch maintainer. The goal of the checkpatch script is simply to mark things that generally don't conform to the typical kernel coding style not to mandate that all of the messages it emits is dicta. checkpatch is a stupid little script. It has no taste. Please take what I wrote with a little consideration rather than follow the advise of a brainless script. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel