From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 314D6C43334 for ; Wed, 22 Jun 2022 08:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mi3N3IF+G83zrWhu2YQhTnbx4ChXO3sMvZN8205QRF0=; b=uKwX3JN9foulUA TQf+EvluaIYwkvMwbS33IiO+ydNOsCNqF2JNVwWJYKmbTlyMderzhrtE5pOjyXbOOl2JnkYWgao9+ 9qQi3iEekeh7SJJ1QMLaq+PC4piLhl+V5GLguroe87gJudvPK6rCoxYLlnqGJpKQOdpNktSp3vHho G8X8l0p9M0SzeZdxP5O7R5NmVBOj4cIAFFmyrmfLD3NSoS7S2Yb1/0iC5lI4pN9eDI8C3X74iNFS5 TSYBBxAiFRo/hIsuntlSHpJzMi6FY154vVx16uSBhs6QcnITzaXOBCRxRyKs2UOJJashWBrsM1j+2 7cA+m1vnpGZoNJ2/Bj6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3w5Q-009MJI-Vb; Wed, 22 Jun 2022 08:51:45 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3w5O-009MHb-BX for linux-arm-kernel@lists.infradead.org; Wed, 22 Jun 2022 08:51:44 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 96513CE1D0A; Wed, 22 Jun 2022 08:51:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64C17C34114; Wed, 22 Jun 2022 08:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655887898; bh=DDevuX+quOyUYyRZh8cHS4Ea+lJpMHBEf4QpVKuKGqI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=R9sT8hVrqKIU4PFILSF2ofL07zhVyORlhL80c+LSwVKihfdPmrXTuqBscMbHp7yFZ R9B+m7X00LnwS3XQzcsc9sXASZrqSrBiEdE+dcB87wfseQ9hdwJP6hgME7z7sTyrsN yRlhkKRJ0qEPNgSml3cow7w9QknJo5SskS2T04pz3dXzH6o0I4s9sYGXpAWsrc0UeJ 1qpl9SY8ILfsviioo7AqvBBIE6OgcxUTrTWt0uddAIldVsZ6H5fV7NaWnz1oFzMvyv PIfOwC5jiS7aF1Q9H225+g5OLuti5tbufq/yG4sLVBCYnVRYZHW5QZLsodFsvIOoPj vFenBxegajbGQ== Message-ID: Date: Wed, 22 Jun 2022 10:51:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] arm/mach: Hold reference returned by of_find_xxx APIs Content-Language: en-US To: Liang He , andre.przywara@arm.com, thierry.reding@gmail.com, jonathanh@nvidia.com, tony@atomide.com Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org References: <20220621091937.4082422-1-windhl@126.com> From: Krzysztof Kozlowski In-Reply-To: <20220621091937.4082422-1-windhl@126.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220622_015142_653542_5998FC6B X-CRM114-Status: GOOD ( 11.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/06/2022 11:19, Liang He wrote: > In highbank_init_irq(), tegra_init_irq() and omap4_cpcap_init(), > we should hold the reference returned by of_find_xxx APIs and > use it to call of_node_put() for refcount balance. > > Signed-off-by: Liang He > --- > arch/arm/mach-highbank/highbank.c | 6 +++++- > arch/arm/mach-omap2/pmic-cpcap.c | 5 ++++- > arch/arm/mach-tegra/irq.c | 6 +++++- > 3 files changed, 14 insertions(+), 3 deletions(-) Before applying the patch please check it carefully. Previous evidence [1] suggests that not it was not even compiled. [1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@intel.com/ Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel