From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED4E5C2BBCA for ; Fri, 28 Jun 2024 07:50:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4Ut43npliJLjCO5SImS5MkBvEx66ZUngy2TmpPvYaKw=; b=ryh3xa6MEI8ep92CVXyHBeBHtL jcs+XADT40O7A1Mnwv+J2Ix4xLNc+HbXUGNvhsJVyel2wkEFR0sxRXg/lkaLTyWk/WR13aRwylffu mvQyNZgGIf+bS1iNDSBJw5WWaB4wUvePauIU09BYvYD35Ighlww4uyrggeBl3pTG9akbbZJUz4dhR eszCKOyvs26jH59o9jxpu2W13sdiBXSIrtBceP96I7ntP5ozhpFyA6Pi33c2vOMXAMWVBl2wgRnKR i0Gz64q+lPIFp8sFYRyTh5oQgzWuFAzfTptb9rkENzG/nuIPaRbV/ngdJBNLD33ez2eQaobymNfq6 hj4Zz+1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sN6NS-0000000Cx7f-3rQE; Fri, 28 Jun 2024 07:50:38 +0000 Received: from mail-oo1-xc33.google.com ([2607:f8b0:4864:20::c33]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sN6NJ-0000000Cx6M-2rVh for linux-arm-kernel@lists.infradead.org; Fri, 28 Jun 2024 07:50:31 +0000 Received: by mail-oo1-xc33.google.com with SMTP id 006d021491bc7-5c229aa4d35so175141eaf.3 for ; Fri, 28 Jun 2024 00:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719561028; x=1720165828; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4Ut43npliJLjCO5SImS5MkBvEx66ZUngy2TmpPvYaKw=; b=IlxM7RI40/QJgfX4EJne6OLNIyNz2pdERDpRBHAYTE9HTNdLutF3Zcx8N3UJAKF1ON I715S8ERp2n0gDP6nYg5JCAChuBaM7NevQRExcXl7g+O5QTC/RfjNe2K1lFs18+oQ8j4 VGWX0iPzctcvjpnszIi8+egzxcpzmwXZUegpMniXvRgNe+UA9nxphaVr5aLkHolj/5l3 6P1sRDpSfdV6qI2XVoZyOv3gCe6pLbAadPCjzpg1H9YSHYLNE10viLRYcG5svr2Xt8Qq ryTQ718mHLTr7oC4KAvF1BXWwcTvlTbU4qVwPtLgFh0Rieq3HXFlYnTvWcJo4TDW/3B0 LKZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719561028; x=1720165828; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4Ut43npliJLjCO5SImS5MkBvEx66ZUngy2TmpPvYaKw=; b=KUrrXg2Q53PlAkQAWQl9psyvjMHB1N7g6ypVcE3eu086B1jY/PERfMGRH+skGMdSU8 OfO/d3KEdZ4TIbH9DJIboU38/luoyaN31cGX6cO2BGzb2VbsRbhlyyWZ9kUQgcLLhnT9 QrVytX//JglWnC8dhEctMcIkKp2s5rAyOS89W880kJlV3Y34qbfnCq46u0Ar2s71jTj6 YRC2BzY5gu01pmYcQWS1G6akql19CovFci8Nqkto5EEdB4sIxGl6si3Ocl/h4PUttqnx 2hTdEUJfkKEMYBNspaollyf6Z00PXUhTJxgbbuoNroBucIsxAv2t9c265Ur+c3YDgkno PFsw== X-Forwarded-Encrypted: i=1; AJvYcCWSgSwj5GolGkE1bAkuNFxsdqenD9mcKAAhDrrlvBjatftdRlRT18+5+lDyCZ348uKf8cRB8urEuNplKOu7qxPMhDc7242t2FTo5gY06f+XXvNrzQ0= X-Gm-Message-State: AOJu0YyxSmPW0wqyboamHtwQZYfARK1hNI+Ht1QwR2jLzkShjeKY1PpC ggTwEOJP0/xxZs1z+Aau7y6F87zUnZ2BycGofd3d65pv/XRPdiJZ X-Google-Smtp-Source: AGHT+IG81TXv6cpLvn9mvPZPAsNd0RQHEY0Ddu8BPsGbU1z/qydncY5VMcfNUGc+bNg5CBr8gzQCLg== X-Received: by 2002:a05:6358:310a:b0:19f:436b:f6b0 with SMTP id e5c5f4694b2df-1a23fafaf3dmr1881852955d.4.1719561028040; Fri, 28 Jun 2024 00:50:28 -0700 (PDT) Received: from [172.19.1.51] (60-250-192-107.hinet-ip.hinet.net. [60.250.192.107]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c6a3139f1sm810210a12.20.2024.06.28.00.50.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jun 2024 00:50:27 -0700 (PDT) Message-ID: Date: Fri, 28 Jun 2024 15:50:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] mmc: sdhci-of-ma35d1: Add Nuvoton MA35D1 SDHCI driver To: Krzysztof Kozlowski , ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, adrian.hunter@intel.com, p.zabel@pengutronix.de, pbrobinson@gmail.com, serghox@gmail.com, mcgrof@kernel.org, prabhakar.mahadev-lad.rj@bp.renesas.com, forbidden405@outlook.com, tmaimon77@gmail.com, andy.shevchenko@gmail.com, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com References: <20240626094900.581552-1-shanchun1218@gmail.com> <20240626094900.581552-3-shanchun1218@gmail.com> <0cc0aab1-f7bf-4a87-af5a-22cf842fbf80@kernel.org> Content-Language: en-US From: Shan-Chun Hung In-Reply-To: <0cc0aab1-f7bf-4a87-af5a-22cf842fbf80@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_005029_746050_174F9F36 X-CRM114-Status: GOOD ( 13.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dear Krzysztof, Thanks for your review. On 2024/6/28 下午 03:31, Krzysztof Kozlowski wrote: > On 26/06/2024 11:49, Shan-Chun Hung wrote: >> Add the SDHCI driver for the MA35D1 platform. It is based upon the >> SDHCI interface, but requires some extra initialization. >> > >> +static int ma35_probe(struct platform_device *pdev) >> +{ >> + struct device *dev = &pdev->dev; >> + struct sdhci_pltfm_host *pltfm_host; >> + struct sdhci_host *host; >> + struct ma35_priv *priv; >> + int err; >> + u32 extra, ctl; >> + >> + host = sdhci_pltfm_init(pdev, &sdhci_ma35_pdata, sizeof(struct ma35_priv)); >> + if (IS_ERR(host)) >> + return PTR_ERR(host); >> + >> + err = devm_add_action_or_reset(dev, ma35_sdhci_pltfm_free, pdev); >> + if (err) >> + return dev_err_probe(dev, err, "Failed to register sdhci_pltfm_free action\n"); >> + >> + /* Extra adma table cnt for cross 128M boundary handling. */ >> + extra = DIV_ROUND_UP_ULL(dma_get_required_mask(dev), SZ_128M); >> + extra = min(extra, SDHCI_MAX_SEGS); >> + >> + host->adma_table_cnt += extra; >> + pltfm_host = sdhci_priv(host); >> + priv = sdhci_pltfm_priv(pltfm_host); >> + >> + pltfm_host->clk = devm_clk_get_optional_enabled(dev, NULL); >> + if (IS_ERR(pltfm_host->clk)) >> + return dev_err_probe(dev, IS_ERR(pltfm_host->clk), "failed to get clk\n"); > Ykes, you cannot return IS_ERR. I will fix it to PTR_ERR. >> + >> + err = mmc_of_parse(host->mmc); >> + if (err) >> + return err; >> + >> + priv->rst = devm_reset_control_get_exclusive(dev, NULL); >> + if (IS_ERR(priv->rst)) >> + return dev_err_probe(dev, PTR_ERR(priv->rst), "failed to get reset control\n"); >> + > > Best regards, > Krzysztof Best Regards, Shan-Chun