From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 408B8C433EF for ; Mon, 2 May 2022 20:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yvHKQJBiFm4llt3B+tOkQ7fQF5FRBEjXf5sx4d1UFXA=; b=Gxvu8NUBMhVcmQ bVotwdOh7GzQ6m1iWRGCJsp/GDoEoJpK7Ckb9Z5lPU6zjGNPn5ifLpBgFmR7FJiZaAMZ9Mr+J521X mUZa0E/JEpNS0F9pUaFKveSPNk8zr8b3KJtnkHgI7+pxhr8/pcDUME77RrXoWcfUtpVloiho9Uf5z 0w70kfUGuvCMFHRZIR9CJJiHlbDGgld/dEDIpe7i5YZ4lFUydbxUCTo51zi1QqOJ1HUjUL/J7+7iL 0Au5BDYX7GFyplmFqJ7jQj6WKvBKdju0b0R3RH1/mWg6ue5nt6H0X7N7ShKYGOygm3EkjNocd75Tm tspytAfKob2gX431Xd6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlcgc-002ZtA-QX; Mon, 02 May 2022 20:30:27 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlcZG-002WT8-48 for linux-arm-kernel@lists.infradead.org; Mon, 02 May 2022 20:22:51 +0000 Received: by mail-ej1-x62b.google.com with SMTP id m20so29769667ejj.10 for ; Mon, 02 May 2022 13:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=8u8XXP2+TwizatTtq/0sBU/H2kbpvchvGg+Or95glsU=; b=c+u7IILtHnqh3gPerojkWNYCi37vsTGEfLtc4gbTUp68Qhm/m2Jbc85vGXEHjTeyGE eF45TX5oeQRnC/yF/jQKLLEOl0pD6br0SYzd/pDcX1ggVJEWEwxlsiYtZkx3mL0A9Afv nxQldhMXLdNIwGxAOodlzhM7I6dinj/npkrWemfHZqYpM75omr++Enhy5sz/mbDuj2e4 ujuuna2uVCOiHVsT5TqAA9k1mwrPlqjDQDO2umL5HcvadDh3fUXSGvocKb1Mm+rurad0 8lmbm5Vl4XPe3fJl30zFLXmYfXJmSZByYyoMlcw6Q7972rb3HkVax4gtzTPvaa1JwyEZ V3Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=8u8XXP2+TwizatTtq/0sBU/H2kbpvchvGg+Or95glsU=; b=Y0pL1BClWxQ42Dcq6nITMKKzPn7VkBhUzxOSqeBPyPfOQcO456ZqnDTh6ndu2+dWAL AXRrgAQoLch1mjALAo3t4Iz//hJShL3A6WEmJrhn4uXU1+96CG8Go8J8kIQRXz56l4lX KakWYdrVDCaWHgqY2oRrryUB8wBKvZhETB0DKYSIfSUH2ieFZl6RDRceil1oVFh6sOP0 bps4EAtIiKRuBkrqg1c3jR+OsY0dvRiI7o2OmhQ8oWF88KaXlh+uAZIMbSiglXfIAZCv 2ncX9fFlM1bMawAkRU9dvYO0sAeZT7PKySxgc+HDUp8PZ60otLfQA6ubUm4fnrYWLGY6 lOfA== X-Gm-Message-State: AOAM532CwNdIINeWQ7eHA0YhXi2xItiRDm8fXI5shcOCj/v5BGNVNYeq A03jJp1Di7d8S5EK1/bmTECH5A== X-Google-Smtp-Source: ABdhPJzt13eXU45qtuo9lvfRz350biQpqqSKjro+GENo7tn3fUz/J8MoV2Z2s7NhXEZ/nmTp8xPJ3g== X-Received: by 2002:a17:906:5d08:b0:6da:b4ea:937 with SMTP id g8-20020a1709065d0800b006dab4ea0937mr12972514ejt.446.1651522965974; Mon, 02 May 2022 13:22:45 -0700 (PDT) Received: from [192.168.0.197] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id yo1-20020a170907136100b006f3ef214e0dsm3916399ejb.115.2022.05.02.13.22.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 May 2022 13:22:45 -0700 (PDT) Message-ID: Date: Mon, 2 May 2022 22:22:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] tty: serial: samsung_tty: Fix suspend/resume on S5L Content-Language: en-US To: Hector Martin , Greg Kroah-Hartman Cc: Sven Peter , Alyssa Rosenzweig , Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220502092505.30934-1-marcan@marcan.st> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220502_132250_234185_80C78BF2 X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/05/2022 14:39, Hector Martin wrote: > On 02/05/2022 20.44, Greg Kroah-Hartman wrote: >> On Mon, May 02, 2022 at 06:25:05PM +0900, Hector Martin wrote: >>> We were restoring the IRQ masks then clearing them again, because >>> ucon_mask wasn't set properly. Adding that makes suspend/resume >>> work as intended. >>> >>> Signed-off-by: Hector Martin >>> --- >>> drivers/tty/serial/samsung_tty.c | 1 + >>> include/linux/serial_s3c.h | 3 +++ >>> 2 files changed, 4 insertions(+) >> >> Does this fix a specific older commit? >> >> And should it be backported to older stable kernels? > > It does fix the commit that introduced this device support in general; I > can add a Fixes line for that. I don't think anyone cares about > backporting though, since there are other fairly critical devices that > don't have support outright and there's still work to do before > suspend/resume is generally usable on these machines. Then please add only Fixes tag. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel