* [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3 @ 2025-05-19 8:20 Guillaume La Roque 2025-06-24 18:42 ` Vignesh Raghavendra 2025-07-01 14:36 ` Matthias Schiffer 0 siblings, 2 replies; 8+ messages in thread From: Guillaume La Roque @ 2025-05-19 8:20 UTC (permalink / raw) To: Catalin Marinas, Will Deacon, Nishanth Menon Cc: Andrew Davis, vishalm, linux-omap, linux-arm-kernel, linux-kernel, Guillaume La Roque After patch done on TI_MESSAGE_MANAGER[1] and TI_SCI_PROTOCOL[2] driver select on ARCH_K3 are not needed anymore. Select MAILBOX by default is not needed anymore[3], PM_GENERIC_DOMAIN if PM was enabled by default so not needed. Remove it and give possibility to enable this driver in modules. [1] https://lore.kernel.org/all/20180828005311.8529-1-nm@ti.com/ [2] https://lore.kernel.org/all/20250220-ti-firmware-v2-1-ff26883c6ce9@baylibre.com/ [3] https://lore.kernel.org/all/20250507135213.g6li6ufp3cosxoys@stinging/ Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> --- Changes in v2: - Remove some other config after comment from Nishanth. - Link to v1: https://lore.kernel.org/r/20250504-kconfig-v1-1-ab0216f4fa98@baylibre.com --- arch/arm64/Kconfig.platforms | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 8b76821f190f..bf9e3d76b4c0 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -135,11 +135,7 @@ config ARCH_SPARX5 config ARCH_K3 bool "Texas Instruments Inc. K3 multicore SoC architecture" - select PM_GENERIC_DOMAINS if PM - select MAILBOX select SOC_TI - select TI_MESSAGE_MANAGER - select TI_SCI_PROTOCOL select TI_K3_SOCINFO help This enables support for Texas Instruments' K3 multicore SoC --- base-commit: e8ab83e34bdc458b5cd77f201e4ed04807978fb1 change-id: 20250504-kconfig-68f139fbf337 Best regards, -- Guillaume La Roque <glaroque@baylibre.com> ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3 2025-05-19 8:20 [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3 Guillaume La Roque @ 2025-06-24 18:42 ` Vignesh Raghavendra 2025-07-01 14:36 ` Matthias Schiffer 1 sibling, 0 replies; 8+ messages in thread From: Vignesh Raghavendra @ 2025-06-24 18:42 UTC (permalink / raw) To: Catalin Marinas, Will Deacon, Nishanth Menon, Guillaume La Roque Cc: Vignesh Raghavendra, Andrew Davis, vishalm, linux-omap, linux-arm-kernel, linux-kernel Hi Guillaume La Roque, On Mon, 19 May 2025 10:20:56 +0200, Guillaume La Roque wrote: > After patch done on TI_MESSAGE_MANAGER[1] and TI_SCI_PROTOCOL[2] driver > select on ARCH_K3 are not needed anymore. > Select MAILBOX by default is not needed anymore[3], > PM_GENERIC_DOMAIN if PM was enabled by default so not needed. > > Remove it and give possibility to enable this driver in modules. > > [...] I have applied the following to branch ti-k3-config-next on [1]. Thank you! [1/1] arm64: Kconfig.platforms: remove useless select for ARCH_K3 commit: 631ce8f743a5c85bd7f0a5e7dcca70566d88f43f All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. [1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git -- Vignesh ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3 2025-05-19 8:20 [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3 Guillaume La Roque 2025-06-24 18:42 ` Vignesh Raghavendra @ 2025-07-01 14:36 ` Matthias Schiffer 2025-07-01 18:57 ` Guillaume La Roque 1 sibling, 1 reply; 8+ messages in thread From: Matthias Schiffer @ 2025-07-01 14:36 UTC (permalink / raw) To: Guillaume La Roque Cc: Andrew Davis, vishalm, linux-omap, linux-arm-kernel, linux-kernel, Catalin Marinas, Will Deacon, Nishanth Menon, linux On Mon, 2025-05-19 at 10:20 +0200, Guillaume La Roque wrote: > > After patch done on TI_MESSAGE_MANAGER[1] and TI_SCI_PROTOCOL[2] driver > select on ARCH_K3 are not needed anymore. > Select MAILBOX by default is not needed anymore[3], > PM_GENERIC_DOMAIN if PM was enabled by default so not needed. Hi, what selects PM_GENERIC_DOMAIN in your configuration? linux-next fails to boot on our AM62x-based TQMa62xx if I don't (partially) revert this patch - I have not found a way to enable PM_GENERIC_DOMAIN and TI_SCI_PM_DOMAINS without enabling other unneeded features to pull it in. Best, Matthias > > Remove it and give possibility to enable this driver in modules. > > [1] https://lore.kernel.org/all/20180828005311.8529-1-nm@ti.com/ > [2] https://lore.kernel.org/all/20250220-ti-firmware-v2-1-ff26883c6ce9@baylibre.com/ > [3] https://lore.kernel.org/all/20250507135213.g6li6ufp3cosxoys@stinging/ > > Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> > --- > Changes in v2: > - Remove some other config after comment from Nishanth. > - Link to v1: https://lore.kernel.org/r/20250504-kconfig-v1-1-ab0216f4fa98@baylibre.com > --- > arch/arm64/Kconfig.platforms | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 8b76821f190f..bf9e3d76b4c0 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -135,11 +135,7 @@ config ARCH_SPARX5 > > config ARCH_K3 > bool "Texas Instruments Inc. K3 multicore SoC architecture" > - select PM_GENERIC_DOMAINS if PM > - select MAILBOX > select SOC_TI > - select TI_MESSAGE_MANAGER > - select TI_SCI_PROTOCOL > select TI_K3_SOCINFO > help > This enables support for Texas Instruments' K3 multicore SoC > > --- > base-commit: e8ab83e34bdc458b5cd77f201e4ed04807978fb1 > change-id: 20250504-kconfig-68f139fbf337 > > Best regards, -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider https://www.tq-group.com/ ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3 2025-07-01 14:36 ` Matthias Schiffer @ 2025-07-01 18:57 ` Guillaume La Roque 2025-07-02 7:25 ` Matthias Schiffer 0 siblings, 1 reply; 8+ messages in thread From: Guillaume La Roque @ 2025-07-01 18:57 UTC (permalink / raw) To: Matthias Schiffer Cc: Andrew Davis, vishalm, linux-omap, linux-arm-kernel, linux-kernel, Catalin Marinas, Will Deacon, Nishanth Menon, linux Le 01/07/2025 à 16:36, Matthias Schiffer a écrit : > On Mon, 2025-05-19 at 10:20 +0200, Guillaume La Roque wrote: >> >> After patch done on TI_MESSAGE_MANAGER[1] and TI_SCI_PROTOCOL[2] driver >> select on ARCH_K3 are not needed anymore. >> Select MAILBOX by default is not needed anymore[3], >> PM_GENERIC_DOMAIN if PM was enabled by default so not needed. > > Hi, Hi, > > what selects PM_GENERIC_DOMAIN in your configuration? linux-next fails to boot > on our AM62x-based TQMa62xx if I don't (partially) revert this patch - I have > not found a way to enable PM_GENERIC_DOMAIN and TI_SCI_PM_DOMAINS without > enabling other unneeded features to pull it in. > With master branch if i apply this patch and i do make ARCH=arm64 defconfig and check in .config both TI_SCI_PM_DOMAINS and PM_GENERIC_DOMAINS are enabled. with linux-next it's same. i don't really understand link with PM part in this patch and boot issue on your SOM. I probably misunderstand something. what is your problem exactly ? if you can share log or link to jobs Regards Guillaume > Best, > Matthias > > >> >> Remove it and give possibility to enable this driver in modules. >> >> [1] https://lore.kernel.org/all/20180828005311.8529-1-nm@ti.com/ >> [2] https://lore.kernel.org/all/20250220-ti-firmware-v2-1-ff26883c6ce9@baylibre.com/ >> [3] https://lore.kernel.org/all/20250507135213.g6li6ufp3cosxoys@stinging/ >> >> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> >> --- >> Changes in v2: >> - Remove some other config after comment from Nishanth. >> - Link to v1: https://lore.kernel.org/r/20250504-kconfig-v1-1-ab0216f4fa98@baylibre.com >> --- >> arch/arm64/Kconfig.platforms | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms >> index 8b76821f190f..bf9e3d76b4c0 100644 >> --- a/arch/arm64/Kconfig.platforms >> +++ b/arch/arm64/Kconfig.platforms >> @@ -135,11 +135,7 @@ config ARCH_SPARX5 >> >> config ARCH_K3 >> bool "Texas Instruments Inc. K3 multicore SoC architecture" >> - select PM_GENERIC_DOMAINS if PM >> - select MAILBOX >> select SOC_TI >> - select TI_MESSAGE_MANAGER >> - select TI_SCI_PROTOCOL >> select TI_K3_SOCINFO >> help >> This enables support for Texas Instruments' K3 multicore SoC >> >> --- >> base-commit: e8ab83e34bdc458b5cd77f201e4ed04807978fb1 >> change-id: 20250504-kconfig-68f139fbf337 >> >> Best regards, > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3 2025-07-01 18:57 ` Guillaume La Roque @ 2025-07-02 7:25 ` Matthias Schiffer 2025-07-02 18:14 ` Guillaume La Roque 2025-07-03 12:28 ` Nishanth Menon 0 siblings, 2 replies; 8+ messages in thread From: Matthias Schiffer @ 2025-07-02 7:25 UTC (permalink / raw) To: Guillaume La Roque Cc: Andrew Davis, vishalm, linux-omap, linux-arm-kernel, linux-kernel, Catalin Marinas, Will Deacon, Nishanth Menon, linux [-- Attachment #1: Type: text/plain, Size: 3683 bytes --] On Tue, 2025-07-01 at 20:57 +0200, Guillaume La Roque wrote: > > Le 01/07/2025 à 16:36, Matthias Schiffer a écrit : > > On Mon, 2025-05-19 at 10:20 +0200, Guillaume La Roque wrote: > > > > > > After patch done on TI_MESSAGE_MANAGER[1] and TI_SCI_PROTOCOL[2] driver > > > select on ARCH_K3 are not needed anymore. > > > Select MAILBOX by default is not needed anymore[3], > > > PM_GENERIC_DOMAIN if PM was enabled by default so not needed. > > > > Hi, > > Hi, > > > > > what selects PM_GENERIC_DOMAIN in your configuration? linux-next fails to boot > > on our AM62x-based TQMa62xx if I don't (partially) revert this patch - I have > > not found a way to enable PM_GENERIC_DOMAIN and TI_SCI_PM_DOMAINS without > > enabling other unneeded features to pull it in. > > > With master branch if i apply this patch and i do make ARCH=arm64 > defconfig and check in .config both TI_SCI_PM_DOMAINS and > PM_GENERIC_DOMAINS are enabled. > with linux-next it's same. i don't really understand link with PM part > in this patch and boot issue on your SOM. > > I probably misunderstand something. > > > what is your problem exactly ? > > if you can share log or link to jobs Hi Guillaume, with arm64_defconfig, this problem doesn't occur, as other CONFIG_ARCH_* symbols also have "select PM_GENERIC_DOMAINS" (with or without "if PM"). We are using a smaller config specific to our K3-based SOMs however. I have attached a defconfig that shows the problem - if you use this as the base for .config on linux-next, there is no way to enable TI_SCI_PM_DOMAINS, as nothing selects PM_GENERIC_DOMAINS. So unless I'm missing some other configuration that would actually be useful on the K3 platform and that would pull in PM_GENERIC_DOMAINS, I think that part needs to be reverted. I can send a patch to that effect later. Best, Matthias > > Regards > Guillaume > > > Best, > > Matthias > > > > > > > > > > Remove it and give possibility to enable this driver in modules. > > > > > > [1] https://lore.kernel.org/all/20180828005311.8529-1-nm@ti.com/ > > > [2] https://lore.kernel.org/all/20250220-ti-firmware-v2-1-ff26883c6ce9@baylibre.com/ > > > [3] https://lore.kernel.org/all/20250507135213.g6li6ufp3cosxoys@stinging/ > > > > > > Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> > > > --- > > > Changes in v2: > > > - Remove some other config after comment from Nishanth. > > > - Link to v1: https://lore.kernel.org/r/20250504-kconfig-v1-1-ab0216f4fa98@baylibre.com > > > --- > > > arch/arm64/Kconfig.platforms | 4 ---- > > > 1 file changed, 4 deletions(-) > > > > > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > > > index 8b76821f190f..bf9e3d76b4c0 100644 > > > --- a/arch/arm64/Kconfig.platforms > > > +++ b/arch/arm64/Kconfig.platforms > > > @@ -135,11 +135,7 @@ config ARCH_SPARX5 > > > > > > config ARCH_K3 > > > bool "Texas Instruments Inc. K3 multicore SoC architecture" > > > - select PM_GENERIC_DOMAINS if PM > > > - select MAILBOX > > > select SOC_TI > > > - select TI_MESSAGE_MANAGER > > > - select TI_SCI_PROTOCOL > > > select TI_K3_SOCINFO > > > help > > > This enables support for Texas Instruments' K3 multicore SoC > > > > > > --- > > > base-commit: e8ab83e34bdc458b5cd77f201e4ed04807978fb1 > > > change-id: 20250504-kconfig-68f139fbf337 > > > > > > Best regards, > > > -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider https://www.tq-group.com/ [-- Attachment #2: defconfig --] [-- Type: text/plain, Size: 14291 bytes --] # CONFIG_LOCALVERSION_AUTO is not set CONFIG_SYSVIPC=y CONFIG_POSIX_MQUEUE=y CONFIG_NO_HZ_IDLE=y CONFIG_HIGH_RES_TIMERS=y CONFIG_BPF_SYSCALL=y CONFIG_BPF_JIT=y CONFIG_BPF_JIT_ALWAYS_ON=y # CONFIG_BPF_UNPRIV_DEFAULT_OFF is not set CONFIG_PREEMPT=y CONFIG_IRQ_TIME_ACCOUNTING=y CONFIG_BSD_PROCESS_ACCT=y CONFIG_BSD_PROCESS_ACCT_V3=y CONFIG_IKCONFIG=y CONFIG_IKCONFIG_PROC=y CONFIG_MEMCG=y CONFIG_BLK_CGROUP=y CONFIG_CFS_BANDWIDTH=y CONFIG_CGROUP_PIDS=y CONFIG_CGROUP_FREEZER=y CONFIG_CGROUP_HUGETLB=y CONFIG_CPUSETS=y CONFIG_CGROUP_DEVICE=y CONFIG_CGROUP_CPUACCT=y CONFIG_CGROUP_PERF=y CONFIG_CGROUP_BPF=y CONFIG_NAMESPACES=y CONFIG_USER_NS=y CONFIG_CHECKPOINT_RESTORE=y CONFIG_SCHED_AUTOGROUP=y CONFIG_BLK_DEV_INITRD=y CONFIG_SYSFS_SYSCALL=y CONFIG_EXPERT=y CONFIG_KALLSYMS_ALL=y CONFIG_PERF_EVENTS=y CONFIG_KEXEC=y CONFIG_KEXEC_FILE=y # CONFIG_CRASH_DUMP is not set CONFIG_ARCH_K3=y CONFIG_ARM64_ERRATUM_2441007=y CONFIG_ARM64_ERRATUM_1286807=y CONFIG_ARM64_ERRATUM_1542419=y CONFIG_ARM64_ERRATUM_2441009=y # CONFIG_CAVIUM_ERRATUM_22375 is not set # CONFIG_CAVIUM_ERRATUM_23154 is not set # CONFIG_CAVIUM_ERRATUM_27456 is not set # CONFIG_CAVIUM_ERRATUM_30115 is not set # CONFIG_HISILICON_ERRATUM_161600802 is not set # CONFIG_QCOM_FALKOR_ERRATUM_1003 is not set # CONFIG_QCOM_FALKOR_ERRATUM_1009 is not set # CONFIG_QCOM_QDF2400_ERRATUM_0065 is not set # CONFIG_QCOM_FALKOR_ERRATUM_E1041 is not set CONFIG_ARM64_VA_BITS_48=y CONFIG_SCHED_MC=y CONFIG_SCHED_SMT=y CONFIG_NR_CPUS=256 CONFIG_COMPAT=y CONFIG_RANDOMIZE_BASE=y # CONFIG_EFI is not set CONFIG_HIBERNATION=y CONFIG_WQ_POWER_EFFICIENT_DEFAULT=y CONFIG_ENERGY_MODEL=y CONFIG_CPU_FREQ=y CONFIG_CPU_FREQ_STAT=y CONFIG_CPU_FREQ_GOV_POWERSAVE=y CONFIG_CPU_FREQ_GOV_USERSPACE=y CONFIG_CPU_FREQ_GOV_ONDEMAND=y CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y CONFIG_CPUFREQ_DT=y CONFIG_VIRTUALIZATION=y CONFIG_JUMP_LABEL=y CONFIG_MODULES=y CONFIG_MODULE_FORCE_LOAD=y CONFIG_MODULE_UNLOAD=y CONFIG_MODULE_FORCE_UNLOAD=y CONFIG_MODVERSIONS=y CONFIG_MODULE_SRCVERSION_ALL=y CONFIG_BLK_DEV_BSGLIB=y # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set # CONFIG_COMPAT_BRK is not set CONFIG_KSM=y CONFIG_MEMORY_FAILURE=y CONFIG_TRANSPARENT_HUGEPAGE=y CONFIG_CMA=y CONFIG_CMA_AREAS=7 CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_XFRM_USER=m CONFIG_NET_KEY=m CONFIG_INET=y CONFIG_IP_MULTICAST=y CONFIG_IP_PNP=y CONFIG_IP_PNP_DHCP=y CONFIG_IP_PNP_BOOTP=y CONFIG_INET_AH=m CONFIG_INET_ESP=m CONFIG_INET_IPCOMP=m CONFIG_INET6_AH=m CONFIG_INET6_IPCOMP=m CONFIG_IPV6_SIT=m CONFIG_IPV6_TUNNEL=m CONFIG_NETFILTER=y CONFIG_NF_CONNTRACK=m CONFIG_NF_CONNTRACK_EVENTS=y CONFIG_NETFILTER_XT_TARGET_CHECKSUM=m CONFIG_NETFILTER_XT_TARGET_CLASSIFY=m CONFIG_NETFILTER_XT_TARGET_IDLETIMER=m CONFIG_NETFILTER_XT_TARGET_LOG=m CONFIG_NETFILTER_XT_TARGET_MARK=m CONFIG_NETFILTER_XT_MATCH_ADDRTYPE=m CONFIG_NETFILTER_XT_MATCH_COMMENT=m CONFIG_NETFILTER_XT_MATCH_CONNTRACK=m CONFIG_NETFILTER_XT_MATCH_CPU=m CONFIG_NETFILTER_XT_MATCH_IPRANGE=m CONFIG_NETFILTER_XT_MATCH_LENGTH=m CONFIG_NETFILTER_XT_MATCH_LIMIT=m CONFIG_NETFILTER_XT_MATCH_MAC=m CONFIG_NETFILTER_XT_MATCH_MARK=m CONFIG_NETFILTER_XT_MATCH_MULTIPORT=m CONFIG_NETFILTER_XT_MATCH_POLICY=m CONFIG_NETFILTER_XT_MATCH_PKTTYPE=m CONFIG_NF_LOG_IPV4=m CONFIG_IP_NF_IPTABLES=m CONFIG_IP_NF_FILTER=m CONFIG_IP_NF_TARGET_REJECT=m CONFIG_IP_NF_NAT=m CONFIG_IP_NF_TARGET_MASQUERADE=m CONFIG_IP_NF_MANGLE=m CONFIG_IP_NF_ARPFILTER=m CONFIG_IP_NF_ARP_MANGLE=m CONFIG_IP6_NF_IPTABLES=m CONFIG_IP6_NF_FILTER=m CONFIG_IP6_NF_TARGET_REJECT=m CONFIG_IP6_NF_MANGLE=m CONFIG_IP6_NF_NAT=m CONFIG_IP6_NF_TARGET_MASQUERADE=m CONFIG_BRIDGE_NF_EBTABLES=m CONFIG_BRIDGE_EBT_BROUTE=m CONFIG_BRIDGE_EBT_T_FILTER=m CONFIG_BRIDGE_EBT_T_NAT=m CONFIG_BRIDGE_EBT_802_3=m CONFIG_BRIDGE_EBT_AMONG=m CONFIG_BRIDGE_EBT_ARP=m CONFIG_BRIDGE_EBT_IP=m CONFIG_BRIDGE_EBT_IP6=m CONFIG_BRIDGE_EBT_LIMIT=m CONFIG_BRIDGE_EBT_MARK=m CONFIG_BRIDGE_EBT_PKTTYPE=m CONFIG_BRIDGE_EBT_STP=m CONFIG_BRIDGE_EBT_VLAN=m CONFIG_BRIDGE_EBT_ARPREPLY=m CONFIG_BRIDGE_EBT_DNAT=m CONFIG_BRIDGE_EBT_MARK_T=m CONFIG_BRIDGE_EBT_REDIRECT=m CONFIG_BRIDGE_EBT_SNAT=m CONFIG_BRIDGE_EBT_LOG=m CONFIG_BRIDGE_EBT_NFLOG=m CONFIG_IP_SCTP=m CONFIG_BRIDGE=m CONFIG_BRIDGE_VLAN_FILTERING=y CONFIG_VLAN_8021Q=y CONFIG_VLAN_8021Q_GVRP=y CONFIG_VLAN_8021Q_MVRP=y CONFIG_NET_SCHED=y CONFIG_NET_SCH_HTB=m CONFIG_NET_SCH_HFSC=m CONFIG_NET_SCH_PRIO=m CONFIG_NET_SCH_MULTIQ=m CONFIG_NET_SCH_RED=m CONFIG_NET_SCH_SFB=m CONFIG_NET_SCH_SFQ=m CONFIG_NET_SCH_TEQL=m CONFIG_NET_SCH_TBF=m CONFIG_NET_SCH_CBS=m CONFIG_NET_SCH_ETF=m CONFIG_NET_SCH_TAPRIO=m CONFIG_NET_SCH_GRED=m CONFIG_NET_SCH_NETEM=m CONFIG_NET_SCH_DRR=m CONFIG_NET_SCH_MQPRIO=m CONFIG_NET_SCH_CHOKE=m CONFIG_NET_SCH_QFQ=m CONFIG_NET_SCH_CODEL=m CONFIG_NET_SCH_FQ_CODEL=y CONFIG_NET_SCH_INGRESS=m CONFIG_NET_CLS_BASIC=m CONFIG_NET_CLS_ROUTE4=m CONFIG_NET_CLS_FW=m CONFIG_NET_CLS_U32=m CONFIG_CLS_U32_MARK=y CONFIG_NET_CLS_FLOW=m CONFIG_NET_CLS_FLOWER=m CONFIG_NET_EMATCH=y CONFIG_NET_EMATCH_CMP=m CONFIG_NET_EMATCH_NBYTE=m CONFIG_NET_EMATCH_U32=m CONFIG_NET_EMATCH_META=m CONFIG_NET_EMATCH_TEXT=m CONFIG_NET_CLS_ACT=y CONFIG_NET_ACT_POLICE=m CONFIG_NET_ACT_GACT=m CONFIG_GACT_PROB=y CONFIG_NET_ACT_MIRRED=m CONFIG_NET_ACT_NAT=m CONFIG_NET_ACT_PEDIT=m CONFIG_NET_ACT_SIMP=m CONFIG_NET_ACT_SKBEDIT=m CONFIG_NET_ACT_CSUM=m CONFIG_NET_ACT_GATE=m CONFIG_HSR=y CONFIG_NET_SWITCHDEV=y CONFIG_CAN=y CONFIG_BT=y CONFIG_BT_HIDP=m CONFIG_BT_LEDS=y CONFIG_BT_HCIBTUSB=m CONFIG_BT_HCIUART=m CONFIG_BT_HCIUART_MRVL=y CONFIG_BT_MRVL=m CONFIG_BT_MRVL_SDIO=m CONFIG_CFG80211=m CONFIG_NL80211_TESTMODE=y CONFIG_MAC80211=m CONFIG_MAC80211_MESH=y CONFIG_RFKILL=y CONFIG_PCI=y CONFIG_PCIEPORTBUS=y CONFIG_PCI_IOV=y CONFIG_PCI_PASID=y CONFIG_HOTPLUG_PCI=y CONFIG_PCIE_ALTERA=y CONFIG_PCIE_ALTERA_MSI=y CONFIG_PCI_HOST_THUNDER_PEM=y CONFIG_PCI_HOST_THUNDER_ECAM=y CONFIG_PCI_HOST_GENERIC=y CONFIG_PCI_J721E_HOST=y CONFIG_PCI_J721E_EP=y CONFIG_PCI_KEYSTONE_HOST=y CONFIG_PCI_KEYSTONE_EP=y CONFIG_PCI_ENDPOINT=y CONFIG_PCI_ENDPOINT_CONFIGFS=y CONFIG_PCI_EPF_TEST=y CONFIG_PCI_EPF_NTB=y CONFIG_DEVTMPFS=y CONFIG_DEVTMPFS_MOUNT=y CONFIG_MTD=y CONFIG_MTD_CMDLINE_PARTS=y CONFIG_MTD_BLOCK=y CONFIG_MTD_SPI_NOR=y # CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set CONFIG_MTD_UBI=y CONFIG_OF_OVERLAY=y CONFIG_BLK_DEV_LOOP=y CONFIG_BLK_DEV_NBD=m CONFIG_BLK_DEV_RAM=y CONFIG_VIRTIO_BLK=y CONFIG_BLK_DEV_NVME=m CONFIG_SRAM=y CONFIG_EEPROM_AT24=y CONFIG_SCSI=y # CONFIG_SCSI_PROC_FS is not set CONFIG_BLK_DEV_SD=y # CONFIG_SCSI_LOWLEVEL is not set CONFIG_MD=y CONFIG_BLK_DEV_MD=m CONFIG_BLK_DEV_DM=m CONFIG_DM_MIRROR=m CONFIG_DM_ZERO=m CONFIG_NETDEVICES=y CONFIG_MACVLAN=m CONFIG_MACVTAP=m CONFIG_TUN=y CONFIG_VETH=m CONFIG_VIRTIO_NET=y CONFIG_E1000=m CONFIG_E1000E=m CONFIG_IGBVF=y CONFIG_TI_K3_AM65_CPSW_NUSS=y CONFIG_TI_K3_AM65_CPSW_SWITCHDEV=y CONFIG_TI_K3_AM65_CPTS=y CONFIG_TI_ICSSG_PRUETH=m CONFIG_AQUANTIA_PHY=y CONFIG_MARVELL_PHY=y CONFIG_MARVELL_10G_PHY=m CONFIG_MICREL_PHY=y CONFIG_MICROSEMI_PHY=y CONFIG_AT803X_PHY=y CONFIG_REALTEK_PHY=m CONFIG_ROCKCHIP_PHY=y CONFIG_DP83848_PHY=y CONFIG_DP83867_PHY=y CONFIG_DP83869_PHY=y CONFIG_DP83TG720_PHY=y CONFIG_VITESSE_PHY=y CONFIG_CAN_M_CAN=y CONFIG_CAN_M_CAN_PLATFORM=y CONFIG_MDIO_BUS_MUX_MULTIPLEXER=y CONFIG_MDIO_BUS_MUX_MMIOREG=y CONFIG_USB_NET_DRIVERS=m CONFIG_USB_PEGASUS=m CONFIG_USB_RTL8150=m CONFIG_USB_RTL8152=m CONFIG_USB_LAN78XX=m CONFIG_USB_USBNET=m CONFIG_USB_NET_CDC_EEM=m CONFIG_USB_NET_DM9601=m CONFIG_USB_NET_SR9800=m CONFIG_USB_NET_SMSC75XX=m CONFIG_USB_NET_SMSC95XX=m CONFIG_USB_NET_PLUSB=m CONFIG_USB_NET_MCS7830=m CONFIG_ATH10K=m CONFIG_MWIFIEX=m CONFIG_MWIFIEX_SDIO=m CONFIG_INPUT_EVDEV=y CONFIG_KEYBOARD_ADC=m CONFIG_KEYBOARD_GPIO=y CONFIG_INPUT_TOUCHSCREEN=y CONFIG_TOUCHSCREEN_ATMEL_MXT=m CONFIG_TOUCHSCREEN_GOODIX=m CONFIG_TOUCHSCREEN_EDT_FT5X06=m CONFIG_TOUCHSCREEN_TI_AM335X_TSC=m CONFIG_TOUCHSCREEN_PIXCIR=m CONFIG_INPUT_MISC=y CONFIG_INPUT_GPIO_DECODER=m CONFIG_INPUT_TPS65219_PWRBUTTON=y # CONFIG_SERIO_SERPORT is not set CONFIG_SERIO_AMBAKMI=y CONFIG_LEGACY_PTY_COUNT=16 CONFIG_SERIAL_8250=y CONFIG_SERIAL_8250_CONSOLE=y CONFIG_SERIAL_8250_NR_UARTS=10 CONFIG_SERIAL_8250_RUNTIME_UARTS=10 CONFIG_SERIAL_8250_EXTENDED=y CONFIG_SERIAL_8250_SHARE_IRQ=y CONFIG_SERIAL_8250_OMAP=y CONFIG_SERIAL_OF_PLATFORM=y CONFIG_SERIAL_DEV_BUS=y CONFIG_VIRTIO_CONSOLE=y CONFIG_IPMI_HANDLER=m CONFIG_IPMI_DEVICE_INTERFACE=m CONFIG_IPMI_SI=m CONFIG_HW_RANDOM_CN10K=y CONFIG_TCG_TPM=y CONFIG_TCG_TIS_I2C_INFINEON=y CONFIG_I2C_CHARDEV=y CONFIG_I2C_OMAP=y CONFIG_SPI=y CONFIG_SPI_CADENCE_QUADSPI=y CONFIG_SPI_OMAP24XX=y CONFIG_SPI_SPIDEV=y CONFIG_SPMI=y CONFIG_PINCTRL=y CONFIG_PINCTRL_SINGLE=y CONFIG_GPIO_SYSFS=y CONFIG_GPIO_DAVINCI=y CONFIG_GPIO_PCA953X=y CONFIG_GPIO_PCA953X_IRQ=y CONFIG_POWER_SEQUENCING=y CONFIG_SENSORS_JC42=y CONFIG_SENSORS_LM75=y CONFIG_SENSORS_PWM_FAN=y CONFIG_THERMAL=y CONFIG_THERMAL_GOV_POWER_ALLOCATOR=y CONFIG_CPU_THERMAL=y CONFIG_THERMAL_EMULATION=y CONFIG_K3_THERMAL=y CONFIG_WATCHDOG=y CONFIG_K3_RTI_WATCHDOG=y CONFIG_ARM_SMC_WATCHDOG=y CONFIG_MFD_TI_AM335X_TSCADC=y CONFIG_MFD_TPS65219=y CONFIG_MFD_TPS6594_I2C=y CONFIG_REGULATOR=y CONFIG_REGULATOR_FIXED_VOLTAGE=y CONFIG_REGULATOR_GPIO=y CONFIG_REGULATOR_RASPBERRYPI_TOUCHSCREEN_ATTINY=y CONFIG_REGULATOR_TPS65219=y CONFIG_MEDIA_SUPPORT=y CONFIG_MEDIA_SUPPORT_FILTER=y CONFIG_MEDIA_CAMERA_SUPPORT=y CONFIG_MEDIA_PLATFORM_SUPPORT=y CONFIG_VIDEO_CADENCE_CSI2RX=y CONFIG_VIDEO_TI_J721E_CSI2RX=y CONFIG_VIDEO_IMX219=y CONFIG_VIDEO_IMX290=y CONFIG_VIDEO_OV9282=y CONFIG_DRM=y CONFIG_DRM_PANEL_LVDS=y CONFIG_DRM_PANEL_EDP=y CONFIG_DRM_PANEL_SIMPLE=y CONFIG_DRM_DISPLAY_CONNECTOR=y CONFIG_DRM_TOSHIBA_TC358762=y CONFIG_DRM_TOSHIBA_TC358767=y CONFIG_DRM_TI_SN65DSI86=y CONFIG_DRM_CDNS_DSI=y CONFIG_DRM_TIDSS=y CONFIG_FB=y CONFIG_BACKLIGHT_CLASS_DEVICE=y CONFIG_BACKLIGHT_PWM=y CONFIG_LOGO=y CONFIG_SOUND=y CONFIG_SND=y CONFIG_SND_HRTIMER=y CONFIG_SND_DYNAMIC_MINORS=y CONFIG_SND_SOC=y CONFIG_SND_SIMPLE_CARD=y CONFIG_SND_SOC_DAVINCI_MCASP=y CONFIG_SND_SOC_TLV320AIC32X4_I2C=y CONFIG_HID_MULTITOUCH=y CONFIG_USB_HID=m CONFIG_USB_CONN_GPIO=y CONFIG_USB=y # CONFIG_USB_PCI is not set CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_OTG=y CONFIG_USB_OTG_FSM=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_ACM=m CONFIG_USB_STORAGE=y CONFIG_USB_UAS=y CONFIG_USB_CDNS_SUPPORT=y CONFIG_USB_CDNS3=y CONFIG_USB_CDNS3_GADGET=y CONFIG_USB_CDNS3_HOST=y CONFIG_USB_DWC3=y CONFIG_USB_SERIAL=m CONFIG_USB_SERIAL_CP210X=m CONFIG_USB_SERIAL_FTDI_SIO=m CONFIG_USB_SERIAL_PL2303=m CONFIG_USB_SERIAL_OPTION=m CONFIG_USB_TEST=m CONFIG_USB_ONBOARD_DEV=y CONFIG_NOP_USB_XCEIV=m CONFIG_USB_GADGET=y CONFIG_USB_GADGET_STORAGE_NUM_BUFFERS=32 CONFIG_USB_CONFIGFS=m CONFIG_USB_CONFIGFS_SERIAL=y CONFIG_USB_CONFIGFS_ACM=y CONFIG_USB_CONFIGFS_OBEX=y CONFIG_USB_CONFIGFS_NCM=y CONFIG_USB_CONFIGFS_ECM=y CONFIG_USB_CONFIGFS_ECM_SUBSET=y CONFIG_USB_CONFIGFS_RNDIS=y CONFIG_USB_CONFIGFS_EEM=y CONFIG_USB_CONFIGFS_MASS_STORAGE=y CONFIG_USB_CONFIGFS_F_LB_SS=y CONFIG_USB_CONFIGFS_F_FS=y CONFIG_USB_CONFIGFS_F_HID=y CONFIG_USB_CONFIGFS_F_PRINTER=y CONFIG_USB_ZERO=m CONFIG_USB_ETH=m CONFIG_USB_G_NCM=m CONFIG_USB_GADGETFS=m CONFIG_USB_FUNCTIONFS=m CONFIG_USB_FUNCTIONFS_ETH=y CONFIG_USB_FUNCTIONFS_RNDIS=y CONFIG_USB_FUNCTIONFS_GENERIC=y CONFIG_USB_MASS_STORAGE=m CONFIG_USB_G_SERIAL=m CONFIG_USB_G_PRINTER=m CONFIG_USB_CDC_COMPOSITE=m CONFIG_USB_G_ACM_MS=m CONFIG_USB_G_MULTI=m CONFIG_USB_G_MULTI_CDC=y CONFIG_USB_G_HID=m CONFIG_USB_G_DBGP=m CONFIG_MMC=y CONFIG_MMC_BLOCK_MINORS=32 CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_PLTFM=y CONFIG_MMC_SDHCI_AM654=y CONFIG_NEW_LEDS=y CONFIG_LEDS_CLASS=y CONFIG_LEDS_GPIO=y CONFIG_LEDS_TRIGGER_TIMER=y CONFIG_LEDS_TRIGGER_HEARTBEAT=y CONFIG_LEDS_TRIGGER_CPU=y CONFIG_LEDS_TRIGGER_DEFAULT_ON=y CONFIG_LEDS_TRIGGER_PANIC=y CONFIG_EDAC=y # CONFIG_EDAC_LEGACY_SYSFS is not set CONFIG_RTC_CLASS=y CONFIG_RTC_DRV_PCF85063=y CONFIG_RTC_DRV_TI_K3=y CONFIG_DMADEVICES=y CONFIG_TI_K3_UDMA=y CONFIG_TI_K3_UDMA_GLUE_LAYER=y CONFIG_DMABUF_HEAPS=y CONFIG_DMABUF_HEAPS_SYSTEM=y CONFIG_DMABUF_HEAPS_CMA=y CONFIG_UIO=y CONFIG_VFIO=y CONFIG_VFIO_PCI=y CONFIG_VIRTIO_PCI=y CONFIG_VIRTIO_BALLOON=y CONFIG_VIRTIO_MMIO=y CONFIG_COMMON_CLK_CS2000_CP=y CONFIG_COMMON_CLK_VC5=y CONFIG_TI_SCI_CLK=y CONFIG_HWSPINLOCK=y CONFIG_HWSPINLOCK_OMAP=y CONFIG_MAILBOX=y CONFIG_OMAP2PLUS_MBOX=y CONFIG_ARM_SMMU=y CONFIG_ARM_SMMU_V3=y CONFIG_REMOTEPROC=y CONFIG_TI_K3_DSP_REMOTEPROC=m CONFIG_TI_K3_M4_REMOTEPROC=m CONFIG_TI_K3_R5_REMOTEPROC=m CONFIG_RPMSG_CHAR=m CONFIG_RPMSG_VIRTIO=m CONFIG_TI_PRUSS=y CONFIG_MEMORY=y CONFIG_IIO=y CONFIG_TI_AM335X_ADC=y CONFIG_PWM=y CONFIG_PWM_TIEHRPWM=y CONFIG_TI_SCI_INTR_IRQCHIP=y CONFIG_TI_SCI_INTA_IRQCHIP=y CONFIG_RESET_CONTROLLER=y CONFIG_RESET_TI_SCI=y CONFIG_PHY_CADENCE_TORRENT=y CONFIG_PHY_CADENCE_DPHY=y CONFIG_PHY_CADENCE_DPHY_RX=y CONFIG_PHY_J721E_WIZ=y CONFIG_TEE=y CONFIG_OPTEE=y CONFIG_INTERCONNECT=y CONFIG_EXT4_FS=y CONFIG_EXT4_FS_POSIX_ACL=y CONFIG_EXT4_FS_SECURITY=y CONFIG_BTRFS_FS=m CONFIG_BTRFS_FS_POSIX_ACL=y CONFIG_FANOTIFY=y CONFIG_FANOTIFY_ACCESS_PERMISSIONS=y CONFIG_QUOTA=y CONFIG_AUTOFS_FS=y CONFIG_FUSE_FS=y CONFIG_CUSE=m CONFIG_OVERLAY_FS=m CONFIG_VFAT_FS=y CONFIG_TMPFS=y CONFIG_TMPFS_POSIX_ACL=y CONFIG_HUGETLBFS=y CONFIG_UBIFS_FS=y CONFIG_SQUASHFS=y CONFIG_NFS_FS=y CONFIG_NFS_V2=y CONFIG_NFS_V4=y CONFIG_NFS_V4_1=y CONFIG_NFS_V4_2=y CONFIG_ROOT_NFS=y CONFIG_CIFS=m # CONFIG_CIFS_STATS2 is not set CONFIG_CIFS_XATTR=y CONFIG_CIFS_POSIX=y CONFIG_NLS_CODEPAGE_437=y CONFIG_NLS_ISO8859_1=y CONFIG_SECURITY=y CONFIG_LSM="lockdown,yama,loadpin,safesetid,integrity,bpf" CONFIG_INIT_STACK_NONE=y CONFIG_CRYPTO_NULL=y CONFIG_CRYPTO_CRYPTD=y CONFIG_CRYPTO_XTS=m CONFIG_CRYPTO_CCM=y CONFIG_CRYPTO_GCM=y CONFIG_CRYPTO_ECHAINIV=y CONFIG_CRYPTO_MD4=m CONFIG_CRYPTO_CRC32C=y CONFIG_CRYPTO_ANSI_CPRNG=y CONFIG_CRYPTO_USER_API_RNG=m CONFIG_CRYPTO_GHASH_ARM64_CE=y CONFIG_CRYPTO_SHA1_ARM64_CE=y CONFIG_CRYPTO_SHA3_ARM64=m CONFIG_CRYPTO_SM3_ARM64_CE=m CONFIG_CRYPTO_AES_ARM64=y CONFIG_CRYPTO_AES_ARM64_BS=m CONFIG_CRYPTO_AES_ARM64_CE_CCM=y CONFIG_CRYPTO_DEV_SA2UL=y CONFIG_DMA_CMA=y CONFIG_CMA_SIZE_MBYTES=24 CONFIG_PRINTK_TIME=y CONFIG_DYNAMIC_DEBUG=y CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y CONFIG_DEBUG_INFO_SPLIT=y CONFIG_GDB_SCRIPTS=y CONFIG_DEBUG_FS=y CONFIG_KGDB=y CONFIG_KGDB_KDB=y # CONFIG_SLUB_DEBUG is not set CONFIG_RCU_CPU_STALL_TIMEOUT=300 CONFIG_FUNCTION_TRACER=y CONFIG_SAMPLES=y CONFIG_SAMPLE_RPMSG_CLIENT=m CONFIG_MEMTEST=y ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3 2025-07-02 7:25 ` Matthias Schiffer @ 2025-07-02 18:14 ` Guillaume La Roque 2025-07-03 12:28 ` Nishanth Menon 1 sibling, 0 replies; 8+ messages in thread From: Guillaume La Roque @ 2025-07-02 18:14 UTC (permalink / raw) To: Matthias Schiffer, Vignesh Raghavendra Cc: Andrew Davis, vishalm, linux-omap, linux-arm-kernel, linux-kernel, Catalin Marinas, Will Deacon, Nishanth Menon, linux Hi, + Vignesh who was lost in email list , sorry for that Le 02/07/2025 à 09:25, Matthias Schiffer a écrit : > On Tue, 2025-07-01 at 20:57 +0200, Guillaume La Roque wrote: >> >> Le 01/07/2025 à 16:36, Matthias Schiffer a écrit : >>> On Mon, 2025-05-19 at 10:20 +0200, Guillaume La Roque wrote: >>>> >>>> After patch done on TI_MESSAGE_MANAGER[1] and TI_SCI_PROTOCOL[2] driver >>>> select on ARCH_K3 are not needed anymore. >>>> Select MAILBOX by default is not needed anymore[3], >>>> PM_GENERIC_DOMAIN if PM was enabled by default so not needed. >>> >>> Hi, >> >> Hi, >> >>> >>> what selects PM_GENERIC_DOMAIN in your configuration? linux-next fails to boot >>> on our AM62x-based TQMa62xx if I don't (partially) revert this patch - I have >>> not found a way to enable PM_GENERIC_DOMAIN and TI_SCI_PM_DOMAINS without >>> enabling other unneeded features to pull it in. >>> >> With master branch if i apply this patch and i do make ARCH=arm64 >> defconfig and check in .config both TI_SCI_PM_DOMAINS and >> PM_GENERIC_DOMAINS are enabled. >> with linux-next it's same. i don't really understand link with PM part >> in this patch and boot issue on your SOM. >> >> I probably misunderstand something. >> >> >> what is your problem exactly ? >> >> if you can share log or link to jobs > > > Hi Guillaume, > > with arm64_defconfig, this problem doesn't occur, as other CONFIG_ARCH_* symbols > also have "select PM_GENERIC_DOMAINS" (with or without "if PM"). > > We are using a smaller config specific to our K3-based SOMs however. I have > attached a defconfig that shows the problem - if you use this as the base for > .config on linux-next, there is no way to enable TI_SCI_PM_DOMAINS, as nothing > selects PM_GENERIC_DOMAINS. > > So unless I'm missing some other configuration that would actually be useful on > the K3 platform and that would pull in PM_GENERIC_DOMAINS, I think that part > needs to be reverted. I can send a patch to that effect later. > not sure good patch was to enable PM_GENERIC_DOMAINS on ARCH_K3 but it's a deps on TI_SCI_PM_DOMAINS so perhaps do a select in PM_GENERIC_DOMAINS Kconfig instead of a depends on should be a better solution . Nishanth and vignesh what do you prefer for this issue ? thanks Guillaume > Best, > Matthias > > >> >> Regards >> Guillaume >> >>> Best, >>> Matthias >>> >>> >>>> >>>> Remove it and give possibility to enable this driver in modules. >>>> >>>> [1] https://lore.kernel.org/all/20180828005311.8529-1-nm@ti.com/ >>>> [2] https://lore.kernel.org/all/20250220-ti-firmware-v2-1-ff26883c6ce9@baylibre.com/ >>>> [3] https://lore.kernel.org/all/20250507135213.g6li6ufp3cosxoys@stinging/ >>>> >>>> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> >>>> --- >>>> Changes in v2: >>>> - Remove some other config after comment from Nishanth. >>>> - Link to v1: https://lore.kernel.org/r/20250504-kconfig-v1-1-ab0216f4fa98@baylibre.com >>>> --- >>>> arch/arm64/Kconfig.platforms | 4 ---- >>>> 1 file changed, 4 deletions(-) >>>> >>>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms >>>> index 8b76821f190f..bf9e3d76b4c0 100644 >>>> --- a/arch/arm64/Kconfig.platforms >>>> +++ b/arch/arm64/Kconfig.platforms >>>> @@ -135,11 +135,7 @@ config ARCH_SPARX5 >>>> >>>> config ARCH_K3 >>>> bool "Texas Instruments Inc. K3 multicore SoC architecture" >>>> - select PM_GENERIC_DOMAINS if PM >>>> - select MAILBOX >>>> select SOC_TI >>>> - select TI_MESSAGE_MANAGER >>>> - select TI_SCI_PROTOCOL >>>> select TI_K3_SOCINFO >>>> help >>>> This enables support for Texas Instruments' K3 multicore SoC >>>> >>>> --- >>>> base-commit: e8ab83e34bdc458b5cd77f201e4ed04807978fb1 >>>> change-id: 20250504-kconfig-68f139fbf337 >>>> >>>> Best regards, >>> >> > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3 2025-07-02 7:25 ` Matthias Schiffer 2025-07-02 18:14 ` Guillaume La Roque @ 2025-07-03 12:28 ` Nishanth Menon 2025-07-07 9:59 ` Guillaume La Roque 1 sibling, 1 reply; 8+ messages in thread From: Nishanth Menon @ 2025-07-03 12:28 UTC (permalink / raw) To: Matthias Schiffer Cc: Guillaume La Roque, Andrew Davis, vishalm, linux-omap, linux-arm-kernel, linux-kernel, Catalin Marinas, Will Deacon, linux On 09:25-20250702, Matthias Schiffer wrote: > On Tue, 2025-07-01 at 20:57 +0200, Guillaume La Roque wrote: > > > > Le 01/07/2025 à 16:36, Matthias Schiffer a écrit : > > > On Mon, 2025-05-19 at 10:20 +0200, Guillaume La Roque wrote: > > > > > > > > After patch done on TI_MESSAGE_MANAGER[1] and TI_SCI_PROTOCOL[2] driver > > > > select on ARCH_K3 are not needed anymore. > > > > Select MAILBOX by default is not needed anymore[3], > > > > PM_GENERIC_DOMAIN if PM was enabled by default so not needed. > > > > > > Hi, > > > > Hi, > > > > > > > > what selects PM_GENERIC_DOMAIN in your configuration? linux-next fails to boot > > > on our AM62x-based TQMa62xx if I don't (partially) revert this patch - I have > > > not found a way to enable PM_GENERIC_DOMAIN and TI_SCI_PM_DOMAINS without > > > enabling other unneeded features to pull it in. > > > > > With master branch if i apply this patch and i do make ARCH=arm64 > > defconfig and check in .config both TI_SCI_PM_DOMAINS and > > PM_GENERIC_DOMAINS are enabled. > > with linux-next it's same. i don't really understand link with PM part > > in this patch and boot issue on your SOM. > > > > I probably misunderstand something. > > > > > > what is your problem exactly ? > > > > if you can share log or link to jobs > > > Hi Guillaume, > > with arm64_defconfig, this problem doesn't occur, as other CONFIG_ARCH_* symbols > also have "select PM_GENERIC_DOMAINS" (with or without "if PM"). > > We are using a smaller config specific to our K3-based SOMs however. I have > attached a defconfig that shows the problem - if you use this as the base for > .config on linux-next, there is no way to enable TI_SCI_PM_DOMAINS, as nothing > selects PM_GENERIC_DOMAINS. > > So unless I'm missing some other configuration that would actually be useful on > the K3 platform and that would pull in PM_GENERIC_DOMAINS, I think that part > needs to be reverted. I can send a patch to that effect later. Is a better approach to select PM_GENERIC_DOMAINS in drivers/pmdomain/ti/Kconfig instead of depends (similar to what drivers/pmdomain/qcom/Kconfig or drivers/pmdomain/arm/Kconfig does since TI_SCI_PM_DOMAINS requires PM_GENERIC_DOMAINS? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3 2025-07-03 12:28 ` Nishanth Menon @ 2025-07-07 9:59 ` Guillaume La Roque 0 siblings, 0 replies; 8+ messages in thread From: Guillaume La Roque @ 2025-07-07 9:59 UTC (permalink / raw) To: Nishanth Menon, Matthias Schiffer Cc: Andrew Davis, vishalm, linux-omap, linux-arm-kernel, linux-kernel, Catalin Marinas, Will Deacon, linux Hi, Le 03/07/2025 à 14:28, Nishanth Menon a écrit : > On 09:25-20250702, Matthias Schiffer wrote: >> On Tue, 2025-07-01 at 20:57 +0200, Guillaume La Roque wrote: >>> >>> Le 01/07/2025 à 16:36, Matthias Schiffer a écrit : >>>> On Mon, 2025-05-19 at 10:20 +0200, Guillaume La Roque wrote: >>>>> >>>>> After patch done on TI_MESSAGE_MANAGER[1] and TI_SCI_PROTOCOL[2] driver >>>>> select on ARCH_K3 are not needed anymore. >>>>> Select MAILBOX by default is not needed anymore[3], >>>>> PM_GENERIC_DOMAIN if PM was enabled by default so not needed. >>>> >>>> Hi, >>> >>> Hi, >>> >>>> >>>> what selects PM_GENERIC_DOMAIN in your configuration? linux-next fails to boot >>>> on our AM62x-based TQMa62xx if I don't (partially) revert this patch - I have >>>> not found a way to enable PM_GENERIC_DOMAIN and TI_SCI_PM_DOMAINS without >>>> enabling other unneeded features to pull it in. >>>> >>> With master branch if i apply this patch and i do make ARCH=arm64 >>> defconfig and check in .config both TI_SCI_PM_DOMAINS and >>> PM_GENERIC_DOMAINS are enabled. >>> with linux-next it's same. i don't really understand link with PM part >>> in this patch and boot issue on your SOM. >>> >>> I probably misunderstand something. >>> >>> >>> what is your problem exactly ? >>> >>> if you can share log or link to jobs >> >> >> Hi Guillaume, >> >> with arm64_defconfig, this problem doesn't occur, as other CONFIG_ARCH_* symbols >> also have "select PM_GENERIC_DOMAINS" (with or without "if PM"). >> >> We are using a smaller config specific to our K3-based SOMs however. I have >> attached a defconfig that shows the problem - if you use this as the base for >> .config on linux-next, there is no way to enable TI_SCI_PM_DOMAINS, as nothing >> selects PM_GENERIC_DOMAINS. >> >> So unless I'm missing some other configuration that would actually be useful on >> the K3 platform and that would pull in PM_GENERIC_DOMAINS, I think that part >> needs to be reverted. I can send a patch to that effect later. > > Is a better approach to select PM_GENERIC_DOMAINS in > drivers/pmdomain/ti/Kconfig instead of depends (similar to what > drivers/pmdomain/qcom/Kconfig or drivers/pmdomain/arm/Kconfig does since > TI_SCI_PM_DOMAINS requires PM_GENERIC_DOMAINS? > I send patch to do this : https://lore.kernel.org/all/20250704-depspmdomain-v1-1-ef2710556e62@baylibre.com/ Regards Guillaume ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-07-07 11:43 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-05-19 8:20 [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3 Guillaume La Roque 2025-06-24 18:42 ` Vignesh Raghavendra 2025-07-01 14:36 ` Matthias Schiffer 2025-07-01 18:57 ` Guillaume La Roque 2025-07-02 7:25 ` Matthias Schiffer 2025-07-02 18:14 ` Guillaume La Roque 2025-07-03 12:28 ` Nishanth Menon 2025-07-07 9:59 ` Guillaume La Roque
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).