From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 306AFC38A2D for ; Wed, 26 Oct 2022 18:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wjjQC8zWoGPhHubwFWOHxcjW80mWBbaLAw8jbdVP5Jo=; b=KzH2TVbZB3RfT4 n+yS7DurF/tQl1NpaSYMSKHgxD3l39TVfloQBEnz/J0RLeIrkqDZkzg7tq/a90OEOSrQLTs7QscL9 jY+If2Cfkk/n1CkxT1ilw5d1Fy3dLt8nhMn9rYStXXW4X0Jfijgh4+viShwvBZCdIcyzZsPU7OKhB 0U6iePUmqzRytGMXJPbxtvppkbzbNRYlW/k01Yl+UtWkLKl5LqbTwiqNQeTqq3d7TXgcQx93Ju7/O Zuqlm/URX/vrEDTPLiBDz8Pa/XVKprAG7VJ0oS+RmU33q9NgoyN3yOEisUzHYYCPjqS+Cs6T/9W0X 7rSrevz8sT1c8zKa5/AQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onl3g-00AXCu-Db; Wed, 26 Oct 2022 18:23:20 +0000 Received: from mail-qv1-xf36.google.com ([2607:f8b0:4864:20::f36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onl3d-00AXBF-Qe for linux-arm-kernel@lists.infradead.org; Wed, 26 Oct 2022 18:23:19 +0000 Received: by mail-qv1-xf36.google.com with SMTP id h10so12264784qvq.7 for ; Wed, 26 Oct 2022 11:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Tg+9/4eCkiPnCycaFmooFOheaPBBecDg4xw3IxvGrY8=; b=ejQEDS8BuqARAzYv3Xubkx7aSNMxMJg9UyPT9PAn+yrjhbIwJ1iuY6J0xJzdWdqB3r rvXDTbSTArKUm7hGivw6XEe8hvjFMYPN9e3ZG/7evEZTaH0BfpBC159AX2XXLBnRwZdi HRq420vW/DSc/WCn1CjAunYphWghDdCyj1Fc3FljER37m1HvU5L0A2IBdUFUEuXfEeCx anPhOcc//RDoWp+ialFp2lp8h2VBNiNmu+IrTIKkcE6ct/PbqqI9W87+ik0vUC3GZ/Bd Z3POlQzZWPV2h0FUqNaxLnE1eE+S6OsvWSQYIAi8TaCqEa7OlJH5/nSfGwyiaujukhZO vFaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Tg+9/4eCkiPnCycaFmooFOheaPBBecDg4xw3IxvGrY8=; b=qgRzMeDonVk+E8rc3yGNB5Ld+42fhNPn82E7zNuV9x4iDAJaMIENnFEDWuzZb68jQr fL/D9E3xrkg+vEJod8iNC/OZiBMz9/mJeLO7DlBukx0aDL0pYUqe5JfP7zD4TNyx+ezd DNUakn/P2+VZMXg56y1YphwFlv+8hLc8TB3FAOBctJBaBcxaKBTlok1tbRxukPgizWTr VF8Czx40bBAFBbUoMdfWVFnkc7P/rTDWnQEPoPS6js1AZqrXo94VatKTbImg1G39LL8y 69g69OdLuMzNt9ALoP9Nib15QJAs/OrwdPC7a56JJnhHyxW20sGNEtJRL/o03VdP3KoF 34yQ== X-Gm-Message-State: ACrzQf2I/OFBBPTaWixBdrPkXtFLWnWmubFjrx+UwMwVBXBA1Jf4qgRO Yx+K9cDUiUWx2tpbByq+wwg= X-Google-Smtp-Source: AMsMyM5OjuJW0rwmarqJHZHRPNNT4+PhxtKPG3yGVNuHc1WPUKJ9jBmSSNSiXwDtiyZH6i65FQbK4A== X-Received: by 2002:a05:6214:2306:b0:473:f77a:85a7 with SMTP id gc6-20020a056214230600b00473f77a85a7mr37185205qvb.106.1666808594005; Wed, 26 Oct 2022 11:23:14 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id v14-20020a05620a0f0e00b006cfc1d827cbsm4429353qkl.9.2022.10.26.11.23.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Oct 2022 11:23:13 -0700 (PDT) Message-ID: Date: Wed, 26 Oct 2022 11:23:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3 6/7] mmc: sdhci_am654: Fix SDHCI_RESET_ALL for CQHCI Content-Language: en-US To: Brian Norris , Adrian Hunter Cc: Ulf Hansson , Shawn Lin , linux-mmc@vger.kernel.org, Al Cooper , Bjorn Andersson , Sowjanya Komatineni , Broadcom internal kernel review list , Sascha Hauer , Konrad Dybcio , NXP Linux Team , Thierry Reding , Fabio Estevam , Michal Simek , linux-kernel@vger.kernel.org, Shawn Guo , Pengutronix Kernel Team , linux-arm-msm@vger.kernel.org, Haibo Chen , Andy Gross , linux-arm-kernel@lists.infradead.org, Jonathan Hunter References: <20221024175501.2265400-1-briannorris@chromium.org> <20221024105229.v3.6.I35ca9d6220ba48304438b992a76647ca8e5b126f@changeid> <5b91c0eb-52aa-8431-c286-81b7feae84ce@intel.com> <6268199c-78ca-8f55-0377-c14bb0299443@gmail.com> <7db0a98e-36c8-afee-5b0d-16b836ac8de0@intel.com> From: Florian Fainelli In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221026_112317_917054_6236F450 X-CRM114-Status: GOOD ( 24.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/26/22 11:18, Brian Norris wrote: > Hi Adrian, > > On Wed, Oct 26, 2022 at 08:36:48AM +0300, Adrian Hunter wrote: >> On 26/10/22 01:26, Brian Norris wrote: >>> On Tue, Oct 25, 2022 at 02:53:46PM -0700, Florian Fainelli wrote: >>>> On 10/25/22 14:45, Brian Norris wrote: >>>>> On Tue, Oct 25, 2022 at 04:10:44PM +0300, Adrian Hunter wrote: >>>>>> On 24/10/22 20:55, Brian Norris wrote: >>>>>>> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c >>>>>>> index 8f1023480e12..6a282c7a221e 100644 >>>>>>> --- a/drivers/mmc/host/sdhci_am654.c >>>>>>> +++ b/drivers/mmc/host/sdhci_am654.c >>>>> >>>>>>> @@ -378,7 +379,7 @@ static void sdhci_am654_reset(struct sdhci_host *host, u8 mask) >>>>>>> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); >>>>>>> struct sdhci_am654_data *sdhci_am654 = sdhci_pltfm_priv(pltfm_host); >>>>>>> - sdhci_reset(host, mask); >>>>>>> + sdhci_and_cqhci_reset(host, mask); >>>>>>> if (sdhci_am654->quirks & SDHCI_AM654_QUIRK_FORCE_CDTEST) { >>>>>>> ctrl = sdhci_readb(host, SDHCI_HOST_CONTROL); >>>>>> >>>>>> What about sdhci_reset in sdhci_am654_ops ? >>>>> >>>>> Oops, I think you caught a big fallacy in some of my patches: I assumed >>>>> there was a single reset() implementation in a given driver (an unwise >>>>> assumption, I realize). I see at least sdhci-brcmstb.c also has several >>>>> variant ops that call sdhci_reset(), and I should probably convert them >>>>> too. >> >> I checked and found only sdhci_am654_ops > > And...how about sdhci_j721e_8bit_ops in that same driver? > >>>> You got it right for sdhci-brcmstb.c because "supports-cqe" which gates the >>>> enabling of CQE can only be found with the "brcm,bcm7216-sdhci" compatible >>>> which implies using brcmstb_reset(). >>> >>> I don't see any in-tree device trees for these chips (which is OK), and >>> that's not what the Documentation/ says, and AFAICT nothing in the >>> driver is limiting other variants from specifying the "supports-cqe" >>> flag in their (out-of-tree) device tree. The closest thing I see is that >>> an *example* in brcm,sdhci-brcmstb.yaml shows "supports-cqe" only on >>> brcm,bcm7216-sdhci -- but an example is not a binding agreement. Am I >>> missing something? >> >> It was mentioned in the patch from the Fixes tag. > > OK, good note. If I don't patch the other seemingly-unaffected variants > in brcmstb, I'll at least update the commit message, since the code > doesn't tell me they're unaffected. You can mention in the commit message that they are unaffected and quote me on that if you feel like this needs to be explicitly said. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel