From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B6E9C3DA6E for ; Mon, 8 Jan 2024 20:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:From:References:Cc:To: Subject:Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=De99JQ8pdAHwGau9VL8Q7Uw3YO3sadzODssvaPdrdRs=; b=L8NNeJVuZf2mHPu4qYJruyGsIG 4059wcEkaDvLUAIXDg6jS4WPeW0GgQxDElI0PtqD3uy/o6NML0h0MZmw3ak0X3qbmk7GI2u5C6yue A0qF69qQsBrJUz3ubFOcnnNsN98oF6dR0ct6OaVaEkXmL3nygIO22mbJdVyyg/disTj7q9ZuWLmjm LsBh2JzTXnJ7mbbTK7YBGqf4aSmY2ELeQNyZF+86IbU/doqeNRyvD/ewNWaKCmxR8GMBoUux83o+I usrQX9y28FQqKE7XyV8TKBHu7YLWpWY31lj8++zRMReIdpNrh2yyxErejmABmt2VBZJsv5k3i2KQ3 RGZH4ULQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rMvs5-0067VH-2d; Mon, 08 Jan 2024 20:05:17 +0000 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rMvs2-0067UA-2B for linux-arm-kernel@lists.infradead.org; Mon, 08 Jan 2024 20:05:16 +0000 Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 408JCQBm017167; Mon, 8 Jan 2024 20:04:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=5Rl5b4kNz1Iyh9nA9DJopv7up/07gSPUzt3uEewWmYY=; b=dBZD3NolpiIPP7X5QVH14LW+AyvPjEULG6z7E1HlO0bD1eUX4arZ25DwebFKA7Kmhd9W Cxr6sZ+bzHPAG+yklQ/bf2bBoBmY2TGXyJE7xiDbioDMaZV6W5jO2BG/MogvGWVQ7Ffo pcTInIAkoE7eby5oLx1GdTfbb4f6XXDrHv9HztC7gbVSJG3tcE4I4gLzQscLsy7J34bq 9WQdlJdJ6bjYnZFTf7ZzdgMtuDtp89WUS3HXPXeno2Qo0J7Kxzf6pXXxbgU3k79o+VJM gbustWlDj1epw3dEMi8II4GaR7jJPZCKpyldgZIybIEaV1swIrJ+1uIlY8UP5pBrcwgP ZA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vgq0f96hs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Jan 2024 20:04:47 +0000 Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 408JkeIt028792; Mon, 8 Jan 2024 20:04:46 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vgq0f96h0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Jan 2024 20:04:46 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 408Jx0Qw000400; Mon, 8 Jan 2024 20:04:44 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3vfh6stj7k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Jan 2024 20:04:44 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 408K4iqR28181140 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 8 Jan 2024 20:04:44 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0151A58054; Mon, 8 Jan 2024 20:04:44 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 78B7958050; Mon, 8 Jan 2024 20:04:42 +0000 (GMT) Received: from [9.61.145.235] (unknown [9.61.145.235]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 8 Jan 2024 20:04:42 +0000 (GMT) Message-ID: Date: Mon, 8 Jan 2024 14:04:42 -0600 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings Content-Language: en-US To: Conor Dooley Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca, keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com, johannes.holland@infineon.com, linux@roeck-us.net, broonie@kernel.org, patrick.rudolph@9elements.com, vincent@vtremblay.dev, peteryin.openbmc@gmail.com, lakshmiy@us.ibm.com, bhelgaas@google.com, naresh.solanki@9elements.com, alexander.stein@ew.tq-group.com, festevam@denx.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-hardening@vger.kernel.org, geissonator@yahoo.com References: <20231212164004.1683589-1-ninad@linux.ibm.com> <20231212164004.1683589-8-ninad@linux.ibm.com> <20231212-avid-grill-dbead068fac8@spud> From: Ninad Palsule In-Reply-To: <20231212-avid-grill-dbead068fac8@spud> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: BcrSbIDUA20AqXyea8yQeaJgquxaRGP_ X-Proofpoint-ORIG-GUID: t6ymHn9VIXq4mcG7cAxPC29lgDsKcsDm X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-08_09,2024-01-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxlogscore=999 mlxscore=0 clxscore=1015 spamscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401080166 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240108_120514_730196_4E3E39EB X-CRM114-Status: GOOD ( 21.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Conor, On 12/12/23 11:15, Conor Dooley wrote: > On Tue, Dec 12, 2023 at 10:40:03AM -0600, Ninad Palsule wrote: >> From: Joel Stanley >> >> The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface. >> >> https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/ >> >> Add a compatible string for it, and the generic compatible. >> >> OpenBMC-Staging-Count: 3 > Delete this from every patch that it appears from. Removed. > >> Signed-off-by: Joel Stanley >> Acked-by: Jarkko Sakkinen >> Link: https://lore.kernel.org/r/20220928043957.2636877-4-joel@jms.id.au >> Signed-off-by: Ninad Palsule >> --- >> drivers/char/tpm/tpm_tis_i2c.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c >> index a897402cc36a..9511c0d50185 100644 >> --- a/drivers/char/tpm/tpm_tis_i2c.c >> +++ b/drivers/char/tpm/tpm_tis_i2c.c >> @@ -383,6 +383,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id); >> #ifdef CONFIG_OF >> static const struct of_device_id of_tis_i2c_match[] = { >> { .compatible = "infineon,slb9673", }, >> + { .compatible = "nuvoton,npct75x", }, >> + { .compatible = "tcg,tpm-tis-i2c", }, > What's the point of the generic compatible if you are adding the device > specific ones to the driver anyway? > > Thanks, > Conor. I have removed this commit from this patchset and send it as a separate patch. Regards, Ninad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel