From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28893C0015E for ; Tue, 15 Aug 2023 15:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=klLA0sLbzibrFEwWs4pVHVLCEGuF922idRzT9yk6zJs=; b=hwULBEXVkCH9D9 XVvyZTezUm/DtDbwY4dTLFK61nZIA2VPBiFZrQhTCjKQ1Gfxh6O4v1xPzpiQCaKwSnSZyjWu6L01R N0Z9KZz74QRJYU8TBLkKaqYSy32tKllwKbGLclVRvKfXbvDzx+57IFpE/oPGE5M9qIzPq4cTkwV05 dp5xih112rY3gQQRAea/MHa96RU7QI7/hgWypcwrOfM1CLrdzxyNwm17yQYQWCprWM5/he57Op5jv BwoMUC4D4LCFnrTc8gMxEbf0sE3dlUhBCnDHNT4iMAifE2wrvkjvQP1apclKop4x5XzfyvU21/7Es o8VeWcyCmAtsbk2zJ2TA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVvoS-001pxm-1S; Tue, 15 Aug 2023 15:18:28 +0000 Received: from out-24.mta1.migadu.com ([95.215.58.24]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVvoO-001pwY-08 for linux-arm-kernel@lists.infradead.org; Tue, 15 Aug 2023 15:18:27 +0000 Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1692112700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5jkRrsW9ZohDgZxdapSfROnd5WC/t+pIz3Z7RYOCEpk=; b=c5FEo+pNIRIQR7Ia0XE3msfztl33UetjSbeMLnJyhUSRhDUCP2kxoRpHGyDdwiMOcjW43J qoHzwqxkoMhZFA8/CC1eUtKOuhQ/885vlEtdkrFqcVDLMYBer7/m3NNBBM1aFld7cbsGE7 w8ziAMKjx3NN87XuwGAI6Vrfj8zshdw= Date: Tue, 15 Aug 2023 16:18:16 +0100 MIME-Version: 1.0 Subject: Re: [PATCH net-next v4 4/9] dpll: netlink: Add DPLL framework base functions Content-Language: en-US To: Jakub Kicinski Cc: Jiri Pirko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org, Jiri Pirko References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-5-vadim.fedorenko@linux.dev> <20230814202441.349586b4@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20230814202441.349586b4@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230815_081824_504213_9873E0C3 X-CRM114-Status: UNSURE ( 9.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/08/2023 04:24, Jakub Kicinski wrote: > On Fri, 11 Aug 2023 21:03:35 +0100 Vadim Fedorenko wrote: >> + xa_for_each(&pin->dpll_refs, i, ref) { >> + const struct dpll_pin_ops *ops = dpll_pin_ops(ref); >> + struct dpll_device *dpll = ref->dpll; >> + >> + if (!ops->frequency_set) >> + return -EOPNOTSUPP; >> + ret = ops->frequency_set(pin, dpll_pin_on_dpll_priv(dpll, pin), >> + dpll, dpll_priv(dpll), freq, extack); >> + if (ret) >> + return ret; >> + __dpll_pin_change_ntf(pin); >> + } > > only one freq is reported in get, AFAICT, so why send a notification > after each ref is updated? The pin can be technically connected to several DPLLs and app may watch for the specific DPLL messages only. We would like to inform all users on any DPLL which has this pin connected to. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel