From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37828EB64D7 for ; Wed, 28 Jun 2023 15:21:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OCsrVT6v+1DVPxe5iP45vcf/OGIPywVEuGgSTvjr7zM=; b=ahV2GP9vTTMFXI VS+b3Ld24FKDjAWo3EX3I2hTwqSRTJ7G1lzzTNPbiLvlUoJEwmcsKZbY7oNKXsrf03fvtw2s+cOly rT5aRdtzLmmIc4o+T476QPvBD80VEVNnrKjHbBsn+3mQFIb7O73NU7MWUeTEQKFRz/94pRXE5PsM1 rbVysQ2mb6GTrWX5FMDXAw+YgDVfOLCSK185LGL4O5w2IFc1TdZBrBk7fI9zlA03ZY3868JG86nGn LsjGJ6kFrkPdI1KVCNmL8Yx9LdenDqnSea28TXiaZQwEs/wbzGQsAeBrDh7+czHunqQFS69pjUDdV Uyv5fbz+E5hWTOHfOSPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qEWyO-00FyXZ-31; Wed, 28 Jun 2023 15:20:48 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qEWyJ-00FyW3-0L for linux-arm-kernel@lists.infradead.org; Wed, 28 Jun 2023 15:20:47 +0000 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2b698937f85so68748381fa.2 for ; Wed, 28 Jun 2023 08:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687965640; x=1690557640; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=O1zwqe2L/ZqF+4ydv1LkIfmqL/mIwvO8jVnOWDtDmHc=; b=nTxbvr+SBUiWzq9OAQX07rXCVvs2/Lbd4/KmFokAqczlvC+YDKyj96ycYBeELJHLbE ZaFgdtiUoZtw3RX8I1WbSeS7pmYLkLH3BwTfE4SbvtJjFJIc6/l00moGy0eNLiRpqtVW /qTk9Rsc7SV11Ua/yyvVfI9vP/ZsTZqH3cjehWmbPMPTeswMLb5fnMjwWCYZm9Pjs63F TUFXM0QSSn0s7eYwyZMHVM/ybdj4OhXHYh8Pjy6eYUk0Q/vMKH+aQrhfvye8VQEAL3k9 7IEZqJNJ0elQNNtWnkKY7iTiqBjCgaeV8NYUO6y0ya4Bi6rb1yHm2HJnv5u2YKSTL925 K17Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687965640; x=1690557640; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O1zwqe2L/ZqF+4ydv1LkIfmqL/mIwvO8jVnOWDtDmHc=; b=TtDfw4o9qg9SxA0r/OZtHBeW6rKbILcj/hd9DDd9OMlXdBDzz5jTRJakF6Z08rF75i IsPKOOfryERzj6MDer/2CL7lZbJy30OMsxxQH0EluVS9BAzJmsRqY4EH7SeFBUF+2Gci +kPSfr6AIurxOOmpW7LjMAq0AwFN4b838ugZrG403ICE3DiY26ZZgI/JHkH5kprG4EKO NIf2jeWQ1lCGGHD48byPwmtjgF3XVKQM5c+F3V1C3N0WjMPvXutQ8GlHp8AHwVs7o6TY NW3VcVh+rrjDda4OjnFDPDSFaEymDAM7ypVbUwKqrr4uGK5QEq05FE5VyShEZY7BNxeH aDQw== X-Gm-Message-State: AC+VfDwDf2C4T56xtiOMkXjJPp78hAo/QkUpd6IZB8/9C6LOn/PeS7yR 7+vlHVLmtFzjUsP5oVVLYiAR4A== X-Google-Smtp-Source: ACHHUZ6JfrUGGy1kQpxW6rclkKMCtjKkk1FPM6l2RRR6pdSpC5gvG8oz7MM9jhGyN//xPLtECFBahA== X-Received: by 2002:a2e:8089:0:b0:2b6:b88b:6689 with SMTP id i9-20020a2e8089000000b002b6b88b6689mr2940268ljg.22.1687965640187; Wed, 28 Jun 2023 08:20:40 -0700 (PDT) Received: from [192.168.1.101] (abyk82.neoplus.adsl.tpnet.pl. [83.9.30.82]) by smtp.gmail.com with ESMTPSA id x17-20020a2e8811000000b002b34f9cfc7asm2271183ljh.90.2023.06.28.08.20.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jun 2023 08:20:39 -0700 (PDT) Message-ID: Date: Wed, 28 Jun 2023 17:20:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4 19/21] firmware: scm: Modify only the download bits in TCSR register Content-Language: en-US To: Mukesh Ojha , corbet@lwn.net, agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com, mathieu.poirier@linaro.org, catalin.marinas@arm.com, will@kernel.org, linus.walleij@linaro.org, andy.shevchenko@gmail.com Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-hardening@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org References: <1687955688-20809-1-git-send-email-quic_mojha@quicinc.com> <1687955688-20809-20-git-send-email-quic_mojha@quicinc.com> From: Konrad Dybcio In-Reply-To: <1687955688-20809-20-git-send-email-quic_mojha@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230628_082043_215511_D37CC13B X-CRM114-Status: GOOD ( 20.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28.06.2023 14:34, Mukesh Ojha wrote: > CrashDump collection is based on the DLOAD bit of TCSR register. > To retain other bits, we read the register and modify only the > DLOAD bit as the other bits have their own significance. > > Co-developed-by: Poovendhan Selvaraj > Signed-off-by: Mukesh Ojha > --- > drivers/firmware/qcom_scm.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > index 104d86e49b97..a9ff77d16c42 100644 > --- a/drivers/firmware/qcom_scm.c > +++ b/drivers/firmware/qcom_scm.c > @@ -30,6 +30,11 @@ module_param(download_mode, bool, 0); > #define SCM_HAS_IFACE_CLK BIT(1) > #define SCM_HAS_BUS_CLK BIT(2) > > +#define QCOM_DOWNLOAD_FULLDUMP 0x1 > +#define QCOM_DOWNLOAD_NODUMP 0x0 > +#define QCOM_DOWNLOAD_MODE_SHIFT 4 > +#define QCOM_DOWNLOAD_MODE_MASK 0x30 GENMASK and then FIELD_PREP below? > + > struct qcom_scm { > struct device *dev; > struct clk *core_clk; > @@ -440,6 +445,7 @@ static int __qcom_scm_set_dload_mode(struct device *dev, bool enable) > static void qcom_scm_set_download_mode(bool enable) > { > bool avail; > + int val; What's wrong with initializing it in the same line as ret? > int ret = 0; > > avail = __qcom_scm_is_call_available(__scm->dev, > @@ -448,8 +454,10 @@ static void qcom_scm_set_download_mode(bool enable) > if (avail) { > ret = __qcom_scm_set_dload_mode(__scm->dev, enable); > } else if (__scm->dload_mode_addr) { > - ret = qcom_scm_io_writel(__scm->dload_mode_addr, > - enable ? QCOM_SCM_BOOT_SET_DLOAD_MODE : 0); > + val = (enable ? QCOM_DOWNLOAD_FULLDUMP : QCOM_DOWNLOAD_NODUMP); unnecessary braces Konrad > + val <<= QCOM_DOWNLOAD_MODE_SHIFT; > + ret = qcom_scm_io_update_field(__scm->dload_mode_addr, > + QCOM_DOWNLOAD_MODE_MASK, val); > } else { > dev_err(__scm->dev, > "No available mechanism for setting download mode\n"); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel