From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B36B2E71080 for ; Sat, 7 Sep 2024 13:37:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YUTavBQ5qrHlQPm4dvfhw3yJpsNd8pyOFUFPgqrOJVE=; b=bFgspcsqE3aKNMQmMYbyqihn8O l44kgznUwAQzx5Agy5zKhFSNS4jLhTLxJFfqzlusiYgwPiQz6lja2qkvIOpehms/u7naAtxO2Worv iuqhZ3YoFRerb6OBHKUqfZRgFbPnpnyF6h9MPSmEoK8utnO3y5F5CnLHJHJ0r6VxZf93Eapuwll/n vLxqDKp3HMo7420b0QivItG1Kmc/BGYOskLPoGYg5rEvF0WiDzL1FopqK/569uj7Lol80AjD6i+q4 s5deVyVjEEYLrxecn1NWftMdfCud3864OiEqNvGKTqADGNbPNnv6cZrzBy+FSlwl7aLBVzIxSaojY ArJq/FqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smvdI-0000000F5CV-12wS; Sat, 07 Sep 2024 13:37:44 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smvcJ-0000000F56e-1HCX for linux-arm-kernel@lists.infradead.org; Sat, 07 Sep 2024 13:36:44 +0000 Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-2d8815ef6d2so2210229a91.0 for ; Sat, 07 Sep 2024 06:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725716202; x=1726321002; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YUTavBQ5qrHlQPm4dvfhw3yJpsNd8pyOFUFPgqrOJVE=; b=OZWvFl+s1/i5t0YU1yaOa9nXPYzVlSoN9E57xXTCs1FRrwfiRBIdQ0JvE2pSOpryG6 esE9vqpd0DmxzvZ6Rn53gk+pOIL7dk+PgS8jMKouhyU/0/ZVqV6UxP2mG9GL97ANBOqE 5UUnV0VZz0VtmICMoSpXUhtQKG4sgp+XAbpZdGTTKAp20aKnJH/MXOtCP+RvqfVy5YPe aeDrtMkY6yT/nVqmuZsutmpXVVf8V9FN0dR1UHXfGZRaRZJt/YShi4PjEkNOFinuawKK dz+PR+YM7lTmPyUSqHWE+Pdtqzf7EcNm60Lc78SwTNlh4ARcqo7srGNlnrgmi5ZRDQko ArZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725716202; x=1726321002; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YUTavBQ5qrHlQPm4dvfhw3yJpsNd8pyOFUFPgqrOJVE=; b=f4JCmkUG8op90LUvDy5I3Glx8gErGTahUIFFrAz1DGTdimC0xid9cZQ88HF8eLTAWg XTmATzb16OXYq160Xjv1sFU89yMtowS/akJU4mX+MxzIDUJ6i5LX9tiKtnTi7rVW5TMP bHrpg1nbp388ZjN8UsFKh8DZdCwiqjorIy3N0Nk+5+p5ZTfCfy8XccPdmqmWq+LbKMZb ktANseecwyFkC4E/QcYypXKrV+L5+Mh7Vda6kI2AmXlcdkMezCpOsQ92kbKzMRw/gwGW TlKZH5FVgfVBqa/hmCebPDUVQlVIOKQnJdrVpPrSkCWC1qqYdO3dVR52Ed2Aa4mCP28U Zblg== X-Forwarded-Encrypted: i=1; AJvYcCU6wGaQVRrTp2udI9T88pnRlPd6CEcufukyV2JdEeKU6bV4LAQKMTJqB9rBM9bPgGYEPd+UiwMbRDI3qTu9YqEB@lists.infradead.org X-Gm-Message-State: AOJu0Yyz5xlTKENcEfWWhk0jHRybN9RDMcLO8fZNFxQWcXxR90iEkFcu DVApWhMuUAD6rsrJvD8vHJ5qh5qGJ3DiPW893oZIJvFUsdysZqS5 X-Google-Smtp-Source: AGHT+IHDd6iQwUYAcG/97d9xepIXpXTiP9NBsHNofcF74jxr+3FjbR3kilNRA1s6jBVgx9qHN1vkwg== X-Received: by 2002:a17:90b:4b4a:b0:2d8:d098:4f31 with SMTP id 98e67ed59e1d1-2dafcf1c7f5mr2670367a91.17.1725716201718; Sat, 07 Sep 2024 06:36:41 -0700 (PDT) Received: from [192.168.0.122] ([59.188.211.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2db04136b71sm1251865a91.12.2024.09.07.06.36.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Sep 2024 06:36:41 -0700 (PDT) Message-ID: Date: Sat, 7 Sep 2024 21:36:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] tty: serial: samsung: Fix serial rx on Apple A7-A9 SoCs Content-Language: en-MW To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: asahi@lists.linux.dev References: <20240907111431.2970-1-towinchenmi@gmail.com> <20240907111431.2970-3-towinchenmi@gmail.com> <3596ef82-b2a4-40a0-8a66-575e26c386d9@kernel.org> From: Nick Chan In-Reply-To: <3596ef82-b2a4-40a0-8a66-575e26c386d9@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240907_063643_382959_918F76C3 X-CRM114-Status: GOOD ( 10.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/9/2024 20:55, Krzysztof Kozlowski wrote: > On 07/09/2024 13:06, Nick Chan wrote: >> >> diff --git a/include/linux/serial_s3c.h b/include/linux/serial_s3c.h >> index 1672cf0810ef..849d502d348d 100644 >> --- a/include/linux/serial_s3c.h >> +++ b/include/linux/serial_s3c.h >> @@ -246,24 +246,28 @@ >> S5PV210_UFCON_TXTRIG4 | \ >> S5PV210_UFCON_RXTRIG4) >> >> -#define APPLE_S5L_UCON_RXTO_ENA 9 >> -#define APPLE_S5L_UCON_RXTHRESH_ENA 12 >> -#define APPLE_S5L_UCON_TXTHRESH_ENA 13 >> -#define APPLE_S5L_UCON_RXTO_ENA_MSK (1 << APPLE_S5L_UCON_RXTO_ENA) >> -#define APPLE_S5L_UCON_RXTHRESH_ENA_MSK (1 << APPLE_S5L_UCON_RXTHRESH_ENA) >> -#define APPLE_S5L_UCON_TXTHRESH_ENA_MSK (1 << APPLE_S5L_UCON_TXTHRESH_ENA) >> +#define APPLE_S5L_UCON_RXTO_ENA 9 >> +#define APPLE_S5L_UCON_RXTO_LEGACY_ENA 11 >> +#define APPLE_S5L_UCON_RXTHRESH_ENA 12 >> +#define APPLE_S5L_UCON_TXTHRESH_ENA 13 >> +#define APPLE_S5L_UCON_RXTO_ENA_MSK (1 << APPLE_S5L_UCON_RXTO_ENA) >> +#define APPLE_S5L_UCON_RXTO_LEGACY_ENA_MSK (1 << APPLE_S5L_UCON_RXTO_LEGACY_ENA) >> +#define APPLE_S5L_UCON_RXTHRESH_ENA_MSK (1 << APPLE_S5L_UCON_RXTHRESH_ENA) >> +#define APPLE_S5L_UCON_TXTHRESH_ENA_MSK (1 << APPLE_S5L_UCON_TXTHRESH_ENA) > > Use BIT() for new entries. You can also convert the earlier defines to > BIT() in separate patches. Acked. Version 2 will change APPLE_S5L_* entries to use BIT(), and then add the new entries with BIT(). > >> > > Best regards, > Krzysztof > Nick Chan