From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexey Romanov <avromanov@sberdevices.ru>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
neil.armstrong@linaro.org, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
linus.walleij@linaro.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@sberdevices.ru
Subject: Re: [PATCH v1 3/3] arch/arm: dts: introduce meson-a1 device tree
Date: Thu, 23 Feb 2023 10:09:25 +0100 [thread overview]
Message-ID: <d5d9a1fe-2f66-66e3-d88a-76a12f2ec55e@linaro.org> (raw)
In-Reply-To: <bc514ba7-406e-bca8-4d3a-4f8997cd3241@linaro.org>
On 23/02/2023 10:08, Krzysztof Kozlowski wrote:
> On 22/02/2023 12:50, Alexey Romanov wrote:
>> Add basic support for the 32-bit Amlogic A1. This device tree
>
> Use subject prefixes matching the subsystem (which you can get for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching).
>
>> describes following compontents: CPU, GIC, IRQ, Timer, UART,
>> PIN controller. It's capable of booting up into
>> the serial console.
>>
>> This is based on arm64 version of meson-a1.dtsi.
>>
>> Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
>> ---
>> arch/arm/boot/dts/meson-a1.dtsi | 151 ++++++++++++++++++++++++++++++++
>
> There is such file and there is such DTS/hardware support. I don't see
> any reason why entire DTSI should be duplicated. What's more, your
> commit does not explain it - does not justify duplication.
One more comment - I think you just added dead code. It's
uncompilable/untestable. Otherwise, please share how to build this DTSI
without DTS.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-23 9:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 11:50 [PATCH v1 0/3] Meson A1 32-bit support Alexey Romanov
2023-02-22 11:50 ` [PATCH v1 1/3] meson: pinctrl: use CONFIG_PINCTRL_A1 with CONFIG_ARM Alexey Romanov
2023-03-06 13:45 ` Linus Walleij
2023-03-06 13:49 ` neil.armstrong
2023-03-06 13:52 ` Linus Walleij
2023-02-22 11:50 ` [PATCH v1 2/3] firmware: meson: use CONFIG_MESON_SM " Alexey Romanov
2023-02-22 11:50 ` [PATCH v1 3/3] arch/arm: dts: introduce meson-a1 device tree Alexey Romanov
2023-02-23 9:08 ` Krzysztof Kozlowski
2023-02-23 9:09 ` Krzysztof Kozlowski [this message]
2023-02-27 14:39 ` Dmitry Rokosov
2023-02-27 14:41 ` Krzysztof Kozlowski
2023-02-27 8:15 ` [PATCH v1 0/3] Meson A1 32-bit support neil.armstrong
2023-02-27 14:28 ` Dmitry Rokosov
2023-02-27 14:46 ` neil.armstrong
2023-02-27 16:01 ` Dmitry Rokosov
2023-02-27 14:58 ` Arnd Bergmann
2023-02-27 15:51 ` Dmitry Rokosov
2023-02-27 16:15 ` Arnd Bergmann
2023-02-27 16:37 ` Dmitry Rokosov
2023-02-27 16:38 ` Neil Armstrong
2023-02-27 16:50 ` Dmitry Rokosov
2023-02-27 18:19 ` Arnd Bergmann
2023-02-28 8:49 ` Dmitry Rokosov
2023-03-09 21:52 ` Kevin Hilman
2023-03-10 15:20 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5d9a1fe-2f66-66e3-d88a-76a12f2ec55e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=avromanov@sberdevices.ru \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).