From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39B55C47094 for ; Mon, 7 Jun 2021 13:03:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02C1160C41 for ; Mon, 7 Jun 2021 13:03:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02C1160C41 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3LHgSQZSYhoS6d99stJwsE3UFYFMUZEE1vVZId874u0=; b=UQfYE/mopwrJmf vK1bDgJKT8TIUQHSH7WtX4W2J+n6E0YOLx8gmVSbvonSSaYYEtHZqWDcyQpG7aEhKf8eDcAtEV1Xz J4UlD3EStI8XAkrykkKwxuOOloD05+sqk0mlVzpmp8uL6XN5H2i/+14v2oiyqOdM0YtvZTJmrGJ3w W+aKNkxPIdHrfNP4KULa1QK9EbhXGGOFxzuSyMao59HHRKIKP75mhNdbkXqqysqpo2260ip5UsNUq ygjJl0cJBt/wXdYa+i/6NBrGIX45M52p74Yykf14xKRn9G6rKUUphg4U8uIRMNI7nEvmjfA24smRr ckM9EScGp5+VLxrAu6NA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqEsK-003etX-5c; Mon, 07 Jun 2021 13:01:05 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqEea-003ajw-El for linux-arm-kernel@lists.infradead.org; Mon, 07 Jun 2021 12:46:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1623070012; x=1654606012; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=FIZFB2bYQ1/lIPincdEySVOxkMfoPs9wW+HB5gfqoBA=; b=nEJSwWqDueqgsMslyv8Jc2tVRkfist5U2XW6190dre2YtFGL8FWZUe0J 8ZazH11U3vQ4NWBk2aC955ZfTwCrBjy/dB/RJAS4pQCiRD6I8008jBVf0 GOsH7soM6NnScz1p1F1qSPMl9E5gbuWtSOuY4h3J0XZ7fopxQozshgXF0 q0egrbHo8UFCniBdQb+Rq3gl03ggg6dud5vP/wl01JAgf0dJQKXNd3k26 pKglFbi6ctHDtu0zyBj+b+z7cVjDn/OcE3ywn+R/1qvHKkllmVzZzzdyT 8xpRTNlwhPVQ0/HvHMAjDIRJuF6EZpg8srnyvlSp2CJcDiLyHt11jJq1w w==; IronPort-SDR: pSLu3m6JBVRYdtAo9Ni0/Kun1aTgxO+YivEENshwypXWwXDnQelbTY9twd7KGUZsQorHts3tlN Dn0liR6QhnquCyvIQggRjjXLj+RsDBIyihE2agehB1TsiqNJ25jumgPzxo9C7QD07yr4abK1sZ mnYKVz0RLa/D+sHz/A2fli0WEM1f/xtmhx88io2L1BRrJlJZlo1wXN4CMDFZXqzkqDqTDPHvTs TKmT1flZ5k/HOGFHnnpfSRtw2vfnQ5DPY/OSngkiXDb6FWM5tyJLLSxagVEhLVXAqdfLC35dyM qqA= X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="120430542" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 07 Jun 2021 05:46:48 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 7 Jun 2021 05:46:48 -0700 Received: from den-her-m31857h.microchip.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Mon, 7 Jun 2021 05:46:44 -0700 Message-ID: Subject: Re: [PATCH net-next v3 04/10] net: sparx5: add port module support From: Steen Hegelund To: "Russell King (Oracle)" CC: "David S. Miller" , Jakub Kicinski , Andrew Lunn , Microchip Linux Driver Support , Alexandre Belloni , Madalin Bucur , Mark Einon , Masahiro Yamada , Arnd Bergmann , Philipp Zabel , "Simon Horman" , , , , Bjarni Jonasson , Lars Povlsen Date: Mon, 7 Jun 2021 14:46:44 +0200 In-Reply-To: <20210607092136.GA22278@shell.armlinux.org.uk> References: <20210604085600.3014532-1-steen.hegelund@microchip.com> <20210604085600.3014532-5-steen.hegelund@microchip.com> <20210607092136.GA22278@shell.armlinux.org.uk> User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210607_054652_629228_E9CEB184 X-CRM114-Status: GOOD ( 31.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russell, Thanks for your comments. On Mon, 2021-06-07 at 10:21 +0100, Russell King (Oracle) wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Fri, Jun 04, 2021 at 10:55:54AM +0200, Steen Hegelund wrote: > > This add configuration of the Sparx5 port module instances. > > > > Sparx5 has in total 65 logical ports (denoted D0 to D64) and 33 > > physical SerDes connections (S0 to S32). The 65th port (D64) is fixed > > allocated to SerDes0 (S0). The remaining 64 ports can in various > > multiplexing scenarios be connected to the remaining 32 SerDes using > > QSGMII, or USGMII or USXGMII extenders. 32 of the ports can have a 1:1 > > mapping to the 32 SerDes. > > > > Some additional ports (D65 to D69) are internal to the device and do not > > connect to port modules or SerDes macros. For example, internal ports are > > used for frame injection and extraction to the CPU queues. > > > > The 65 logical ports are split up into the following blocks. > > > > - 13 x 5G ports (D0-D11, D64) > > - 32 x 2G5 ports (D16-D47) > > - 12 x 10G ports (D12-D15, D48-D55) > > - 8 x 25G ports (D56-D63) > > > > Each logical port supports different line speeds, and depending on the > > speeds supported, different port modules (MAC+PCS) are needed. A port > > supporting 5 Gbps, 10 Gbps, or 25 Gbps as maximum line speed, will have a > > DEV5G, DEV10G, or DEV25G module to support the 5 Gbps, 10 Gbps (incl 5 > > Gbps), or 25 Gbps (including 10 Gbps and 5 Gbps) speeds. As well as, it > > will have a shadow DEV2G5 port module to support the lower speeds > > (10/100/1000/2500Mbps). When a port needs to operate at lower speed and the > > shadow DEV2G5 needs to be connected to its corresponding SerDes > > > > Not all interface modes are supported in this series, but will be added at > > a later stage. > > It looks to me like the phylink code in your patch series is based on > an older version of phylink and hasn't been updated for the split PCS > support - you seem to be munging the PCS parts in with the MAC > callbacks. If so, please update to the modern way of dealing with this. > > If that isn't the case, please explain why you are not using the split > PCS support. I need to be able to let the user set the speed to get the link up. So far I have only been able to get the user configured speeds via the mac_ops, but if this is also possible via the pcs_ops, there should not anything preventing me from using these ops instead. Will the pcs_ops also support this? > > Thanks. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! -- BR Steen -=-=-=-=-=-=-=-=-=-=-=-=-=-= steen.hegelund@microchip.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel