From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A34EC52D7C for ; Mon, 12 Aug 2024 21:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l/Cg2+ikcC9Q5RAxiBZox1zk3Cb/v3239tm0JRBaSzs=; b=rusjB6yqTQ31RyfmSZ4ONyCnTD tVz1WZ8W0itmE6Bmj5aTtg2VqW/icjBMK++ZWEV4G6iw2t/n1kqAliltamuNlMk3vKEO8Atv9zzvV 8b6NM7jE0+QXUlaNVfkjAx8XwOTHEOO2JrNkCCh1WyJctDzT/b4tC4zsKncaMc53nK9zjpDuUhaLA 34ICxbhMPOC/POn2oQZaAg4TO+Eow//RkYcedP2VpeH2TPuknnPME6Tya+KS8FqDeoR+mvGSZdBe2 ncwfzJrLU9GmYp4XhpLK7mp+40S3GqJJiiFO8eFOOFx7JO4UphreGQAykGeQRnOnbCx6vy5GRsSxu b4XcNeAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdcT0-00000001bi4-0Pb8; Mon, 12 Aug 2024 21:20:38 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdcSP-00000001bf9-3tnz for linux-arm-kernel@bombadil.infradead.org; Mon, 12 Aug 2024 21:20:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=l/Cg2+ikcC9Q5RAxiBZox1zk3Cb/v3239tm0JRBaSzs=; b=hgVfrRR0qZ6GS9vQRWhFhzTUL2 e5LXM23c8MMehnI0sP+YWFyzkGuZ5R4bCmTAkTLiBhQNRwmwMqK6a/cgSe89YJf4mhoLtM0rrr68S AYq6JTTDqflbeLEwodAb3HExjq1kXDGevgqLmsl9HeyMzJJUe9haspKd0A5HC6b6EMgCo81AMaaYE BbZUX2pDwsGZZ1whFXDjuYi1BKMatNFw/ORyfNXr5jVwtmTEL+BGtvOcOWB/pCJBBiAFCcDJ0Gz3g 8ZMwyXBz7q8NvUFnRrgO97dPoesT7tx7I3P1NDf6RoUdQxF9ySuSYpn/GsJA6yU8oHEvD1/GrcJZG X2BHTMNQ==; Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdcSG-00000007eFm-47D8 for linux-arm-kernel@lists.infradead.org; Mon, 12 Aug 2024 21:19:57 +0000 Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-70d1d6369acso3915437b3a.0 for ; Mon, 12 Aug 2024 14:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1723497587; x=1724102387; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=l/Cg2+ikcC9Q5RAxiBZox1zk3Cb/v3239tm0JRBaSzs=; b=SGmrfDugLGZnYdWHzUTs7U7oH+IBhshx2nMAyzA7rv/EmXKk9ctmUCbMDSrrW3UpMp SwCid3R48zofGsbQU5OnU21CcN+IMhVj38z33IHVYxceKUW6BxInSmgfu6yd9dDAKRb3 u4aZ0EC197sWs776F95+5zRxdzhIhyMEiaSBY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723497587; x=1724102387; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l/Cg2+ikcC9Q5RAxiBZox1zk3Cb/v3239tm0JRBaSzs=; b=K/HesQfL+khS8BWT94qkfPKjil7xtOqfkclTOYgKQcc0uOjGeDZWWVUzfrpS+6gFpn kTXEiJ1hQQv42nR/OSFeKBuQgtSpkN+1/WlxHoAxSG7tWLuFWXJWVEJ/NmdB8l7UbiHH UAkSS2nVX90foMeXqS8ezV579i2oLR6U6CqbsV7YD7KFdkbMkjXY3e+uGtJHkOEPqnDG xUnMS2AyTd1zBbH29jaN/hSMNVkt8br/Z9CvquqguzgfOZmwOQObqV91PehqxTX25g0G 7soKHpyrwdc5g0rJqhMLc26WbUBnLKDZ4lVDO0yV6CjZ+F2BUhizudBsc86+Q02DRnH4 3K8Q== X-Gm-Message-State: AOJu0Yy73Mvkofvomus9mZGHzetlq+SYstyHXU0fZDuLxfEjifftNrrG l1MWuzKE4NUx9FB+jfV0tsqLbM8WJQSNhpG5rgKfPFH5R/0TysMfP6pEN8ml5Q== X-Google-Smtp-Source: AGHT+IGzNQT8Q8hoOKaFCVtSHp0qdnqRkcgtiAtdIxBD1A683Mbm8MdDmT6Ntz3HXPas33Ou3DvOYg== X-Received: by 2002:a05:6a21:7747:b0:1c4:77ea:601a with SMTP id adf61e73a8af0-1c8da1fb034mr1403306637.15.1723497587164; Mon, 12 Aug 2024 14:19:47 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7c6979edc3bsm136400a12.36.2024.08.12.14.19.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Aug 2024 14:19:46 -0700 (PDT) Message-ID: Date: Mon, 12 Aug 2024 14:19:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] firmware: arm_scmi: Support 'reg-io-width' property for shared memory To: Cristian Marussi Cc: linux-arm-kernel@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sudeep Holla , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , arm-scmi@vger.kernel.org, james.quinlan@broadcom.com, justin.chen@broadcom.com, kapil.hali@broadcom.com, bcm-kernel-feedback-list@broadcom.com References: <20240810214621.14417-1-florian.fainelli@broadcom.com> <20240810214621.14417-3-florian.fainelli@broadcom.com> <40cd771e-5dab-498b-b77d-e0de4281fce9@broadcom.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240812_221954_454609_DBFB376C X-CRM114-Status: GOOD ( 16.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/12/24 11:01, Cristian Marussi wrote: >> OK, I will think about more about what needs to be done here, but in >> general, do you agree this is an acceptable approach to support "odd" SRAMs? > > Yes, but one question comes up in my mind upfront (maybe similar to Rob remarks): > is this not, in theory, something general that should be somehow addressed transparently > by the core SRAM code when dealing with such odd SRAM, since SCMI is > indeed only onne of the possible users ? > (not saying to do this in this series that deals with SCMI related issues....) > > Anyway, I'll have a though too about the SCMI core transport possible changes that I > mentiond above, soon-ish... (I tried something already today, hoping to solve it quickly > ...with poor results :D) What do you think about keeping the status quo with the scmi_shared_mem singleton and instead introduce a per-shmem scmi_shared_mem_io_ops which would contain function pointers to read from/write to the shared memory? This would keep the scmi_shared_mem read-only and a singleton and the transport would be responsible for storing and passing that set of function pointers around, post setup_iomap() where the determination would have been done. -- Florian