From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2A62C433FE for ; Wed, 16 Nov 2022 12:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zYP0QVO6DHDq9Bme9QmUxkCVDDhaSwhNDR/DYbquASQ=; b=aX0PH6rf7VF0OW ZIHgUVmXh50rogmgjtw77utTSWbbM8YDkz6F0YYZ9M4yX1qW4SOBVm2IB/HqX3mp4Xf8E1lqI1c9H fkK2dEaBpptxTwUHPR3tpWJjoE9zrHpqvm5niHn6xcZQ+fMQgFC+Is21ZvLvhNeeC6qEF7wlX50S0 dnChSORxW2JMW8cmqUlZ/P3jq9oGs72WNMThcQIzGpanu8hSjctoezDgl5ozsQxGvSVGWLIEHsjZq o/ZR9Mw4Pc47PUW6Vv3kenDVroA2vrjeSgpuoriBOchCFGnKfsUQX1qoyPtARUKJFFvcrjeqHNz42 Mkl4ikUuDza0xYeKJf+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovHh7-003U0p-Od; Wed, 16 Nov 2022 12:39:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovHgf-003Tbu-FF for linux-arm-kernel@lists.infradead.org; Wed, 16 Nov 2022 12:38:43 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 01AD4150C; Wed, 16 Nov 2022 04:38:41 -0800 (PST) Received: from [10.57.70.190] (unknown [10.57.70.190]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2AD043F663; Wed, 16 Nov 2022 04:38:31 -0800 (PST) Message-ID: Date: Wed, 16 Nov 2022 12:38:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] arm64: dts: fsd: Change the reg properties from 64-bit to 32-bit Content-Language: en-GB To: Arnd Bergmann , Vivek Yadav , rcsekar@samsung.com, krzysztof.kozlowski+dt@linaro.org, Wolfgang Grandegger , Marc Kleine-Budde , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , pankaj.dubey@samsung.com, ravi.patel@samsung.com, Alim Akhtar , linux-fsd@tesla.com, Rob Herring Cc: linux-can@vger.kernel.org, Netdev , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, aswani.reddy@samsung.com, sriranjani.p@samsung.com, ajaykumar.rs@samsung.com References: <20221116091247.52388-1-vivek.2311@samsung.com> <37d42235-1960-4001-9be9-20a85de54730@app.fastmail.com> From: Robin Murphy In-Reply-To: <37d42235-1960-4001-9be9-20a85de54730@app.fastmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221116_043841_619392_49C52BD2 X-CRM114-Status: GOOD ( 14.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-11-16 11:16, Arnd Bergmann wrote: > On Wed, Nov 16, 2022, at 10:12, Vivek Yadav wrote: >> Change the reg properties from 64-bit to 32-bit for all IPs, as none of >> the nodes are above 32-bit range in the fsd SoC. >> >> Since dma-ranges length does not fit into 32-bit size, keep it 64-bit >> and move it to specific node where it is used instead of SoC section. > > I don't think that works, the dma-ranges property is part of the > bus, not a particular device: > > mdma0: dma-controller@10100000 { > compatible = "arm,pl330", "arm,primecell"; > - reg = <0x0 0x10100000 0x0 0x1000>; > + reg = <0x10100000 0x1000>; > interrupts = ; > #dma-cells = <1>; > clocks = <&clock_imem IMEM_DMA0_IPCLKPORT_ACLK>; > clock-names = "apb_pclk"; > iommus = <&smmu_imem 0x800 0x0>; > + #address-cells = <2>; > + #size-cells = <2>; > + dma-ranges = <0x0 0x0 0x0 0x10 0x0>; > }; > > Since the dma-controller has no children, I don't see how this has > any effect. Also, translating a 36-bit address into a 32-bit > address just means it gets truncated anyway, so there is no > point in making it appear to have a larger address range. Yes, this is definitely bogus on both counts. Thanks, Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel