[PATCH 0/3] ARM: PM: Drop useless checks for PM_SUSPEND_STANDBY

[PATCH 0/3] ARM: PM: Drop useless checks for PM_SUSPEND_STANDBY

[Geert Uytterhoeven]

	Hi all,

The system suspend implementations for DaVinci, OMAP, and SoCFPGA use
the standard suspend_valid_only_mem() for their
platform_suspend_ops.valid() callbacks.  Hence their
platform_suspend_ops.enter() callbacks will never be called with state
equal to PM_SUSPEND_STANDBY, and checks for this can thus be removed.

Thanks for your comments!

Geert Uytterhoeven (3):
  ARM: davinci: PM: Drop useless check for PM_SUSPEND_STANDBY
  ARM: OMAP: PM: Drop useless check for PM_SUSPEND_STANDBY
  ARM: socfpga: PM: Drop useless check for PM_SUSPEND_STANDBY

 arch/arm/mach-davinci/pm.c | 1 -
 arch/arm/mach-omap1/pm.c   | 1 -
 arch/arm/mach-omap2/pm.c   | 1 -
 arch/arm/mach-socfpga/pm.c | 1 -
 4 files changed, 4 deletions(-)

-- 
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH 1/3] ARM: davinci: PM: Drop useless check for PM_SUSPEND_STANDBY

[Geert Uytterhoeven]

As DaVinci uses the standard suspend_valid_only_mem() for its
platform_suspend_ops.valid() callback, its platform_suspend_ops.enter()
callback will never be called with state equal to PM_SUSPEND_STANDBY.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/mach-davinci/pm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-davinci/pm.c b/arch/arm/mach-davinci/pm.c
index 0afd201ab980464c..efb80354f3034d85 100644
--- a/arch/arm/mach-davinci/pm.c
+++ b/arch/arm/mach-davinci/pm.c
@@ -108,7 +108,6 @@ static int davinci_pm_enter(suspend_state_t state)
 	int ret = 0;
 
 	switch (state) {
-	case PM_SUSPEND_STANDBY:
 	case PM_SUSPEND_MEM:
 		davinci_pm_suspend();
 		break;
-- 
1.9.1

[PATCH 2/3] ARM: OMAP: PM: Drop useless checks for PM_SUSPEND_STANDBY

[Geert Uytterhoeven]

As OMAP uses the standard suspend_valid_only_mem() for its
platform_suspend_ops.valid() callback, its platform_suspend_ops.enter()
callback will never be called with state equal to PM_SUSPEND_STANDBY.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/mach-omap1/pm.c | 1 -
 arch/arm/mach-omap2/pm.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c
index ee5460b8ec2ee6e9..f1135bf8940ed82d 100644
--- a/arch/arm/mach-omap1/pm.c
+++ b/arch/arm/mach-omap1/pm.c
@@ -581,7 +581,6 @@ static int omap_pm_enter(suspend_state_t state)
 {
 	switch (state)
 	{
-	case PM_SUSPEND_STANDBY:
 	case PM_SUSPEND_MEM:
 		omap1_pm_suspend();
 		break;
diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
index 0598630c17786242..63027e60cc209f1c 100644
--- a/arch/arm/mach-omap2/pm.c
+++ b/arch/arm/mach-omap2/pm.c
@@ -163,7 +163,6 @@ static int omap_pm_enter(suspend_state_t suspend_state)
 		return -ENOENT; /* XXX doublecheck */
 
 	switch (suspend_state) {
-	case PM_SUSPEND_STANDBY:
 	case PM_SUSPEND_MEM:
 		ret = omap_pm_suspend();
 		break;
-- 
1.9.1

[PATCH 3/3] ARM: socfpga: PM: Drop useless check for PM_SUSPEND_STANDBY

[Geert Uytterhoeven]

As SoCFPGA uses the standard suspend_valid_only_mem() for its
platform_suspend_ops.valid() callback, its platform_suspend_ops.enter()
callback will never be called with state equal to PM_SUSPEND_STANDBY.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/mach-socfpga/pm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-socfpga/pm.c b/arch/arm/mach-socfpga/pm.c
index c378ab0c24317ccf..d4866788702cb87a 100644
--- a/arch/arm/mach-socfpga/pm.c
+++ b/arch/arm/mach-socfpga/pm.c
@@ -116,7 +116,6 @@ static int socfpga_pm_suspend(unsigned long arg)
 static int socfpga_pm_enter(suspend_state_t state)
 {
 	switch (state) {
-	case PM_SUSPEND_STANDBY:
 	case PM_SUSPEND_MEM:
 		outer_disable();
 		cpu_suspend(0, socfpga_pm_suspend);
-- 
1.9.1

[PATCH 0/3] ARM: PM: Drop useless checks for PM_SUSPEND_STANDBY

[Tony Lindgren]

* Geert Uytterhoeven <geert+renesas@glider.be> [170217 08:12]:
> 	Hi all,
> 
> The system suspend implementations for DaVinci, OMAP, and SoCFPGA use
> the standard suspend_valid_only_mem() for their
> platform_suspend_ops.valid() callbacks.  Hence their
> platform_suspend_ops.enter() callbacks will never be called with state
> equal to PM_SUSPEND_STANDBY, and checks for this can thus be removed.
> 
> Thanks for your comments!

Seems safe to remove:

Acked-by: Tony Lindgren <tony@atomide.com>

> Geert Uytterhoeven (3):
>   ARM: davinci: PM: Drop useless check for PM_SUSPEND_STANDBY
>   ARM: OMAP: PM: Drop useless check for PM_SUSPEND_STANDBY
>   ARM: socfpga: PM: Drop useless check for PM_SUSPEND_STANDBY
> 
>  arch/arm/mach-davinci/pm.c | 1 -
>  arch/arm/mach-omap1/pm.c   | 1 -
>  arch/arm/mach-omap2/pm.c   | 1 -
>  arch/arm/mach-socfpga/pm.c | 1 -
>  4 files changed, 4 deletions(-)
> 
> -- 
> 1.9.1
> 
> Gr{oetje,eeting}s,
> 
> 						Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> 							    -- Linus Torvalds

[PATCH 3/3] ARM: socfpga: PM: Drop useless check for PM_SUSPEND_STANDBY

[Dinh Nguyen]

On 02/17/2017 10:10 AM, Geert Uytterhoeven wrote:
> As SoCFPGA uses the standard suspend_valid_only_mem() for its
> platform_suspend_ops.valid() callback, its platform_suspend_ops.enter()
> callback will never be called with state equal to PM_SUSPEND_STANDBY.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  arch/arm/mach-socfpga/pm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/mach-socfpga/pm.c b/arch/arm/mach-socfpga/pm.c
> index c378ab0c24317ccf..d4866788702cb87a 100644
> --- a/arch/arm/mach-socfpga/pm.c
> +++ b/arch/arm/mach-socfpga/pm.c
> @@ -116,7 +116,6 @@ static int socfpga_pm_suspend(unsigned long arg)
>  static int socfpga_pm_enter(suspend_state_t state)
>  {
>  	switch (state) {
> -	case PM_SUSPEND_STANDBY:
>  	case PM_SUSPEND_MEM:
>  		outer_disable();
>  		cpu_suspend(0, socfpga_pm_suspend);
>

Acked-by: Dinh Nguyen <dinguyen@kernel.org>

Dinh

[PATCH 1/3] ARM: davinci: PM: Drop useless check for PM_SUSPEND_STANDBY

[Sekhar Nori]

On Friday 17 February 2017 09:40 PM, Geert Uytterhoeven wrote:
> As DaVinci uses the standard suspend_valid_only_mem() for its
> platform_suspend_ops.valid() callback, its platform_suspend_ops.enter()
> callback will never be called with state equal to PM_SUSPEND_STANDBY.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Looks good to me. Whats the plan for applying the series. Do you want
the individual machine maintainers to apply their parts. Or some other?

Thanks,
Sekhar

[PATCH 1/3] ARM: davinci: PM: Drop useless check for PM_SUSPEND_STANDBY

[Geert Uytterhoeven]

Hi Sekhar,

On Mon, Feb 20, 2017 at 9:30 AM, Sekhar Nori <nsekhar@ti.com> wrote:
> On Friday 17 February 2017 09:40 PM, Geert Uytterhoeven wrote:
>> As DaVinci uses the standard suspend_valid_only_mem() for its
>> platform_suspend_ops.valid() callback, its platform_suspend_ops.enter()
>> callback will never be called with state equal to PM_SUSPEND_STANDBY.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Looks good to me. Whats the plan for applying the series. Do you want
> the individual machine maintainers to apply their parts. Or some other?

I think the individual machine maintainers is the simplest.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH 1/3] ARM: davinci: PM: Drop useless check for PM_SUSPEND_STANDBY

[Sekhar Nori]

On Monday 20 February 2017 02:10 PM, Geert Uytterhoeven wrote:
> Hi Sekhar,
> 
> On Mon, Feb 20, 2017 at 9:30 AM, Sekhar Nori <nsekhar@ti.com> wrote:
>> On Friday 17 February 2017 09:40 PM, Geert Uytterhoeven wrote:
>>> As DaVinci uses the standard suspend_valid_only_mem() for its
>>> platform_suspend_ops.valid() callback, its platform_suspend_ops.enter()
>>> callback will never be called with state equal to PM_SUSPEND_STANDBY.
>>>
>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>
>> Looks good to me. Whats the plan for applying the series. Do you want
>> the individual machine maintainers to apply their parts. Or some other?
> 
> I think the individual machine maintainers is the simplest.

Patch 1/3 applied to branch v4.12/soc of my tree.

Thanks,
Sekhar

[PATCH 0/3] ARM: PM: Drop useless checks for PM_SUSPEND_STANDBY

[Tony Lindgren]

* Tony Lindgren <tony@atomide.com> [170217 08:41]:
> * Geert Uytterhoeven <geert+renesas@glider.be> [170217 08:12]:
> > 	Hi all,
> > 
> > The system suspend implementations for DaVinci, OMAP, and SoCFPGA use
> > the standard suspend_valid_only_mem() for their
> > platform_suspend_ops.valid() callbacks.  Hence their
> > platform_suspend_ops.enter() callbacks will never be called with state
> > equal to PM_SUSPEND_STANDBY, and checks for this can thus be removed.
> > 
> > Thanks for your comments!
> 
> Seems safe to remove:
> 
> Acked-by: Tony Lindgren <tony@atomide.com>

Sounds like you wanted me to pick this up so applying the
omap related patch into omap-for-v4.12/soc.

Thanks,

Tony