From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] kvm: vgic: are these warnings wrong?
Date: Tue, 14 Nov 2017 13:38:27 +0000 [thread overview]
Message-ID: <d668b9f1-6de6-56c2-db0b-3c30541f660e@arm.com> (raw)
In-Reply-To: <20171114064750.GB29552@linaro.org>
On 14/11/17 06:47, AKASHI Takahiro wrote:
> Hi Marc,
>
> I've just run a static analyzer to v4.14.
> While most of warnings/errors are false-positive, as you can easily imagine,
> there are something dubious. Can you please check ones below?
>
> virt/kvm/arm/vgic/vgic-v3.c:352 vgic_v3_save_pending_tables() error: uninitialized symbol 'val'.
> virt/kvm/arm/vgic/vgic-its.c:424 its_sync_lpi_pending_table() error: uninitialized symbol 'pendmask'.
> virt/kvm/arm/vgic/vgic-its.c:779 vgic_its_alloc_collection() error: potential null dereference 'collection'. (kzalloc returns null)
> virt/kvm/arm/vgic/vgic-irqfd.c:115 kvm_vgic_setup_default_irq_routing() warn: double check that we're allocating correct size: 48 vs 64
>
> # I believe that the messages here are self-describing.
For the record, I've stashed fixes for these here[1], based on kvmarm/next.
Thanks,
M.
[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=kvm-arm64/fixes-4.15
--
Jazz is not dead. It just smells funny...
prev parent reply other threads:[~2017-11-14 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 6:47 [RFC] kvm: vgic: are these warnings wrong? AKASHI Takahiro
2017-11-14 9:07 ` Marc Zyngier
2017-11-15 0:34 ` AKASHI Takahiro
2017-11-14 13:38 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d668b9f1-6de6-56c2-db0b-3c30541f660e@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).