linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mark Brown <broonie@kernel.org>,
	linux-spi@vger.kernel.org, Heiko Schocher <hs@denx.de>
Cc: linux-kernel@vger.kernel.org,
	Andrei Lalaev <andrey.lalaev@gmail.com>,
	Chanh Nguyen <chanh@os.amperecomputing.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	Grant Peltier <grantpeltier93@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Michal Simek <michal.simek@amd.com>,
	Naresh Solanki <naresh.solanki@9elements.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Rob Herring <robh@kernel.org>,
	Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org
Subject: Re: (subset) [PATCH v1 0/3] spidev: introduce trivial abb sensor device
Date: Mon, 21 Jul 2025 18:24:55 +0200	[thread overview]
Message-ID: <d677ecd9-42d6-43fe-8fe1-a5afd4d270e2@kernel.org> (raw)
In-Reply-To: <175311337130.327079.7374455187420344577.b4-ty@kernel.org>

On 21/07/2025 17:56, Mark Brown wrote:
> On Sat, 19 Jul 2025 08:33:51 +0200, Heiko Schocher wrote:
>> This series introduces the changes needed for trivial spi
>> based sensors from ABB, currently operated from userspace.
>>
>> The last patch adds the spidevices to the DTS files, already
>> in mainline.
>>
>> make dtbs_check showed no errors/warnings for the dts files
>>
>> [...]
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
> 
> Thanks!
> 
> [1/3] dt-bindings: trivial-devices: Document ABB sensors
>       commit: aad2f87cbcab56b322109d26d7b11842a09df91f
> [2/3] spi: spidev: Add an entry for the ABB spi sensors
>       commit: d60f7cab7c04944a79af16caa43c141e780a59c6
> 


That's unexpected, Mark. Patches received two objections/comments and I
don't think discussion was resolved.

ABB is huge company, probably making hundreds or more of sensors. The
patchset basically claims that all of them work with spidev. It does not
providing any model names or details, so it seems really incomplete to
call them trivial devices.

Best regards,
Krzysztof


  reply	other threads:[~2025-07-21 18:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-19  6:33 [PATCH v1 0/3] spidev: introduce trivial abb sensor device Heiko Schocher
2025-07-19  6:33 ` [PATCH v1 3/3] arm64: dts: imx8mp: add ABB spi sensors Heiko Schocher
2025-07-21 15:56 ` (subset) [PATCH v1 0/3] spidev: introduce trivial abb sensor device Mark Brown
2025-07-21 16:24   ` Krzysztof Kozlowski [this message]
2025-07-21 17:34     ` Mark Brown
2025-07-22  4:05     ` Heiko Schocher
2025-07-22  4:58       ` Guenter Roeck
2025-07-22 10:20         ` Jonathan Cameron
2025-08-01  4:45           ` Heiko Schocher
2025-07-22 11:07       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d677ecd9-42d6-43fe-8fe1-a5afd4d270e2@kernel.org \
    --to=krzk@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=andrey.lalaev@gmail.com \
    --cc=broonie@kernel.org \
    --cc=chanh@os.amperecomputing.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=grantpeltier93@gmail.com \
    --cc=hs@denx.de \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=michal.simek@amd.com \
    --cc=naresh.solanki@9elements.com \
    --cc=robh@kernel.org \
    --cc=rodrigo.gobbi.7@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).