From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86207C433EF for ; Mon, 17 Jan 2022 02:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YKc7rdwbz84fR4mLvz5qoTdDZfkDN8Hxklv3UFgsbDY=; b=cGwK8xpHsPCE45 s+ak/DxxlcvWbEVc3BAEkU5e4z9iPB4J71fCFkXiUZwGBM8VHJHvUCq1BrU6OLdCis3YaCHEKAzhz 4/XKl0K6hkuAxWq335SJxlbEFId01/K2zPMwAlPqYLyAEt3NtAc4gY+vDXpKIfdLQIL2utotJXwbf CLvx/9QmZlhYG33p6EaTwz6YNXKXOvl+9QmaXFgGAVBAgcx5N1mjCaeeI03UKSGsfoNp3IORQJppe FTWvHs3M1tn27kgOb8NGlUmvy5+LNgBmcSNNezB+bMxJBc9EzCCYOK1yLh+VXQla30VAEFmuY+ewf x7Dl7OGz+vVHLkvbbgXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9HzF-00DHeg-TT; Mon, 17 Jan 2022 02:43:14 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9HzC-00DHdj-N7; Mon, 17 Jan 2022 02:43:12 +0000 Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 17 Jan 2022 10:43:01 +0800 Message-ID: Date: Mon, 17 Jan 2022 10:43:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 3/4] clk: meson: add DT documentation for emmc clock controller Content-Language: en-US To: Stephen Boyd , Jerome Brunet , Kevin Hilman , Michael Turquette , Neil Armstrong , Rob Herring , CC: Martin Blumenstingl , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , References: <20220113115745.45826-1-liang.yang@amlogic.com> <20220113115745.45826-4-liang.yang@amlogic.com> <20220113212957.768FFC36AE3@smtp.kernel.org> <5d99ac02-a246-5bcc-2ecb-371b0d193537@amlogic.com> <20220114225957.285ADC36AE7@smtp.kernel.org> From: Liang Yang In-Reply-To: <20220114225957.285ADC36AE7@smtp.kernel.org> X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220116_184310_808874_38A20387 X-CRM114-Status: GOOD ( 10.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/1/15 6:59, Stephen Boyd wrote: > [ EXTERNAL EMAIL ] > > Quoting Liang Yang (2022-01-13 19:06:07) >> Hi Stephen, >> >> Thanks for your quick response. >> >> On 2022/1/14 5:29, Stephen Boyd wrote: >>> [ EXTERNAL EMAIL ] >>> >>> Quoting Liang Yang (2022-01-13 03:57:44) >>>> Document the MMC sub clock controller driver, the potential consumer >>>> of this driver is MMC or NAND. Also add four clock bindings IDs which >>>> provided by this driver. >>>> >>>> Signed-off-by: Liang Yang >>>> --- >>>> .../bindings/clock/amlogic,mmc-clkc.yaml | 64 +++++++++++++++++++ >>>> include/dt-bindings/clock/amlogic,mmc-clkc.h | 14 ++++ >>>> 2 files changed, 78 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.yaml >>>> create mode 100644 include/dt-bindings/clock/amlogic,mmc-clkc.h >>>> >>>> diff --git a/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.yaml >>>> new file mode 100644 >>>> index 000000000000..a274c3d5fc2e >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.yaml >>>> @@ -0,0 +1,64 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/clock/amlogic,mmc-clkc.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Amlogic MMC Sub Clock Controller Driver Device Tree Bindings >>>> + >>>> +maintainers: >>>> + - jianxin.pan@amlogic.com >>>> + - liang.yang@amlogic.com >>>> + >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - "amlogic,axg-mmc-clkc", "syscon" >>> >>> Why is it a syscon? >> >> The register documented by reg is shared with SD/eMMC controller port C, >> and it need to be ops on NFC driver. >> > > Is this the case where the clk is inside the SD/eMMC controller? Can the yes. > mmc driver register the clk controller from there and pass it an iomem > pointer to poke clks? we can't do that since EMMC and NAND is mutually exclusivem. both of them share the same data pins. > > . _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel