[PATCH v3 0/2] arm64: dts: rockchip: add Tinker Board 3 and 3S device tree

[PATCH v3 0/2] arm64: dts: rockchip: add Tinker Board 3 and 3S device tree

[Michael Opdenacker]

Add initial device tree support for Asus Tinker Board 3 [1] and 3S [2],
which are SBCs based on the Rockchip 3566 SoC.

The "3S" version ("S" for "storage") is just a regular Tinker Board 3
fitted with a 16 GB eMMC and a "mask ROM" DIP switch
(to mask the eMMC and enter "Mask ROM" mode for recovery).

This adds support for:
- Debug UART (/dev/ttyS2)
- SD card (/dev/mmcblk1)
- eMMC (/dev/mmcblk0, only on Tinker Board 3S)
- I2C:
  - i2c0 (internal bus with a PMIC and regulators)
  - i2c2 (internal bus with an at24 eeprom and an RTC device)
- USB 2.0 ports
- 2 GPIO LEDS

This code was tested on Tinker Board 3S using the "master"
branch of the Linux kernel.

[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.html

Changes in V3:
- rockchip.yaml: group Tinker Board 3/3S in the same section
- Remove this Acked-by as the code changed substantially:
  Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
- Remove "asus,rk3566-tinker-board-3" from rk3566-tinker-board-3s.dts,
  which conflicted with the change in rockchip.yaml and
  could create an issue if some code unexpectedly turns out
  to be compatible with 3 but not 3S.
  If you don't agree, than we can keep V2.

Changes in V2:
- Rename "Tinker board" to "Tinker Board"
  in commit messages and DT code
- Insert "-board" in DT file names
- Insert "-board" in new compatible string too
- Commit messages: change the way the references are introduced
  ("[1] https://..." instead of "Link: https://... [1]")
- Reorder alias properties and node names
- Add missing "cpu-supply" property to cpu nodes
- Use standard "eeprom@addr" node name for at24 eeprom
- DT commit message: add missing "Asus" before "Tinker"

Michael Opdenacker (2):
  dt-bindings: arm: rockchip: Add Asus Tinker Board 3 and 3S
  arm64: dts: rockchip: Add Asus Tinker Board 3 and 3S device tree

.../devicetree/bindings/arm/rockchip.yaml     |  11 +
 arch/arm64/boot/dts/rockchip/Makefile         |   2 +
 .../dts/rockchip/rk3566-tinker-board-3.dts    |  14 +
 .../dts/rockchip/rk3566-tinker-board-3.dtsi   | 280 ++++++++++++++++++
 .../dts/rockchip/rk3566-tinker-board-3s.dts   |  30 ++
 5 files changed, 337 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dts
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dtsi
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3s.dts

---
Michael Opdenacker (2):
      dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S
      arm64: dts: rockchip: Add Asus Tinker Board 3 and 3S device tree

 .../devicetree/bindings/arm/rockchip.yaml          |   7 +
 arch/arm64/boot/dts/rockchip/Makefile              |   2 +
 .../boot/dts/rockchip/rk3566-tinker-board-3.dts    |  14 ++
 .../boot/dts/rockchip/rk3566-tinker-board-3.dtsi   | 280 +++++++++++++++++++++
 .../boot/dts/rockchip/rk3566-tinker-board-3s.dts   |  30 +++
 5 files changed, 333 insertions(+)
---
base-commit: e7c375b181600caf135cfd03eadbc45eb530f2cb
change-id: 20251117-tinker3-88e32dfa9138

Best regards,
-- 
Michael Opdenacker <michael.opdenacker@rootcommit.com>

[PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

[Michael Opdenacker]

Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
which are SBCs based on the Rockchip 3566 SoC.

The "3S" version ("S" for "storage") just adds a 16 GB eMMC
and a "mask ROM" DIP switch to the "3" version.

[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.html

Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>

---

Changes in V3:

- Remove this Acked-by as the binding code changed substantially:
  Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 6aceaa8acbb2..800c11323a4f 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -86,6 +86,13 @@ properties:
           - const: asus,rk3288-tinker-s
           - const: rockchip,rk3288
 
+      - description: Asus Tinker Board 3/3S
+        items:
+          - enum:
+              - asus,rk3566-tinker-board-3
+              - asus,rk3566-tinker-board-3s
+          - const: rockchip,rk3566
+
       - description: Beelink A1
         items:
           - const: azw,beelink-a1

-- 
2.43.0

[PATCH v3 2/2] arm64: dts: rockchip: Add Asus Tinker Board 3 and 3S device tree

[Michael Opdenacker]

Add initial device tree support for Asus Tinker Board 3 [1] and 3S [2],
which are SBCs based on the Rockchip 3566 SoC.

The "3S" version ("S" for "storage") just adds a 16 GB eMMC
and a "mask ROM" DIP switch (to mask the eMMC and enter "Mask ROM"
mode for recovery) to the "3" version.

This adds support for:
- Debug UART (/dev/ttyS2)
- SD card (/dev/mmcblk1)
- eMMC (/dev/mmcblk0, only on Tinker Board 3S)
- I2C:
  - i2c0 (internal bus with a PMIC and regulators)
  - i2c2 (internal bus with an at24 eeprom and an RTC device)
- USB 2.0 ports
- 2 GPIO LEDS

[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.html

Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
---
 arch/arm64/boot/dts/rockchip/Makefile              |   2 +
 .../boot/dts/rockchip/rk3566-tinker-board-3.dts    |  14 ++
 .../boot/dts/rockchip/rk3566-tinker-board-3.dtsi   | 280 +++++++++++++++++++++
 .../boot/dts/rockchip/rk3566-tinker-board-3s.dts   |  30 +++
 4 files changed, 326 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index ad684e3831bc..e0d8b9ed176d 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -130,6 +130,8 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-nanopi-r3s.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-bigtreetech-cb2-manta.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-bigtreetech-pi2.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-tinker-board-3.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-tinker-board-3s.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-fastrhino-r66s.dtb
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dts b/arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dts
new file mode 100644
index 000000000000..af11faff5564
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dts
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright (C) 2025 Michael Opdenacker <michael.opdenacker@rootcommit.com>
+ */
+
+/dts-v1/;
+
+#include "rk3566-tinker-board-3.dtsi"
+
+/ {
+	model = "Asus Tinker Board 3";
+	compatible = "asus,rk3566-tinker-board-3", "rockchip,rk3566";
+};
+
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dtsi
new file mode 100644
index 000000000000..8544d56031f2
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dtsi
@@ -0,0 +1,280 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright (C) 2025 Michael Opdenacker <michael.opdenacker@rootcommit.com>
+ */
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/pinctrl/rockchip.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
+#include "rk3566.dtsi"
+
+/ {
+	aliases {
+		i2c0 = &i2c0;
+		i2c2 = &i2c2;
+		mmc1 = &sdmmc0;
+		serial2 = &uart2;
+	};
+
+	chosen {
+		stdout-path = "serial2:1500000n8";
+	};
+
+	gpio_leds: gpio-leds {
+		compatible = "gpio-leds";
+
+		act-led {
+			gpios = <&gpio0 RK_PD4 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger="mmc1";
+		};
+
+		rsv-led {
+			gpios = <&gpio0 RK_PD6 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger="none";
+		};
+	};
+
+	vcc3v3_sys: regulator-3v3-vcc-sys {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc3v3_sys";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		vin-supply = <&vcc5v0_sys>;
+	};
+
+	vcc5v0_sys: regulator-5v0-vcc-sys {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc5v0_sys";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+	};
+
+	vcc5v0_usb_host: regulator-5v0-vcc-usb-host {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&usb_host_pwren_h>;
+		regulator-name = "vcc5v0_usb_host";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		vin-supply = <&vcc5v0_sys>;
+	};
+};
+
+&cpu0 {
+	cpu-supply = <&vdd_cpu>;
+};
+
+&cpu1 {
+	cpu-supply = <&vdd_cpu>;
+};
+
+&cpu2 {
+	cpu-supply = <&vdd_cpu>;
+};
+
+&cpu3 {
+	cpu-supply = <&vdd_cpu>;
+};
+
+&i2c0 {
+	status = "okay";
+
+	rk809: pmic@20 {
+		compatible = "rockchip,rk809";
+		reg = <0x20>;
+		assigned-clocks = <&cru I2S1_MCLKOUT_TX>;
+		assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>;
+		#clock-cells = <1>;
+		clocks = <&cru I2S1_MCLKOUT_TX>;
+		clock-names = "mclk";
+		clock-output-names = "rk809-clkout1", "rk809-clkout2";
+		interrupt-parent = <&gpio0>;
+		interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pmic_int_l>, <&i2s1m0_mclk>;
+		#sound-dai-cells = <0>;
+		system-power-controller;
+		wakeup-source;
+
+		vcc1-supply = <&vcc3v3_sys>;
+		vcc2-supply = <&vcc3v3_sys>;
+		vcc3-supply = <&vcc3v3_sys>;
+		vcc4-supply = <&vcc3v3_sys>;
+		vcc5-supply = <&vcc3v3_sys>;
+		vcc6-supply = <&vcc3v3_sys>;
+		vcc7-supply = <&vcc3v3_sys>;
+		vcc8-supply = <&vcc3v3_sys>;
+		vcc9-supply = <&vcc3v3_sys>;
+
+		regulators {
+			vcc_1v8: DCDC_REG5 {
+				regulator-name = "vcc_1v8";
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vcc_3v3: SWITCH_REG1 {
+				regulator-name = "vcc_3v3";
+				regulator-always-on;
+				regulator-boot-on;
+
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vcc3v3_sd: SWITCH_REG2 {
+				regulator-name = "vcc3v3_sd";
+				regulator-always-on;
+				regulator-boot-on;
+
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vccio_sd: LDO_REG5 {
+				regulator-name = "vccio_sd";
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <3300000>;
+
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+		};
+	};
+
+	vdd_cpu: regulator@40 {
+		compatible = "silergy,syr827";
+		reg = <0x40>;
+		fcs,suspend-voltage-selector = <1>;
+		regulator-name = "vdd_cpu";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <830000>;
+		regulator-max-microvolt = <1200000>;
+		regulator-ramp-delay = <2300>;
+		vin-supply = <&vcc3v3_sys>;
+
+		regulator-state-mem {
+			regulator-off-in-suspend;
+		};
+	};
+};
+
+&i2c2 {
+	status = "okay";
+
+	eeprom@50 {
+		compatible = "atmel,24c08";
+		reg = <0x50>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&tb3_eeprom>;
+		status = "okay";
+	};
+
+	rtc_isl1208: rtc@6f {
+		compatible = "isil,isl1208";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_externalrtc_reg>;
+		interrupt-names = "irq";
+		interrupts-extended = <&gpio0 RK_PD3 IRQ_TYPE_EDGE_FALLING>;
+		reg = <0x6f>;
+		status = "okay";
+	};
+};
+
+&pinctrl {
+	pmic {
+		pmic_int_l: pmic-int-l {
+			rockchip,pins = <0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+
+	usb {
+		usb_host_pwren_h: usb-host-pwren-h {
+			rockchip,pins = <0 RK_PA6 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+
+		usb_otg_pwren_h: usb-otg-pwren-h {
+			rockchip,pins = <0 RK_PA5 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
+	rtc {
+		pinctrl_externalrtc_reg: externalrtcreggrp {
+			rockchip,pins = <0 RK_PD3 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+
+	eeprom {
+		tb3_eeprom: tb3-eeprom {
+			rockchip,pins = <3 RK_PC1 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+};
+
+&sdmmc0 {
+	bus-width = <4>;
+	cap-sd-highspeed;
+	disable-wp;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
+	vmmc-supply = <&vcc3v3_sd>;
+	vqmmc-supply = <&vccio_sd>;
+	status = "okay";
+};
+
+&uart2 {
+	status = "okay";
+};
+
+&usb_host0_ehci {
+	status = "okay";
+};
+
+&usb_host0_ohci {
+	status = "okay";
+};
+
+&usb_host1_ehci {
+	status = "okay";
+};
+
+&usb_host1_ohci {
+	status = "okay";
+};
+
+&usb2phy0 {
+	status = "okay";
+};
+
+&usb2phy0_host {
+	phy-supply = <&vcc5v0_usb_host>;
+	status = "okay";
+};
+
+&usb2phy1 {
+	status = "okay";
+};
+
+&usb2phy1_host {
+	phy-supply = <&vcc5v0_usb_host>;
+	status = "okay";
+};
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3s.dts b/arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3s.dts
new file mode 100644
index 000000000000..3624ebc8a26f
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3s.dts
@@ -0,0 +1,30 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright (C) 2025 Michael Opdenacker <michael.opdenacker@rootcommit.com>
+ */
+
+/dts-v1/;
+
+#include "rk3566-tinker-board-3.dtsi"
+
+/ {
+	model = "Asus Tinker Board 3S";
+	compatible = "asus,rk3566-tinker-board-3s", "rockchip,rk3566";
+
+	aliases {
+		mmc0 = &sdhci;
+	};
+};
+
+&sdhci {
+	bus-width = <8>;
+	cap-mmc-highspeed;
+	max-frequency = <200000000>;
+	mmc-hs200-1_8v;
+	non-removable;
+	pinctrl-names = "default";
+	pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe>;
+	vmmc-supply = <&vcc_3v3>;
+	vqmmc-supply = <&vcc_1v8>;
+	status = "okay";
+};

-- 
2.43.0

Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

[Krzysztof Kozlowski]

On 18/11/2025 16:56, Michael Opdenacker wrote:
> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
> which are SBCs based on the Rockchip 3566 SoC.
> 
> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
> and a "mask ROM" DIP switch to the "3" version.
> 
> [1] https://tinker-board.asus.com/series/tinker-board-3.html
> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> 
> ---
> 
> Changes in V3:
> 
> - Remove this Acked-by as the binding code changed substantially:
>   Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Above commit msg and DTS suggests they are pretty compatible with each
other, so I don't quite get why this changed. Your changelog says
"unexpectedly turns out to be compatible with 3 but not 3S.", but is
this real or are you just guessing? I think you were tricked to change
correct code into this.

Anyway, however odd this is, I don't care enough to stop this patchset, so:

Acked-by: Krzysztof Kozlowski <krzk@kernel.org>


Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

[Michael Opdenacker]

Hi Krzysztof

Thanks for the new review!

On 11/18/25 17:31, Krzysztof Kozlowski wrote:
> On 18/11/2025 16:56, Michael Opdenacker wrote:
>> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
>> which are SBCs based on the Rockchip 3566 SoC.
>>
>> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
>> and a "mask ROM" DIP switch to the "3" version.
>>
>> [1] https://tinker-board.asus.com/series/tinker-board-3.html
>> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>
>> ---
>>
>> Changes in V3:
>>
>> - Remove this Acked-by as the binding code changed substantially:
>>    Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Above commit msg and DTS suggests they are pretty compatible with each
> other, so I don't quite get why this changed. Your changelog says
> "unexpectedly turns out to be compatible with 3 but not 3S.", but is
> this real or are you just guessing? I think you were tricked to change
> correct code into this.

I was just guessing.  The likelihood that something working on 3 doesn't 
work on 3s looks very small indeed, but I'm not the manufacturer to 
completely rule this out.
>
> Anyway, however odd this is, I don't care enough to stop this patchset, so:
>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Thanks again!
Cheers
Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/

Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

[Dragan Simic]

Hello Michael,

On Tuesday, November 18, 2025 16:56 CET, Michael Opdenacker <michael.opdenacker@rootcommit.com> wrote:
> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
> which are SBCs based on the Rockchip 3566 SoC.
> 
> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
> and a "mask ROM" DIP switch to the "3" version.
> 
> [1] https://tinker-board.asus.com/series/tinker-board-3.html
> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> 
> ---
> 
> Changes in V3:
> 
> - Remove this Acked-by as the binding code changed substantially:
>   Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 6aceaa8acbb2..800c11323a4f 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -86,6 +86,13 @@ properties:
>            - const: asus,rk3288-tinker-s
>            - const: rockchip,rk3288
>  
> +      - description: Asus Tinker Board 3/3S
> +        items:
> +          - enum:
> +              - asus,rk3566-tinker-board-3
> +              - asus,rk3566-tinker-board-3s
> +          - const: rockchip,rk3566
> +
>        - description: Beelink A1
>          items:
>            - const: azw,beelink-a1

Please see my delayed response in the v2. [1]  I think that would be
a better approach.

[1] https://lore.kernel.org/linux-rockchip/3c96ee6b-dca7-1a0a-792b-f8c165ec997d@manjaro.org/

Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

[Krzysztof Kozlowski]

On 19/11/2025 08:00, Dragan Simic wrote:
> Hello Michael,
> 
> On Tuesday, November 18, 2025 16:56 CET, Michael Opdenacker <michael.opdenacker@rootcommit.com> wrote:
>> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
>> which are SBCs based on the Rockchip 3566 SoC.
>>
>> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
>> and a "mask ROM" DIP switch to the "3" version.
>>
>> [1] https://tinker-board.asus.com/series/tinker-board-3.html
>> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>
>> ---
>>
>> Changes in V3:
>>
>> - Remove this Acked-by as the binding code changed substantially:
>>   Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index 6aceaa8acbb2..800c11323a4f 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -86,6 +86,13 @@ properties:
>>            - const: asus,rk3288-tinker-s
>>            - const: rockchip,rk3288
>>  
>> +      - description: Asus Tinker Board 3/3S
>> +        items:
>> +          - enum:
>> +              - asus,rk3566-tinker-board-3
>> +              - asus,rk3566-tinker-board-3s
>> +          - const: rockchip,rk3566
>> +
>>        - description: Beelink A1
>>          items:
>>            - const: azw,beelink-a1
> 
> Please see my delayed response in the v2. [1]  I think that would be
> a better approach.
> 
> [1] https://lore.kernel.org/linux-rockchip/3c96ee6b-dca7-1a0a-792b-f8c165ec997d@manjaro.org/
> 

Your reviews are not helpful. You nitpick irrelevant things and propose
solutions which later reverse leading to wasted effort on contributors side.

Michael implemented what you asked here:

https://lore.kernel.org/linux-rockchip/e4cd11d0-463c-e707-5110-6b92899b1ba3@manjaro.org/

This patch implements exactly what you wanted. On v4 you will ask to
reverse back to v1?

Now you claim that you want back v2. Really, you are NOT HELPING. It is
clear you do not understand what you are proposing and this is not
helping ion the process. Please refrain from such confusing reviews.



Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

[Dragan Simic]

Hello Krzysztof,

On Wednesday, November 19, 2025 08:09 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 19/11/2025 08:00, Dragan Simic wrote:
> > On Tuesday, November 18, 2025 16:56 CET, Michael Opdenacker <michael.opdenacker@rootcommit.com> wrote:
> >> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
> >> which are SBCs based on the Rockchip 3566 SoC.
> >>
> >> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
> >> and a "mask ROM" DIP switch to the "3" version.
> >>
> >> [1] https://tinker-board.asus.com/series/tinker-board-3.html
> >> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
> >>
> >> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> >>
> >> ---
> >>
> >> Changes in V3:
> >>
> >> - Remove this Acked-by as the binding code changed substantially:
> >>   Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >>  Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
> >>  1 file changed, 7 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> index 6aceaa8acbb2..800c11323a4f 100644
> >> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> @@ -86,6 +86,13 @@ properties:
> >>            - const: asus,rk3288-tinker-s
> >>            - const: rockchip,rk3288
> >>  
> >> +      - description: Asus Tinker Board 3/3S
> >> +        items:
> >> +          - enum:
> >> +              - asus,rk3566-tinker-board-3
> >> +              - asus,rk3566-tinker-board-3s
> >> +          - const: rockchip,rk3566
> >> +
> >>        - description: Beelink A1
> >>          items:
> >>            - const: azw,beelink-a1
> > 
> > Please see my delayed response in the v2. [1]  I think that would be
> > a better approach.
> > 
> > [1] https://lore.kernel.org/linux-rockchip/3c96ee6b-dca7-1a0a-792b-f8c165ec997d@manjaro.org/
> 
> Your reviews are not helpful. You nitpick irrelevant things and propose
> solutions which later reverse leading to wasted effort on contributors side.
> 
> Michael implemented what you asked here:
> 
> https://lore.kernel.org/linux-rockchip/e4cd11d0-463c-e707-5110-6b92899b1ba3@manjaro.org/

Not exactly, because I didn't ask for any compatibles to be removed
from the new board dts files.

In this case, we could also say that it was Michael's fault not to
give enough time for the reviewers to respond.

> This patch implements exactly what you wanted. On v4 you will ask to
> reverse back to v1?

No, I will not, and please note this version doesn't exactly implement
what I suggested, as already explained above.

> Now you claim that you want back v2. Really, you are NOT HELPING. It is
> clear you do not understand what you are proposing and this is not
> helping ion the process. Please refrain from such confusing reviews.

No, I'm not suggesting that the series goes back to v2, but Michael
failed to give me enough time to respond.  If that were the case,
the v3 would've been in nicer shape, with, from my point of view, no
need for further adjustments.

Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

[Krzysztof Kozlowski]

On 19/11/2025 08:23, Dragan Simic wrote:
> Hello Krzysztof,
> 
> On Wednesday, November 19, 2025 08:09 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On 19/11/2025 08:00, Dragan Simic wrote:
>>> On Tuesday, November 18, 2025 16:56 CET, Michael Opdenacker <michael.opdenacker@rootcommit.com> wrote:
>>>> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
>>>> which are SBCs based on the Rockchip 3566 SoC.
>>>>
>>>> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
>>>> and a "mask ROM" DIP switch to the "3" version.
>>>>
>>>> [1] https://tinker-board.asus.com/series/tinker-board-3.html
>>>> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
>>>>
>>>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>>>
>>>> ---
>>>>
>>>> Changes in V3:
>>>>
>>>> - Remove this Acked-by as the binding code changed substantially:
>>>>   Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> ---
>>>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
>>>>  1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>>> index 6aceaa8acbb2..800c11323a4f 100644
>>>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>>> @@ -86,6 +86,13 @@ properties:
>>>>            - const: asus,rk3288-tinker-s
>>>>            - const: rockchip,rk3288
>>>>  
>>>> +      - description: Asus Tinker Board 3/3S
>>>> +        items:
>>>> +          - enum:
>>>> +              - asus,rk3566-tinker-board-3
>>>> +              - asus,rk3566-tinker-board-3s
>>>> +          - const: rockchip,rk3566
>>>> +
>>>>        - description: Beelink A1
>>>>          items:
>>>>            - const: azw,beelink-a1
>>>
>>> Please see my delayed response in the v2. [1]  I think that would be
>>> a better approach.
>>>
>>> [1] https://lore.kernel.org/linux-rockchip/3c96ee6b-dca7-1a0a-792b-f8c165ec997d@manjaro.org/
>>
>> Your reviews are not helpful. You nitpick irrelevant things and propose
>> solutions which later reverse leading to wasted effort on contributors side.
>>
>> Michael implemented what you asked here:
>>
>> https://lore.kernel.org/linux-rockchip/e4cd11d0-463c-e707-5110-6b92899b1ba3@manjaro.org/
> 
> Not exactly, because I didn't ask for any compatibles to be removed
> from the new board dts files.

Read your answer again. You wanted ENTIRE bindings, to be like this:

     - description: Asus Tinker Board 3/3S
       items:
         - enum:
	   - asus,rk3566-tinker-board-3
           - asus,rk3566-tinker-board-3s
         - const: rockchip,rk3566

(skipping obvious indentation fixup)
There are exactly like this.

> 
> In this case, we could also say that it was Michael's fault not to
> give enough time for the reviewers to respond.

Michael implemented EXACTLY what you asked. Now, you ask to change it to
what Michael did BEFORE.

Your reviews are completely irresponsible and incorrect.

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

[Michael Opdenacker]

On 11/19/25 08:23, Dragan Simic wrote:
> No, I'm not suggesting that the series goes back to v2, but Michael
> failed to give me enough time to respond.  If that were the case,
> the v3 would've been in nicer shape, with, from my point of view, no
> need for further adjustments.

I'm sorry if I caused trouble.

I agree I didn't leave you much time to react to my reply to your 
review. What happens is that I'm new to this subsystem and I was feeling 
some pressure to avoid missing the launch window for 6.19, which I don't 
know exactly when it will be.

Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/

Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

[Dragan Simic]

On Wednesday, November 19, 2025 08:09 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Now you claim that you want back v2. Really, you are NOT HELPING. It is
> clear you do not understand what you are proposing and this is not
> helping ion the process. Please refrain from such confusing reviews.
> 
> Best regards,
> Krzysztof

Oh, i forgot to mention that it certainly may be that I don't
know everything when it comes to DT bindings and definitions, but
you also may not know how to handle communication with people in
a polite and friendly way.

Thus, I'd suggest that you replace "Best regards" in your signature
with "No regards".

Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

[Dragan Simic]

On Wednesday, November 19, 2025 08:31 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 19/11/2025 08:23, Dragan Simic wrote:
> > On Wednesday, November 19, 2025 08:09 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >> On 19/11/2025 08:00, Dragan Simic wrote:
> >>> On Tuesday, November 18, 2025 16:56 CET, Michael Opdenacker <michael.opdenacker@rootcommit.com> wrote:
> >>>> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
> >>>> which are SBCs based on the Rockchip 3566 SoC.
> >>>>
> >>>> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
> >>>> and a "mask ROM" DIP switch to the "3" version.
> >>>>
> >>>> [1] https://tinker-board.asus.com/series/tinker-board-3.html
> >>>> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
> >>>>
> >>>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> >>>>
> >>>> ---
> >>>>
> >>>> Changes in V3:
> >>>>
> >>>> - Remove this Acked-by as the binding code changed substantially:
> >>>>   Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>>> ---
> >>>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
> >>>>  1 file changed, 7 insertions(+)
> >>>>
> >>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >>>> index 6aceaa8acbb2..800c11323a4f 100644
> >>>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> >>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >>>> @@ -86,6 +86,13 @@ properties:
> >>>>            - const: asus,rk3288-tinker-s
> >>>>            - const: rockchip,rk3288
> >>>>  
> >>>> +      - description: Asus Tinker Board 3/3S
> >>>> +        items:
> >>>> +          - enum:
> >>>> +              - asus,rk3566-tinker-board-3
> >>>> +              - asus,rk3566-tinker-board-3s
> >>>> +          - const: rockchip,rk3566
> >>>> +
> >>>>        - description: Beelink A1
> >>>>          items:
> >>>>            - const: azw,beelink-a1
> >>>
> >>> Please see my delayed response in the v2. [1]  I think that would be
> >>> a better approach.
> >>>
> >>> [1] https://lore.kernel.org/linux-rockchip/3c96ee6b-dca7-1a0a-792b-f8c165ec997d@manjaro.org/
> >>
> >> Your reviews are not helpful. You nitpick irrelevant things and propose
> >> solutions which later reverse leading to wasted effort on contributors side.
> >>
> >> Michael implemented what you asked here:
> >>
> >> https://lore.kernel.org/linux-rockchip/e4cd11d0-463c-e707-5110-6b92899b1ba3@manjaro.org/
> > 
> > Not exactly, because I didn't ask for any compatibles to be removed
> > from the new board dts files.
> 
> Read your answer again. You wanted ENTIRE bindings, to be like this:
> 
>      - description: Asus Tinker Board 3/3S
>        items:
>          - enum:
> 	   - asus,rk3566-tinker-board-3
>            - asus,rk3566-tinker-board-3s
>          - const: rockchip,rk3566
> 
> (skipping obvious indentation fixup)
> There are exactly like this.
> 
> > 
> > In this case, we could also say that it was Michael's fault not to
> > give enough time for the reviewers to respond.
> 
> Michael implemented EXACTLY what you asked. Now, you ask to change it to
> what Michael did BEFORE.

Not really, because it wasn't some kind of a request from my side,
but merely a suggestion that was intended to be discussed further
so the best possible solution is reached before v3 is submitted.

> Your reviews are completely irresponsible and incorrect.

Calling my reviews irresponsible hurts me a lot, really, but I'm
unfortunately already used to hear hurtful things from your side.

Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

[Krzysztof Kozlowski]

On 19/11/2025 08:40, Dragan Simic wrote:
> On Wednesday, November 19, 2025 08:31 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On 19/11/2025 08:23, Dragan Simic wrote:
>>> On Wednesday, November 19, 2025 08:09 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>> On 19/11/2025 08:00, Dragan Simic wrote:
>>>>> On Tuesday, November 18, 2025 16:56 CET, Michael Opdenacker <michael.opdenacker@rootcommit.com> wrote:
>>>>>> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
>>>>>> which are SBCs based on the Rockchip 3566 SoC.
>>>>>>
>>>>>> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
>>>>>> and a "mask ROM" DIP switch to the "3" version.
>>>>>>
>>>>>> [1] https://tinker-board.asus.com/series/tinker-board-3.html
>>>>>> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
>>>>>>
>>>>>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>>>>>
>>>>>> ---
>>>>>>
>>>>>> Changes in V3:
>>>>>>
>>>>>> - Remove this Acked-by as the binding code changed substantially:
>>>>>>   Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>>> ---
>>>>>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
>>>>>>  1 file changed, 7 insertions(+)
>>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>>>>> index 6aceaa8acbb2..800c11323a4f 100644
>>>>>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>>>>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>>>>> @@ -86,6 +86,13 @@ properties:
>>>>>>            - const: asus,rk3288-tinker-s
>>>>>>            - const: rockchip,rk3288
>>>>>>  
>>>>>> +      - description: Asus Tinker Board 3/3S
>>>>>> +        items:
>>>>>> +          - enum:
>>>>>> +              - asus,rk3566-tinker-board-3
>>>>>> +              - asus,rk3566-tinker-board-3s
>>>>>> +          - const: rockchip,rk3566
>>>>>> +
>>>>>>        - description: Beelink A1
>>>>>>          items:
>>>>>>            - const: azw,beelink-a1
>>>>>
>>>>> Please see my delayed response in the v2. [1]  I think that would be
>>>>> a better approach.
>>>>>
>>>>> [1] https://lore.kernel.org/linux-rockchip/3c96ee6b-dca7-1a0a-792b-f8c165ec997d@manjaro.org/
>>>>
>>>> Your reviews are not helpful. You nitpick irrelevant things and propose
>>>> solutions which later reverse leading to wasted effort on contributors side.
>>>>
>>>> Michael implemented what you asked here:
>>>>
>>>> https://lore.kernel.org/linux-rockchip/e4cd11d0-463c-e707-5110-6b92899b1ba3@manjaro.org/
>>>
>>> Not exactly, because I didn't ask for any compatibles to be removed
>>> from the new board dts files.
>>
>> Read your answer again. You wanted ENTIRE bindings, to be like this:
>>
>>      - description: Asus Tinker Board 3/3S
>>        items:
>>          - enum:
>> 	   - asus,rk3566-tinker-board-3
>>            - asus,rk3566-tinker-board-3s
>>          - const: rockchip,rk3566
>>
>> (skipping obvious indentation fixup)
>> There are exactly like this.
>>
>>>
>>> In this case, we could also say that it was Michael's fault not to
>>> give enough time for the reviewers to respond.
>>
>> Michael implemented EXACTLY what you asked. Now, you ask to change it to
>> what Michael did BEFORE.
> 
> Not really, because it wasn't some kind of a request from my side,
> but merely a suggestion that was intended to be discussed further
> so the best possible solution is reached before v3 is submitted.
> 
>> Your reviews are completely irresponsible and incorrect.
> 
> Calling my reviews irresponsible hurts me a lot, really, but I'm
> unfortunately already used to hear hurtful things from your side.

You do not bear the cost of your reviews, so maybe that's why you think
nitpicking, poking around, pin pointing irrelevant things and adding 2
cents is okay, but that leads to additional effort on contributors and
reviewers. And not respecting total effort is irresponsible.


Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

[Dragan Simic]

On Wednesday, November 19, 2025 08:48 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 19/11/2025 08:40, Dragan Simic wrote:
> > On Wednesday, November 19, 2025 08:31 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >> On 19/11/2025 08:23, Dragan Simic wrote:
> >>> On Wednesday, November 19, 2025 08:09 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>>> Your reviews are not helpful. You nitpick irrelevant things and propose
> >>>> solutions which later reverse leading to wasted effort on contributors side.
> >>>>
> >>>> Michael implemented what you asked here:
> >>>>
> >>>> https://lore.kernel.org/linux-rockchip/e4cd11d0-463c-e707-5110-6b92899b1ba3@manjaro.org/
> >>>
> >>> Not exactly, because I didn't ask for any compatibles to be removed
> >>> from the new board dts files.
> >>
> >> Read your answer again. You wanted ENTIRE bindings, to be like this:
> >>
> >>      - description: Asus Tinker Board 3/3S
> >>        items:
> >>          - enum:
> >> 	   - asus,rk3566-tinker-board-3
> >>            - asus,rk3566-tinker-board-3s
> >>          - const: rockchip,rk3566
> >>
> >> (skipping obvious indentation fixup)
> >> There are exactly like this.
> >>>
> >>> In this case, we could also say that it was Michael's fault not to
> >>> give enough time for the reviewers to respond.
> >>
> >> Michael implemented EXACTLY what you asked. Now, you ask to change it to
> >> what Michael did BEFORE.
> > 
> > Not really, because it wasn't some kind of a request from my side,
> > but merely a suggestion that was intended to be discussed further
> > so the best possible solution is reached before v3 is submitted.
> > 
> >> Your reviews are completely irresponsible and incorrect.
> > 
> > Calling my reviews irresponsible hurts me a lot, really, but I'm
> > unfortunately already used to hear hurtful things from your side.
> 
> You do not bear the cost of your reviews, so maybe that's why you think
> nitpicking, poking around, pin pointing irrelevant things and adding 2
> cents is okay, but that leads to additional effort on contributors and
> reviewers. And not respecting total effort is irresponsible.

Thank you very much for finding additional ways to hurt my feelings.
However, please think about how your unfriendly approach may or may
not contribute to the overall effort.

Re: [PATCH v3 0/2] arm64: dts: rockchip: add Tinker Board 3 and 3S device tree

[Heiko Stuebner]

On Tue, 18 Nov 2025 15:56:41 +0000, Michael Opdenacker wrote:
> Add initial device tree support for Asus Tinker Board 3 [1] and 3S [2],
> which are SBCs based on the Rockchip 3566 SoC.
> 
> The "3S" version ("S" for "storage") is just a regular Tinker Board 3
> fitted with a 16 GB eMMC and a "mask ROM" DIP switch
> (to mask the eMMC and enter "Mask ROM" mode for recovery).
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S
      commit: f4e81d0b95f3257a2fcfdbfaa2d8ed41015c621b
[2/2] arm64: dts: rockchip: Add Asus Tinker Board 3 and 3S device tree
      commit: 9f80b3952318d7ef18573a5010f06118602f992e

Changed the property sorting of the RTC and also migrated all the
pinctrl names to match the schematics.

When creating pinctrl entries, please always _try_ to use the names
found in the device schematics. This makes it way easier in the future
to find one from the other :-)


Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>