From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3548C10F12 for ; Mon, 15 Apr 2019 19:33:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 903C220651 for ; Mon, 15 Apr 2019 19:33:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sng8DLBT"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MWvIQ6U+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 903C220651 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uqWVt3sjStJfMpCkcfzRdlzbo0j5tV5hNcwZYWCuhWo=; b=sng8DLBTJYl6ju PNBD42fbBVnrrNuKftO9XSQ53olYiXmHnDH0ncdcvRCxi7EvILC9r+AD1F+Hp694kWdHKFZrz85jw cx/UatSYgzBEyVUWSFcJ//C21wHjj0ie4nqPA4sYsMOwnQ3zrGN5Nn0wlep6kP7Y9EBo7pnlogMVz BNSBbz8WR2riviZXsuf1TV4cPbBcig00o39KE0YfCSOV8y3b+yGMgaWJ4ga0s175SLLsgluIaOtGJ bzZnJmmOUYyCNtKkQ5PEGwXPq9AHo2czdsjVPRgPji3eEExnogzl7rXOTGXg8ohtT0WEuFRgAMahp 4pnU8Lzy1K9SPYzL7DIg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hG7Ln-0005lG-Rp; Mon, 15 Apr 2019 19:33:07 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hG7Ll-0005kb-6c for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2019 19:33:06 +0000 Received: by mail-wr1-x443.google.com with SMTP id g3so23430146wrx.9 for ; Mon, 15 Apr 2019 12:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Ma5uDlcJg/vAc/B3lffKq0xAllAv/cjyeMuwGpJId8U=; b=MWvIQ6U+dwRQXBjdUoyeIhDPUeJLewF10K1omsHHKi1+xPKZzPN8kodzetTeAIse+3 xM2vn31dTbUwQ0TJRIxYb0lbR3bbtT6qe0yS2IhUQk/+0BCHM66lS3Vq9k0MN4tJn19K Ot7m8Ph+DIpn7z4NX18fVCph/4IdtzJxAk8oAhD1n/27gfzSQjcJSEosGigevD3Ua8LN YPSBzismWkwkW3VJ2uBcpG4ImzU0lLL8N+8DcvcagjRrd3Cryyi7NRh5BpCDf+L4iVKi 2Ij4wBMsDL0AG1kVBbJMJ7JdAVErVLnz4LsxmZZ/TZX+LOE/zi18H+9IF5s8rSGc7zJF 7OVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ma5uDlcJg/vAc/B3lffKq0xAllAv/cjyeMuwGpJId8U=; b=aClsjRsqevcz8Ii0PThi+0GMYq3AzZF64uDk7PFki5U4S9uMWrRx7b/hiHtsdonLZj N+H6jCZkMRfRWaJiMV5wJPK5Ub5MQmqJ/quU/T7QW0uG3nV0hIPcGx4AlkKY0rQ+uDCd hpUELDkf2sQvRQaSA9LiwJneYB6jAEfeddodZs9/tq+DlWYmw0fBNZGYBJPI5ggQZ0IR h3uTkQO/SpUsLQhifR/89rEfbX/XjwWL8VceOLO2UZwYyc6K+gG3VotcJPL0pj+GKniI HLZAIKUNtUW1doMHMN+nk2ZL++Wfr1Mn8UCT+Su8LNiJTrThi9pNz5Q1gCyXF2HdKAxu 3lXw== X-Gm-Message-State: APjAAAUsXsgvn+VHMGsxE8XAMkivX5WwiqV++8AH8zX3a/PmkOSYpjtX wrR3AvhjZpPCRnHxR8TW+CAlp/VVc1A= X-Google-Smtp-Source: APXvYqxbGFhRp+F7YmjhEyLmQRTyubsCd7p1LGLgNlVTU3F0hGxx+wf6pJAl7TUMWnh+RLUutwZmHg== X-Received: by 2002:adf:eed1:: with SMTP id a17mr50263531wrp.268.1555356783158; Mon, 15 Apr 2019 12:33:03 -0700 (PDT) Received: from [192.168.1.221] ([195.245.38.118]) by smtp.gmail.com with ESMTPSA id j9sm56018749wrr.93.2019.04.15.12.33.01 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 15 Apr 2019 12:33:02 -0700 (PDT) Subject: Re: [PATCH 1/4] ARM: ep93xx: move network platform data to separate header To: Arnd Bergmann , Hartley Sweeten References: <20190415192734.935387-1-arnd@arndb.de> From: Alexander Sverdlin Message-ID: Date: Mon, 15 Apr 2019 21:31:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190415192734.935387-1-arnd@arndb.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190415_123305_242590_6A9A5038 X-CRM114-Status: GOOD ( 21.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jakub Kicinski , netdev@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, David Ahern , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, On 15/04/2019 21:25, Arnd Bergmann wrote: > The header file is the only thing preventing us from building the > driver in a cross-platform configuration, so move the structure > we are interested in to the global platform_data location > and enable compile testing. Acked-by: Alexander Sverdlin > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-ep93xx/include/mach/platform.h | 7 +------ > drivers/net/ethernet/cirrus/Kconfig | 2 +- > drivers/net/ethernet/cirrus/ep93xx_eth.c | 2 +- > include/linux/platform_data/eth-ep93xx.h | 10 ++++++++++ > 4 files changed, 13 insertions(+), 8 deletions(-) > create mode 100644 include/linux/platform_data/eth-ep93xx.h > > diff --git a/arch/arm/mach-ep93xx/include/mach/platform.h b/arch/arm/mach-ep93xx/include/mach/platform.h > index 6c41c794bed5..43446f33c2be 100644 > --- a/arch/arm/mach-ep93xx/include/mach/platform.h > +++ b/arch/arm/mach-ep93xx/include/mach/platform.h > @@ -5,6 +5,7 @@ > > #ifndef __ASSEMBLY__ > > +#include > #include > > struct device; > @@ -15,12 +16,6 @@ struct ep93xxfb_mach_info; > struct ep93xx_keypad_platform_data; > struct ep93xx_spi_info; > > -struct ep93xx_eth_data > -{ > - unsigned char dev_addr[6]; > - unsigned char phy_id; > -}; > - > void ep93xx_map_io(void); > void ep93xx_init_irq(void); > > diff --git a/drivers/net/ethernet/cirrus/Kconfig b/drivers/net/ethernet/cirrus/Kconfig > index e9a0213b08c4..6238e6951336 100644 > --- a/drivers/net/ethernet/cirrus/Kconfig > +++ b/drivers/net/ethernet/cirrus/Kconfig > @@ -41,7 +41,7 @@ config CS89x0_PLATFORM > > config EP93XX_ETH > tristate "EP93xx Ethernet support" > - depends on ARM && ARCH_EP93XX > + depends on (ARM && ARCH_EP93XX) || COMPILE_TEST > select MII > help > This is a driver for the ethernet hardware included in EP93xx CPUs. > diff --git a/drivers/net/ethernet/cirrus/ep93xx_eth.c b/drivers/net/ethernet/cirrus/ep93xx_eth.c > index 13dfdfca49fc..a6da9873570b 100644 > --- a/drivers/net/ethernet/cirrus/ep93xx_eth.c > +++ b/drivers/net/ethernet/cirrus/ep93xx_eth.c > @@ -25,7 +25,7 @@ > #include > #include > > -#include > +#include > > #define DRV_MODULE_NAME "ep93xx-eth" > #define DRV_MODULE_VERSION "0.1" > diff --git a/include/linux/platform_data/eth-ep93xx.h b/include/linux/platform_data/eth-ep93xx.h > new file mode 100644 > index 000000000000..8eef637a804d > --- /dev/null > +++ b/include/linux/platform_data/eth-ep93xx.h > @@ -0,0 +1,10 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _LINUX_PLATFORM_DATA_ETH_EP93XX > +#define _LINUX_PLATFORM_DATA_ETH_EP93XX > + > +struct ep93xx_eth_data { > + unsigned char dev_addr[6]; > + unsigned char phy_id; > +}; > + > +#endif > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel