From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30050C27C6E for ; Fri, 14 Jun 2024 08:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eGmOzn1R1K16dkDMQJjEQ6wgWuo7/3DN6CTKOSNpNgg=; b=2SHfNhW+lfu/0HWfq8dC2R9MFv aiJRhDc3vZrxU3GUtWTYgk0xRQHMzrk/T3BTyaM5axisBcPVigozb2yYpcW3HfRIFtz3m4FQP7xA6 //NF4G3qg2ZEKKuaMRl8HHiUFUhM20AZtb8XaVS+Ua0lhtpIuO1f67455KBw1H5lLL/H456BT00CI sLNmjsN/zwSWayB8YTO4dUENyQtyrVjlZX8StCdnksOAVHmuLo/peg/UYAN3XOJSlfBem3/D5n4O5 E4oomtV0Oj2FJVCNPBajHpA6WaTlKlyrwZ5NPsUAu4eJN6r1mlaAotN8p2cbjH1SyhWHzUKifksgJ lE/4L2/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sI27G-00000001xm1-2PTr; Fri, 14 Jun 2024 08:17:00 +0000 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sI276-00000001xgS-2w5L for linux-arm-kernel@lists.infradead.org; Fri, 14 Jun 2024 08:16:55 +0000 Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2eaea28868dso25400541fa.3 for ; Fri, 14 Jun 2024 01:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1718353007; x=1718957807; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eGmOzn1R1K16dkDMQJjEQ6wgWuo7/3DN6CTKOSNpNgg=; b=XTHLGUNGGd6qhbZB6brK85AhMHLxX9GWhwvhGizG+NL62c8pNY/TU3n7YbVqSTy+ln 4Bt4azVzliz1650ms2cnYPk94pDD+e2DW4o0NNn/Z4Nc6fyRP46jCFASXGVtgctKknR2 63fLXiRUeTSkpZN4/f6zUlG369YNw3hoHiXvxoU61yZgHXGKPRFdqAPfps6VgIJBDYLL LcFcz1Ev2fxMd6l/Tdx24Ebo9/4zQTAwTjLG14c/p8W6PqQyDp08oKEb4MkLigM8gZNx 1dLSrvseJ8AYamOT2Gt9ptJ3UpJkGjv5VecWoJywLSRq80K40UzInTPdTWfe4jR80XxZ Myew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718353007; x=1718957807; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eGmOzn1R1K16dkDMQJjEQ6wgWuo7/3DN6CTKOSNpNgg=; b=RyGEFzbiTOZPZUQQ7if59LuDZJmwdZ+S7IrquRiyvd7BI1rGLYaUV7otWLkQNekAtA MlkZc98E26/ZsQimkUqwieqbYHLR/SQ8Qm0EszpG4EG9mgsk7GTJFNu9uf05HX4mk4LZ YAFkyMwdJcuA/lvrMYFo/apSy9YKg04uY8OfipJbZY5jP41MlltwQHMXBQzCTUG1/ocH mGPaTS2BFdTZvlcIfoFU4A/pflnwG/mv+4fsUHbXVQH2AcIGVVulx0/uQmkiKRb1t7YW ytC5ACfYKKeUCkUst4P/K+czvyT3BMoNbXg4kVzQdltxeCEcFZw1+cF7LRxuQCsNfh8f YQ8A== X-Forwarded-Encrypted: i=1; AJvYcCUD33LYqN4lYEud6TS7IV6ONlvtvZt8NDIXPwYaklaOAlFjXzgx+KonLu7bBvsigpg5fM/l7WcgcHuH9SK4fUhR0XCI8ArAUdaqoWjSP3Jz5Jj5PKY= X-Gm-Message-State: AOJu0YwVy0EXvua8jtNemTxMRA8VaYmc8TNNhpmIY9LU08NsZOLghqix gH+b3svHddWi5sWbFYwbmOtQlKT0lmjNEL5mYPzWVGyhM5K7VWblvBEuyvh9FLg= X-Google-Smtp-Source: AGHT+IGdVz9wnYuErYpbzpZPBaxajSeBzfE2NEQMkvFihFynmrdBmCln5caVCr3TFMsMNsUcb/jj1Q== X-Received: by 2002:a2e:7d03:0:b0:2eb:e56c:c90a with SMTP id 38308e7fff4ca-2ec0e5c8c3dmr14354061fa.43.1718353006713; Fri, 14 Jun 2024 01:16:46 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422f6127c6fsm51121795e9.24.2024.06.14.01.16.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jun 2024 01:16:46 -0700 (PDT) Message-ID: Date: Fri, 14 Jun 2024 11:16:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/12] dt-bindings: rtc: renesas,rzg3s-rtc: Document the Renesas RZ/G3S RTC Content-Language: en-US To: Biju Das , "geert+renesas@glider.be" , "mturquette@baylibre.com" , "sboyd@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "lee@kernel.org" , "alexandre.belloni@bootlin.com" , "magnus.damm@gmail.com" Cc: "linux-renesas-soc@vger.kernel.org" , "linux-clk@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rtc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Claudiu Beznea References: <20240614071932.1014067-1-claudiu.beznea.uj@bp.renesas.com> <20240614071932.1014067-6-claudiu.beznea.uj@bp.renesas.com> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240614_011649_037862_F4D8B3D0 X-CRM114-Status: GOOD ( 17.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Biju, On 14.06.2024 10:53, Biju Das wrote: > Hi Claudiu, > > Thanks for the patch. > >> -----Original Message----- >> From: linux-arm-kernel On Behalf Of Claudiu >> Sent: Friday, June 14, 2024 8:19 AM >> Subject: [PATCH 05/12] dt-bindings: rtc: renesas,rzg3s-rtc: Document the Renesas RZ/G3S RTC >> >> From: Claudiu Beznea >> >> Document the RTC IP (RTCA-3) available on the Renesas RZ/G3S SoC. >> >> Signed-off-by: Claudiu Beznea >> --- >> .../bindings/rtc/renesas,rzg3s-rtc.yaml | 60 +++++++++++++++++++ >> 1 file changed, 60 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/rtc/renesas,rzg3s-rtc.yaml >> >> diff --git a/Documentation/devicetree/bindings/rtc/renesas,rzg3s-rtc.yaml >> b/Documentation/devicetree/bindings/rtc/renesas,rzg3s-rtc.yaml >> new file mode 100644 >> index 000000000000..0e17f8a36155 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rtc/renesas,rzg3s-rtc.yaml >> @@ -0,0 +1,60 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/rtc/renesas,rzg3s-rtc.yaml# > > Please make it generic renesas,rtca3-rtc.yaml. Future SoCs may use this IP. > So use IP name instead. >From what I know the file name should correspond with the compatible that file was introduced with, and this one shouldn't be generic but SoC specific. Thank you, Claudiu Beznea > > Cheers, > Biju > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Real Time Clock for Renesas RZ/G3S SoC >> + >> +maintainers: >> + - Claudiu Beznea >> + >> +properties: >> + compatible: >> + const: renesas,rzg3s-rtc >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 3 >> + >> + interrupt-names: >> + items: >> + - const: alarm >> + - const: period >> + - const: carry >> + >> + clocks: >> + maxItems: 1 >> + description: RTC counter clock >> + >> + clock-names: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - interrupt-names >> + - clocks >> + - clock-names >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + >> + rtc: rtc@1004ec00 { >> + compatible = "renesas,rzg3s-rtc"; >> + reg = <0x1004ec00 0x400>; >> + interrupts = , >> + , >> + ; >> + interrupt-names = "alarm", "period", "carry"; >> + clocks = <&vbattclk>; >> + clock-names = "counter"; >> + status = "disabled"; >> + }; >> -- >> 2.39.2 >> >