From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F8B5C43334 for ; Thu, 9 Jun 2022 20:29:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qJNJf09gb7mK3URwoZpA+Jh9OZhwWD1NQb0XU8/nhKw=; b=Ca+EXbdVMIEMmKoxrHYxCxlZcs UDHnYyeQsleeal4FDN5zGMcrEBj2qvAC6XjaKhtJcIG+CiFhr9MKyxfd3hKLO8P8zF+O8++UO0MFe zfAMys9E9HTeYV7GyLmjBCLsIL2EetvdA0QWSWu1MMiclVW6EEL6QaRC+OEkSxP4MeWu4hmZAnxwm qDU0p/nUFW2rdRzSBgz2pfVBQO97roiDs2K7MVY66pTSBx5QV8h77sgrM5iHZeh/OFUqI/3gLuFky b2wvaEia8fDt2qIOMsfkOxp6hLhLvEDFwHFOYfR509yAlj+H3+WKh4tpeDtmYO9lUyqKLU9Nh7HYT E4ROxraw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzOlV-003yJV-VC; Thu, 09 Jun 2022 20:28:26 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzOlS-003yHe-JV for linux-arm-kernel@lists.infradead.org; Thu, 09 Jun 2022 20:28:24 +0000 Received: by mail-lj1-x229.google.com with SMTP id y15so22032044ljc.0 for ; Thu, 09 Jun 2022 13:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=46OkSZCeD56sfzrRV9ixVa9kbc26s0RkXULJ1qM0uHw=; b=Cqo4DSvIxHUHTuqtmXxBEQEss56ECscrzgfl6tFBQQHCwHv4gHc+tfptnqcWotUnwn kfM7AqT75NAxphIsW4UmWdx1OMvBH82UlNcB/J3l+xA8Q25UnaHbCypKPUGW1epXcIKW 3IBLprzy5gOxwNAFx+x8NZCg3gTeT62BvN7F1YSOfoRuJo6+ew2xM1G0cAoCpdUwZ2kp kZBttUZCWNmLKpe7pg00P+/0iVJoNtSmAcO2jLvQpGHsCBOGni1DyGQUkMTpo0JoxCH9 /8y4RA7vHZS/yy51dpCqH9fZ3EATcI+zV+1c4+nvuiJCJ6JNvUwSokhuStUyONTQ67/k fLGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=46OkSZCeD56sfzrRV9ixVa9kbc26s0RkXULJ1qM0uHw=; b=UZDNH7VAOxuzyMQzHCTcgCF+ETz/bTYuoN3t7F9aEixq1qKtXQ7UliiOIU+DoZ3Qi0 KzPoFuJTu0vTASdyoLkZv9vmECXWHqxgkg6zhC+Xtz9g/wtE/sxFTO1ChooM/aRc4ONn dvgrNHbKhJisKAnrX9GI7S6VdPV4jJh/ValY+kSFKh8mx85mGG1yMG4OPr4xP+bHlS8H fHyRSuwX2TU56xsmcyu/ZXBwZKwz0E6fOoOGIQtH6N5V1bI1eJkONxUcXMHtKsX/+RdR OTGfYo5xwMV0W6MFPNglm5QVHe3Lxa63d0MHhXEUp59Fb7Lpd/j5+i3dgpCN4T/Q98jh eKKA== X-Gm-Message-State: AOAM531WbmvWV4H9MOllcmDeq/2QIL3AQzYY7SOM40/DINcrp7ArHns8 DSni4iunEXFQxT2AqnluhxE= X-Google-Smtp-Source: ABdhPJyyeult8NpzAQqn7PaWa4sRx7dCdjWErZ27oucNSpMUlcJj32mPjTi39OlTcDR82vmZrn5E7w== X-Received: by 2002:a2e:9808:0:b0:255:59c1:3086 with SMTP id a8-20020a2e9808000000b0025559c13086mr27890832ljj.495.1654806498059; Thu, 09 Jun 2022 13:28:18 -0700 (PDT) Received: from [192.168.0.131] ([194.183.54.57]) by smtp.gmail.com with ESMTPSA id p20-20020ac24ed4000000b004744bfd620fsm198164lfr.236.2022.06.09.13.28.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jun 2022 13:28:17 -0700 (PDT) Message-ID: Date: Thu, 9 Jun 2022 22:28:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 1/3] dt-bindings: leds: skyworks,aat1290: convert to dtschema Content-Language: en-US To: Krzysztof Kozlowski , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20220607085343.72414-1-krzysztof.kozlowski@linaro.org> From: Jacek Anaszewski In-Reply-To: <20220607085343.72414-1-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220609_132822_693742_968C3259 X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On 6/7/22 10:53, Krzysztof Kozlowski wrote: > Convert the Skyworks Solutions, Inc. AAT1290 Current Regulator bindings > to DT Schema. > > Signed-off-by: Krzysztof Kozlowski [...] > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + // Ct = 220 nF, Rset = 160 kOhm > + led-controller { > + compatible = "skyworks,aat1290"; > + flen-gpios = <&gpj1 1 GPIO_ACTIVE_HIGH>; > + enset-gpios = <&gpj1 2 GPIO_ACTIVE_HIGH>; > + > + pinctrl-names = "default", "host", "isp"; > + pinctrl-0 = <&camera_flash_host>; > + pinctrl-1 = <&camera_flash_host>; > + pinctrl-2 = <&camera_flash_isp>; > + > + led { > + label = "flash"; Why are you adding label? It is deprecated, but has the precedence over new function and color for backwards compatibility, so it would make those unused by the driver now. Please drop the label from this example. > + function = LED_FUNCTION_FLASH; > + color = ; > + led-max-microamp = <520833>; > + flash-max-microamp = <1012500>; > + flash-max-timeout-us = <1940000>; > + }; > + }; -- Best regards, Jacek Anaszewski _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel