From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C5CCCD1292 for ; Thu, 4 Apr 2024 07:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kYiuSM2/6HusvaRDJcMHCLsxX8zROL2JnedmwfhT4vw=; b=eF0o9WSUgeBw3N KMxrNc39cv7PHclW2oVrRRdkhbB99KbdgCvftty8RSIr1hxBsad7bUgCenICShDiGYxMczhzsR+Nq 7SKdP8UQJcqZxPyAP9ci3M20bBpJQOeUUPeMF2kpDA244Ld5kJ4hqHZqala8xoJceosQ2zWd0EPoN SctuY5D835k8fkU94k6Ej9ItrSQZeGoZ04ik2psdeEAWqWYhm3qKEtQuUH7idp7Bqi33ObG8fj3In VjgY3cHGxnGNYZWn4NqY798xDvIVGlWjt7LpRaGCnOq7pj76iVFFp9vidEomCjozdXD8h93O/Vdy/ dXLILM1AqgHoEd4tHJhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsHRp-00000001d0l-2hmp; Thu, 04 Apr 2024 07:23:46 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsHRl-00000001cyE-0UvW for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2024 07:23:42 +0000 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-56e0a8733d8so622327a12.2 for ; Thu, 04 Apr 2024 00:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712215412; x=1712820212; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=qoKp3ietYjXVwlK1qyyowUsmILGtAZ83ZV038OqgG/I=; b=KsdfMZ0VLxA5AjBrz3xpMOL/y0o9IRtjw+HoyM5Kqxydf0VKNLGdOR0IGZGou7hR2v Hwticvy9KefrtGuCeIion4mDfdl4PEPKvQC7iKwBPS6qMUB+D/zklEdQXR/q0JwcS/IL r5fDY6QyMmDBqmJiL5w+QcrSO2517twrM1PoeC4qq6/l9Bw0LMZM6L4IHwcz9WrGPnpO wMG5Pmwk2Af2dxk0bs01ngNBLgwru3+LDKWHlOk5WGuiOAwCnRq5bC4JcDvD6/AoP2IJ aSSGfQW2ckTFC+Cj+jI4G5LwCXyhMcZc5N9VgZCV05s2FdcjQtNvwM5riCCKQRwkoHOd aO2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712215412; x=1712820212; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qoKp3ietYjXVwlK1qyyowUsmILGtAZ83ZV038OqgG/I=; b=LWZnkQjSg3cOnxTExWhnm8DLEUaUJdDPGyeW9ApruIzsZLY8bI3SmcSrbWE07eV2HU E9Q7OECMxbmKCqyPqpOTtkVUURvK5xYdWpuHmx+KYq7EtTCVrwrqc09KMSk0yw8Ugfen vnJBxpc/Jq7c7zBvl0dfKZ52tHNRw6FM7ErSen3rXKawMj1wBPsNXoB9oGLsRiWYDbzc ZRik7+ynBfxR6Lz21ddn/SJSumINZEYCiotYsnydNZXh4Ls6EwevU6LN+IxDo8NzYSWY e73mQc8P61fKo9KNpoB6XuMUZsiTlj38gcubJGEK6PB3A94XUx6oNTSr9TEQkdcG/8yl 1BCw== X-Forwarded-Encrypted: i=1; AJvYcCUkRUSe6vp+xCOMk9kRHuvdnZJqr+OeoTFRQHWGapr5/FMJe0mJTdS0koZFGRad9GcJnSc6IwIH+DF98Iim+TupFAQSqeGBX4AVfjAmveikCfbsKec= X-Gm-Message-State: AOJu0YzuoJXw7CiJaMkZ9BkDU0H4tAEbRa93Us0d5W7zOMIZLdp6GSRk Y+YYDOYIKkHRqyAC2pZlgtnOC3dSJt2DPgvLGSYhxWTx6PIwEkahfw2jGknwXrE= X-Google-Smtp-Source: AGHT+IFcJeD2EvWnHL85kO8MUwgmZU5Y0OIrgm8eUvLfu9ihlvaIopRpMGfP5G9oEemWuCKoLa7gGQ== X-Received: by 2002:a50:9f22:0:b0:56b:a077:2eee with SMTP id b31-20020a509f22000000b0056ba0772eeemr1125203edf.4.1712215412338; Thu, 04 Apr 2024 00:23:32 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id o2-20020aa7dd42000000b00568abb329a3sm8856010edw.88.2024.04.04.00.23.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Apr 2024 00:23:31 -0700 (PDT) Message-ID: Date: Thu, 4 Apr 2024 09:23:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] usb: dwc3: exynos: Use devm_regulator_bulk_get_enable() helper function To: Anand Moon , Thinh Nguyen , Greg Kroah-Hartman , Alim Akhtar Cc: Christophe JAILLET , Johan Hovold , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240404071350.4242-1-linux.amoon@gmail.com> <20240404071350.4242-6-linux.amoon@gmail.com> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240404071350.4242-6-linux.amoon@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_002341_278112_3EB57B90 X-CRM114-Status: UNSURE ( 9.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/04/2024 09:13, Anand Moon wrote: > Use devm_regulator_bulk_get_enable() instead of open coded > 'devm_regulator_get(), regulator_enable(), regulator_disable(). I fail to see how did you replace open-coded suspend/resume paths. > > Signed-off-by: Anand Moon > --- > V2: no changes, did not find any regression in pm suspend/resume. No, that's not equivalent code. No explanation in commit msg. You already got comments on this and nothing improved. You just entirely ignored received comments. That's not how it works. I don't think you understand the code and Linux driver model. This patch repeats several previous attempts with similar issues: no logic behind a change. NAK. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel