From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01743C433F5 for ; Mon, 21 Feb 2022 06:21:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=y/jSS5PpR/++d3OKX+5hgBeQ9UjbDwlxSoO6S65t5Pw=; b=JspoQ3WY0/WBE/jreVGZVqa9Yz gthcyT7MWV78wqederH8g1jUesOBabSY0smp7xtf+S8Qy6odqZFUfUd/DDTocssfFkZ+X8gJ9+Bd6 XKPAz33BL++E941vLit0D3gCb7B7eEOrsJQC6YOn5HmvUUyVmx5v5VxnU1lsD4UaTaq6Ux9ZfaDNi pUaj0robSRqnDzkMkWAW0xio3GWsyhKYTX7+nI3DZ5KslvJwlXYhX/itRG60+Q4m+vrNcNCi7ZtEZ BNTHv3f54q7YDNFUUV583+gdfB8HdY2od33ctJSeyJuVv+vq0FHwKO4HXBspMTzTf4Imh/x7OZSiq wziuIsrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM230-003eZZ-Gl; Mon, 21 Feb 2022 06:19:46 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM22h-003eS3-1z; Mon, 21 Feb 2022 06:19:29 +0000 Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4K2BtB2dDnz9sp9; Mon, 21 Feb 2022 14:17:38 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 21 Feb 2022 14:19:20 +0800 Received: from [10.174.178.55] (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 21 Feb 2022 14:19:18 +0800 Subject: Re: [PATCH v20 2/5] arm64: kdump: introduce some macros for crash kernel reservation To: Baoquan He CC: Thomas Gleixner , Ingo Molnar , Borislav Petkov , , "H . Peter Anvin" , , Dave Young , Vivek Goyal , Eric Biederman , , Catalin Marinas , Will Deacon , , Rob Herring , Frank Rowand , , "Jonathan Corbet" , , Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou , "John Donnelly" , Dave Kleikamp References: <20220124084708.683-1-thunder.leizhen@huawei.com> <20220124084708.683-3-thunder.leizhen@huawei.com> <69da7ed5-4ef4-3655-8965-4181c7d7bf0b@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: Date: Mon, 21 Feb 2022 14:19:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220220_221927_528244_025EDE50 X-CRM114-Status: GOOD ( 18.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/2/21 11:22, Baoquan He wrote: > On 02/14/22 at 02:22pm, Leizhen (ThunderTown) wrote: >> >> >> On 2022/2/11 18:39, Baoquan He wrote: >>> On 01/24/22 at 04:47pm, Zhen Lei wrote: >>>> From: Chen Zhou >>>> >>>> Introduce macro CRASH_ALIGN for alignment, macro CRASH_ADDR_LOW_MAX >>>> for upper bound of low crash memory, macro CRASH_ADDR_HIGH_MAX for >>>> upper bound of high crash memory, use macros instead. >>>> >>>> Signed-off-by: Chen Zhou >>>> Signed-off-by: Zhen Lei >>>> Tested-by: John Donnelly >>>> Tested-by: Dave Kleikamp >>>> --- >>>> arch/arm64/mm/init.c | 11 ++++++++--- >>>> 1 file changed, 8 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c >>>> index 90f276d46b93bc6..6c653a2c7cff052 100644 >>>> --- a/arch/arm64/mm/init.c >>>> +++ b/arch/arm64/mm/init.c >>>> @@ -65,6 +65,12 @@ EXPORT_SYMBOL(memstart_addr); >>>> phys_addr_t arm64_dma_phys_limit __ro_after_init; >>>> >>>> #ifdef CONFIG_KEXEC_CORE >>>> +/* Current arm64 boot protocol requires 2MB alignment */ >>>> +#define CRASH_ALIGN SZ_2M >>>> + >>>> +#define CRASH_ADDR_LOW_MAX arm64_dma_phys_limit >>>> +#define CRASH_ADDR_HIGH_MAX MEMBLOCK_ALLOC_ACCESSIBLE >>> >>> MEMBLOCK_ALLOC_ACCESSIBLE is obvoiously a alloc flag for memblock >>> allocator, I don't think it's appropriate to make HIGH_MAX get its value. >> >> Right, thanks. >> >>> You can make it as memblock.current_limit, or do not define it, but using >>> MEMBLOCK_ALLOC_ACCESSIBLE direclty in memblock_phys_alloc_range() with >>> a code comment. >> >> This patch is not required at present. These macros are added to eliminate >> differences to share code with x86. > > So this patch may not be needed in this series. It can be added in > another post when you start to do the clean up and code unification > among ARCHes, with my udnerstanding. At that time you can consider how > to abstract the common code to handle the difference. Yes, it should be merged with the v20 3/5. > > . > -- Regards, Zhen Lei _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel