From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6284BC46467 for ; Tue, 10 Jan 2023 16:51:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=47P62dElogOP7vjT5/H+5ZW3Rr2tfy8W1G5BTRL1ROQ=; b=jlv0yuLpERou9t uCdIBXEW9WfEDctig45XhDOTFaZVOF9U9i9TLfxVrnq/Afa0NDd1RzSJaVvMoXSjEUNVyqsz6w/6L x1esCG3Pn2k1dNgFTBdmIrQGLul8SQEusY5PIfx5BJjCUrQtBH9Qzlk2fHkjFwcnxSxQqvR0waGTI C+wl/zTdko/0hFYv9K8C0jRJgYBW87hNnWTVqPJEGwkDARY/Cr4GrXZfvgNyD3usjTt5rld8++/EA NMs923wpwphkSAxbYEOs/splxTkId0xtl0z3I4Q1AaH/1QICuouWwqB7cC33/IHsuWii/PuUr/gWD Cqrqr8B8vzF89dTc/BaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFHpI-007rgV-Hj; Tue, 10 Jan 2023 16:50:16 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFHpD-007reY-O0 for linux-arm-kernel@lists.infradead.org; Tue, 10 Jan 2023 16:50:14 +0000 Received: by mail-wm1-x335.google.com with SMTP id m8-20020a05600c3b0800b003d96f801c48so12404544wms.0 for ; Tue, 10 Jan 2023 08:50:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9U2vkqeNPnuLgvyU5Iop3/31OAoHhhgthjk0IuFoFz0=; b=ITLZMChe5boXw2gQzPhfiozUcLZrTEqGsL6zJHuVNGykVWVnb7u+au0EqEyAhl/Ms/ +nwrJ13j52NAUfM6Pu9hYrQPp5kiL32bTBva0K0kR8d0td+SiDMN2gfTsA1V1XyIoWt6 vA8kaCgUW9elTlnFF69jRfugaScmMAw0HNKx0IDSg4zE560aHPg6GS9vdNx6CnF60idE /pmguOib8PGpv/e+1znRL6TkFXZBLCL3l4Oe+uayNifRqrG2jGriaCI06RoOiXSNTDTE EF1zDFTRc78Piv8FFpJF3S2RIQfLLVsEuKif6+fGwQIchJ22teyHdjJ2ZVUNPtnE4+UO MC9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9U2vkqeNPnuLgvyU5Iop3/31OAoHhhgthjk0IuFoFz0=; b=6k1ys5fYJwde5Fqh877dVpPjyxxEPe9ts3LmMsOkHcMUurJRlW6SA/pf8Jg/STUAFP pzrj3aak+QjuJZJp8B/KLYNC5O86CTQ619mA+KyLkHS/7VGYoVWSS0+ZRFzKmSRN1pKw H0mNz8td/7yhCynbm3AohUPmys6DI+GtIeR6nfhEmglhI94/BFB6tFD5KyAl/DrHNOOa dMwonLDTYyTmQQo/8oi925IEmUgu+d10GGuAkv7VeXhhnlnOo4MIz8EFsK0J1bhHkjA5 vrL8XQN6vbza/DH/Dy0yvueTzHDrHxCNELgiDTGAk5wGMJygKiiiqSrUdKnsRnbqTA9W xNSQ== X-Gm-Message-State: AFqh2kqiO5IBhrS1qSmeH6PMMkKm/PABzQFvCt2ELPrgKc1F1Kn2M0K/ ulMtXs4zcRQX0temClCH+CQywjcD8KNZjTDXTqo= X-Google-Smtp-Source: AMrXdXvywm4oOZgUew61U5Q1KSQzIVIzNhE8EUgOJRkgXURQHsHI78bVf2p9Gci+Lz5asNzOYVCsaw== X-Received: by 2002:a1c:7410:0:b0:3cf:8957:806e with SMTP id p16-20020a1c7410000000b003cf8957806emr50769710wmc.5.1673369407323; Tue, 10 Jan 2023 08:50:07 -0800 (PST) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id n14-20020a05600c4f8e00b003c6b7f5567csm3083942wmq.0.2023.01.10.08.50.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 08:50:06 -0800 (PST) Message-ID: Date: Tue, 10 Jan 2023 16:50:05 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] nvmem: core: fix return value Content-Language: en-US To: "Russell King (Oracle)" Cc: linux-arm-kernel@lists.infradead.org References: From: Srinivas Kandagatla In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230110_085011_826136_70290172 X-CRM114-Status: GOOD ( 20.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russell, On 10/01/2023 16:48, Russell King (Oracle) wrote: > Dan Carpenter points out that the return code was not set in commit > 60c8b4aebd8e ("nvmem: core: fix cleanup after dev_set_name()"), but > this is not the only issue - we also need to zero wp_gpio to prevent > gpiod_put() being called on an error value. > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Fixes: 60c8b4aebd8e ("nvmem: core: fix cleanup after dev_set_name()") > Signed-off-by: Russell King (Oracle) > --- > drivers/nvmem/core.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index 082cda7ac199..1ee2e9255f7b 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -781,8 +781,11 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) > if (!config->ignore_wp) > nvmem->wp_gpio = gpiod_get_optional(config->dev, "wp", > GPIOD_OUT_HIGH); > - if (IS_ERR(nvmem->wp_gpio)) > + if (IS_ERR(nvmem->wp_gpio)) { > + rval = PTR_ERR(nvmem->wp_gpio); > + nvmem->wp_gpio = NULL; > goto err_put_device; I have already added this change while applying v3 patches. thanks, --srini > + } > > kref_init(&nvmem->refcnt); > INIT_LIST_HEAD(&nvmem->cells); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel