From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B9B4C30658 for ; Tue, 2 Jul 2024 10:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P92+0FeJgLTWh83yvzOS18H2gViBFUz3gdnOBY11d/4=; b=EWayeCTMGAw1zlElBSnpY4dxVz WFILJsSIQH1usfDUwKqv6w+UlXhIlTZ8KPUKszbmu9h06s5/oTqWxIBGcjl0arYuW6Y2lae+8dRhy TpDE2cT11y/i6fQ2DhUlNqbE0lfhJ44TGTjnhFmZxZ/g5hpNex9nmJXIbAh+8vHNc8DxIwS6fUV08 oqKByTMImsGWON2vtVBxg2QXGMIpMKO+rIa1MUup2W0FMSHg158wDbpNe6Kl13E3CRbTYAIjA3RfV OTJYUYfTfaCtsWXlfiwLX7DmFNaI62d7dbrwhSsnLkiiqQc6EmWvN5VsfKGjYKs6CTv8izFxsITEi 11p0tOSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOb2l-00000006OHk-2dSU; Tue, 02 Jul 2024 10:47:27 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOb2X-00000006OBV-3jZF for linux-arm-kernel@lists.infradead.org; Tue, 02 Jul 2024 10:47:15 +0000 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-52e764bb3fbso5301219e87.3 for ; Tue, 02 Jul 2024 03:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719917232; x=1720522032; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=P92+0FeJgLTWh83yvzOS18H2gViBFUz3gdnOBY11d/4=; b=lRNg2gnImeqZc8/tONcqgs+93IWiI7PLhdmf2u9z/YC2k34FCsKH5b6LtIsqrqJrZx wuVPtIcIDQCs8La+ANfmQx6Y8g1kJvRyaQSWFl72CT/h0woyXYCkwOaOPc2RHH2TXB4W 5mQdD1x4aF9gxwWjziGCUB3Cg098HcGKhMK9yDrC+S6BiMGqKK6CD0xGNhzDB2W7YXcm dQoarGsj8Q2hPxrwJsBzWp0YJL+3NdbhNdRKETGeh52zVG1ZLELJ1/ioNtbizy7mRvV4 JorjnZ76IQtLKG3FJQJW7S7AdlO/KZR7j4Rjyrlw2lpb0+MPy87pByslyBHQ/ZyrFd2g RP7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719917232; x=1720522032; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P92+0FeJgLTWh83yvzOS18H2gViBFUz3gdnOBY11d/4=; b=Y9JNOWN5xGfPfHHoz22+PJLwfkyE051DPdTC53UYFB6dPDUabKlwB18iSH/Q4Yh7L6 5WQME6gPCJixqw7DjYZEGkSPS8fJ/lFCbKRN3hFT5heimv/9Th6R2PxRkApJcAycN+9v xNOQJhs5wUkRGWQPL82S/adVmOWWq4A1gtf+remIrNxEB9V3QWj362ml6mdzI1jysHbu wPoDcpUU4UZDAp3aOS8qzFxGzHzij8sB+OQSRpNiACcWWcyn2oVP2Uf3S3jIM5cQPj9m G2IezDet4e7o2c9nOdDj7v5H0BkL3XmGdK0BQNOfSsHxVAmcJBOOvtHvJLOKQjMPXN5R a6DQ== X-Forwarded-Encrypted: i=1; AJvYcCVa/r/L4Kq1dsWwC8vVqmt+PjaY+lmW87ZOvofl86JXmsZR/16CMuKwz4ubflzctNRF6X/gVIbtTXBFHAY1KLgdq9h5l6JLLG7IxeofMR7tLetJtBQ= X-Gm-Message-State: AOJu0YwP5zGndXf8nTX0K3YylU26Ms0ehn/HcmgokKNQrsNygk7bWVcA 7HWOwHPONMla+Eg7cqnLIZ5//L3ETHNAVPUFBnHvrDPuZXsGDv2qG6xkXAAQPyM= X-Google-Smtp-Source: AGHT+IGsyY8yXpt8X5axUiNk+A3akY1RMqxa/35yt/ICICyWTKIxiqpZt3x3eK+iUQN8LDGEn+W8hA== X-Received: by 2002:a05:651c:b0b:b0:2ec:56d1:f28 with SMTP id 38308e7fff4ca-2ee5e3b241fmr62678771fa.26.1719917231561; Tue, 02 Jul 2024 03:47:11 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.137]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5861324eb41sm5539498a12.30.2024.07.02.03.47.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jul 2024 03:47:10 -0700 (PDT) Message-ID: Date: Tue, 2 Jul 2024 12:47:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/3] ARM: dts: aspeed: Add IEISystems NF5280M7 BMC machine To: George Liu , linux-aspeed@lists.ozlabs.org Cc: devicetree@vger.kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au References: <20240701105259.972135-1-liuxiwei@ieisystem.com> <20240701105259.972135-3-liuxiwei@ieisystem.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240701105259.972135-3-liuxiwei@ieisystem.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240702_034713_984599_1145D4B5 X-CRM114-Status: GOOD ( 11.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/07/2024 12:52, George Liu wrote: > The IEISystems NF5280M7 is an x86 platform server with an > AST2600-based BMC. > This dts file provides a basic configuration for its OpenBMC > development. > ... > + i2c613 = &i2c6s1ch3; > + i2c614 = &i2c6s1ch4; > + i2c615 = &i2c6s1ch5; > + i2c616 = &i2c6s1ch6; > + i2c617 = &i2c6s1ch7; > + i2c620 = &i2c6s2ch0; > + i2c621 = &i2c6s2ch1; > + i2c622 = &i2c6s2ch2; > + i2c623 = &i2c6s2ch3; > + i2c624 = &i2c6s2ch4; > + i2c625 = &i2c6s2ch5; > + i2c626 = &i2c6s2ch6; > + i2c627 = &i2c6s2ch7; > + }; > + > + chosen { > + stdout-path = &uart5; > + bootargs = "console=ttyS4,115200n8 earlycon"; earlycon is debugging tool, not production, drop. This leads to totally redundant bootargs, so drop it entirely. > + }; > + > + memory@80000000 { > + device_type = "memory"; > + reg = <0x80000000 0x80000000>; > + }; > + ... > +&i2c2 { > + status = "okay"; Missing blank line (everywhere) > + pca9546@70{ Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "nxp,pca9546"; > + reg = <0x70>; > + bus2_mux70_0: i2c@2{ > + reg = <0>; > + tmp112@49{ Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Everywhere: missing space before { > + compatible = "ti,tmp112"; > + reg = <0x49>; > + label = "Inlet_Temp"; > + }; Missing blank line > + emc1413@4c{ Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "microchip,emc1413"; > + reg = <0x4c>; > + label = "Outlet_Temp"; > + }; > + }; > + }; > +}; > + > +&i2c4 { > + multi-master; > + status = "okay"; > + ipmb0@10 { > + compatible = "ipmb-dev"; > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; > + i2c-protocol; > + }; > +}; > + > +&i2c5 { > + bus-frequency = <1000000>; > + multi-master; > + status = "okay"; > + pca9546@70{ Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Above comment applies to multiple places. > + compatible = "nxp,pca9546"; > + reg = <0x70>; > + bus5_mux00: i2c@0 { > + reg = <0>; > + status = "okay"; Where is it disabled? > + vrmp2888@76 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "mps,mp2888"; > + reg = <0x76>; > + }; > + vrmp2888@72 { > + compatible = "mps,mp2888"; > + reg = <0x72>; > + }; > + vrmp2888@62{ > + compatible = "mps,mp2888"; > + reg = <0x62>; > + }; > + }; > + bus5_mux01: i2c@1{ > + reg = <1>; > + status = "okay"; Where is it disabled? > + vrmp2888@76{ Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "mps,mp2888"; > + reg = <0x76>; > + }; > + vrmp2888@72 { > + compatible = "mps,mp2888"; > + reg = <0x72>; > + }; > + vrmp2888@62{ > + compatible = "mps,mp2888"; > + reg = <0x62>; > + }; > + }; > + bus5_mux02: i2c@2{ > + reg = <2>; > + }; > + bus5_mux03: i2c@3{ > + reg = <3>; > + }; > + }; > +}; > + > +&i2c6 { > + multi-master; > + status = "okay"; > + > + i2c-switch@70 { > + compatible = "nxp,pca9548"; > + reg = <0x70>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + i2c6s0ch0: i2c@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0>; > + > + eeprom@50 { > + compatible = "atmel,24c256"; > + reg = <0x50>; > + }; > + pca9548@71 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "nxp,pca9548"; > + reg = <0x71>; > + i2c-mux-idle-disconnect; > + > + i2c6s1ch0: i2c@0 { > + }; > + }; > +}; > + > +&i2c7 { > + multi-master; > + #retries = <3>; > + status = "okay"; > + > + adc128d818@1d { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "ti,adc128d818"; > + reg = <0x1d>; > + ti,mode = /bits/ 8 <0x01>; > + }; Best regards, Krzysztof