From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54783C433E0 for ; Fri, 31 Jul 2020 09:35:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FB9120829 for ; Fri, 31 Jul 2020 09:35:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GsgYXnvR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FB9120829 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5hYZeLlh/ymiUIplWkPMyjTBhixhF/dPZv6qEQNpfTI=; b=GsgYXnvRFHFKce9J2tziiYh71 pCskYBgtkArT78JBpKvWTKLw49IbBIxaFUr1nkumTTl6nfJ2C05DgQ5J/YsP8SH8pZBxdsfQ/mqJ4 YuFplsLdKCIayma39nw20AMijk0CWyhoX8YRSDfWNM2vVH24UURMaqr3iLSy2qIjO1bUqo4Ex9D43 D0IJm/DYOkM5NrxcdL39Ni7iOv1Ahso+CY5TUKxZZfbj7rzTH6bNuGqSby3GBsgzguDM3tXb2MwKR T+QwO4jNPQmJo0ZDxGU/Ts5gVxfki58+l50+jgWyow6evJR/9UqNt4T+e2lEqW1grgKZ184T/i19u dvbxk1cMA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1RQx-0001LG-Qj; Fri, 31 Jul 2020 09:34:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1RQu-0001KU-FY for linux-arm-kernel@lists.infradead.org; Fri, 31 Jul 2020 09:34:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D21DE31B; Fri, 31 Jul 2020 02:34:28 -0700 (PDT) Received: from [10.37.12.83] (unknown [10.37.12.83]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7773F3F66E; Fri, 31 Jul 2020 02:34:27 -0700 (PDT) Subject: Re: [RFC PATCH 04/14] coresight: etm4x: Free up argument of etm4_init_arch_data To: mathieu.poirier@linaro.org References: <20200722172040.1299289-1-suzuki.poulose@arm.com> <20200722172040.1299289-5-suzuki.poulose@arm.com> <20200730173131.GA3155687@xps15> From: Suzuki K Poulose Message-ID: Date: Fri, 31 Jul 2020 10:39:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20200730173131.GA3155687@xps15> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200731_053432_654958_0A43CAA7 X-CRM114-Status: GOOD ( 24.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/30/2020 06:31 PM, Mathieu Poirier wrote: > On Wed, Jul 22, 2020 at 06:20:30PM +0100, Suzuki K Poulose wrote: >> etm4_init_arch_data is called early during the device probe, >> even before the coresight_device is registered. Since we are >> about to replace the direct access via abstraction layer, we >> need a way to pass in the csdev_access for the given device. >> Towards this free up the argument, which is already available >> via etmdrvdata[smp_processor_id()]. >> >> Cc: Mathieu Poirier >> Cc: Mike Leach >> Signed-off-by: Suzuki K Poulose >> --- >> drivers/hwtracing/coresight/coresight-etm4x.c | 15 +++++++++++---- >> 1 file changed, 11 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c >> index 7bb74c659c4f..67deb4a4e618 100644 >> --- a/drivers/hwtracing/coresight/coresight-etm4x.c >> +++ b/drivers/hwtracing/coresight/coresight-etm4x.c >> @@ -614,7 +614,8 @@ static const struct coresight_ops etm4_cs_ops = { >> .source_ops = &etm4_source_ops, >> }; >> >> -static void etm4_init_arch_data(void *info) >> + >> +static void etm4_init_arch_data(void *__unused) >> { >> u32 etmidr0; >> u32 etmidr1; >> @@ -622,8 +623,14 @@ static void etm4_init_arch_data(void *info) >> u32 etmidr3; >> u32 etmidr4; >> u32 etmidr5; >> - struct etmv4_drvdata *drvdata = info; >> - int i; >> + struct etmv4_drvdata *drvdata; >> + int i, cpu; >> + >> + cpu = raw_smp_processor_id(); > > Can you provide details on the motivation to use the raw_ version over the regular > one? As far as I can see in linux/smp.h there is no difference between them > unless DEBUB_PREEMPT is enabled. Even then the debug version won't complain > since the task is CPU affined. > Right, it is partly my misunderstanding. debug_smp_processor_id() is to detect cases where smp_processor_id() is called in pre-emptible contexts. This is not the case here. So it is fine to use the smp_processor_id(). I will switch to that in the next version. Thanks Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel