From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B246C433EF for ; Thu, 23 Sep 2021 08:39:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D682F6109E for ; Thu, 23 Sep 2021 08:39:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D682F6109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=bUktLv5GUZVJQyq1MY4GoDgZnnkcp9+OB6lQGUfQ0Q0=; b=R0qTlQ1V3um1uy0w0kUOeUto4e EqGlABun8luWtc0i7Cqyghw7OprPDeeDgOKlAlJSwaUuILsVA0SpMfiU1GewNIejmfeV83rwAjf91 uh6HZ4a/upcMG5HsWmZj78NlaAQnmkGPk3N99kvv8+Lt+hfRpjEoS5+wk9udcYA1XDxAlVgww0Aux GYdjFEr2i/UyENdCaOkQOT0cxXsNOvpAibZNc9wJ6Lx5D41dliEDNR8+qUc5ONl/ePiiv5uNGY7Gc W2InZgkAE3nGBWJpB8YFLn7Q4VonjWykOZlCO8N8Em1L9HtSgFBLiGdzZnpjhsDKfx5SnycvJvyan S4SmT2ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTKEQ-00AeXv-FX; Thu, 23 Sep 2021 08:37:26 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTKEM-00AeXL-VQ for linux-arm-kernel@lists.infradead.org; Thu, 23 Sep 2021 08:37:24 +0000 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18N8P641017537; Thu, 23 Sep 2021 10:37:19 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=FQ16dZSaItVi4+Z7aMBiqJoswyYlb1eZGTWTZb1KD38=; b=lMie4IjfxcnIH3PhsY+/FQUXlOabtQLEkLKGy6wR4Y9vrkwEt08Q/n4lLDfuq3oScuxe hhgLcjsco+/azDG0HYHT+47il/Sh6vSdsRNYRugxIa0SuzW7/fenhxnF+xYA6EVuvHTp fOAkMNt0tV2Fh3Dqg1ExbOjY9LXeXIvSqUZV9exM36IxzqdvtN6Dk/rJKNcSkiUr4DfE bPOB1/i62PZXOOVgQSM8ZWhiRF9pxggxfJzJLYOoluK9rlzaxBJYizAhBOaR13ROrpfq RN1I903/vug9RrbAZ7VEXf1Fz19Uf/7OsWpt1+OWOKvxtOE3pkgAiZWo/uO8X3n7DJR7 Ng== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3b8gdra1fb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Sep 2021 10:37:18 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6CE44100034; Thu, 23 Sep 2021 10:37:18 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 64D452248B6; Thu, 23 Sep 2021 10:37:18 +0200 (CEST) Received: from lmecxl1060.lme.st.com (10.75.127.48) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 23 Sep 2021 10:37:17 +0200 Subject: Re: [PATCH 2/4] i2c: stm32f7: recover the bus on access timeout To: Alain Volmat , CC: , , , , , , References: <1632151292-18503-1-git-send-email-alain.volmat@foss.st.com> <1632151292-18503-3-git-send-email-alain.volmat@foss.st.com> From: Pierre Yves MORDRET Message-ID: Date: Thu, 23 Sep 2021 10:37:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <1632151292-18503-3-git-send-email-alain.volmat@foss.st.com> Content-Language: en-US X-Originating-IP: [10.75.127.48] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-23_02,2021-09-22_01,2020-04-07_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210923_013723_350186_61AEFFC7 X-CRM114-Status: GOOD ( 20.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alain Look good to me Reviewed-by: Pierre-Yves MORDRET Regards On 9/20/21 5:21 PM, Alain Volmat wrote: > When getting an access timeout, ensure that the bus is in a proper > state prior to returning the error. > > Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver") > > Signed-off-by: Alain Volmat > --- > drivers/i2c/busses/i2c-stm32f7.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index ed977b6f7ab6..ad3459a3bc5e 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -1712,6 +1712,7 @@ static int stm32f7_i2c_xfer(struct i2c_adapter *i2c_adap, > i2c_dev->msg->addr); > if (i2c_dev->use_dma) > dmaengine_terminate_all(dma->chan_using); > + stm32f7_i2c_wait_free_bus(i2c_dev); > ret = -ETIMEDOUT; > } > > @@ -1769,6 +1770,7 @@ static int stm32f7_i2c_smbus_xfer(struct i2c_adapter *adapter, u16 addr, > dev_dbg(dev, "Access to slave 0x%x timed out\n", f7_msg->addr); > if (i2c_dev->use_dma) > dmaengine_terminate_all(dma->chan_using); > + stm32f7_i2c_wait_free_bus(i2c_dev); > ret = -ETIMEDOUT; > goto pm_free; > } > -- -- ~ Py MORDRET -- _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel