From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26032C433F5 for ; Wed, 9 Mar 2022 21:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oM09CKv57+pKakyM3pNO7C6v48XbvqY5srv98vKg7Dg=; b=dBhcgVtLJoj21vjfLcmAPxWGrV vpvlSvIT46YuRzh7g1BISJoNBhAw2UMHrF2dLMUabj6M5/cr6HXsb/6Z4xBfwKiN40DEOU+XDMwfR RXS5iqoyKMwd5RXPnoidIzG1DfT5sCHouu65mayEx5fzy5LXDBJqb0Mh2UV2osYWsDMcu6EDNFo/+ FtgYUE0eRNErfh0tGwI/2nD6hVmGgrRsZqGahydjIlToo1i8XwXBETYpOimG2y3EvojZoWwxVi/NC +yLwOLoIH5YqFmxS6vvFviWQHiirwLpJx7WbLYdqy6WYeA21aO/O9LxkYiZ2EWvvy/LuOTCJ9OciC at4RHbFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nS3xi-00AYE2-Oz; Wed, 09 Mar 2022 21:35:14 +0000 Received: from mail-il1-x12d.google.com ([2607:f8b0:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nS3xf-00AYDh-Lq for linux-arm-kernel@lists.infradead.org; Wed, 09 Mar 2022 21:35:13 +0000 Received: by mail-il1-x12d.google.com with SMTP id b14so2444204ilf.6 for ; Wed, 09 Mar 2022 13:35:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=a+PokWnNPzuahwZwgt4jPIAV6o7vc6F/8JG7kbUD8kY=; b=ShWwFzvGcsJujkNLAZaAqeWfVR5IDYk1AJRilm0azBO9Rsyk/HQ5nC/zL8OlWK0ubT +ckFb8jMtIsQuqpX2Wsi1m2IkchJ6FhSx/kjH7jkrYStjesJa93UI/eRaIn6p4LPrvUT wpf+JKms5Eg/rLCkh63Yv2QHq+DfooILaG4H8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=a+PokWnNPzuahwZwgt4jPIAV6o7vc6F/8JG7kbUD8kY=; b=Rus3zmKTb35pBc1epLfFmHdFq8tJINcUzx2rzB2KS8Ajxdcg4UheAOZALa+d9nOk0m mGqx5pmJjl1W688esVSCFmVcO3z4lFX9C190HnYCO97a4l0oLYvhMsjGOzrIASzKeLWk l1lqjkTwhdKB/9kYkWonnx9LkKX5GhfBVSGZ9p6+CeUE5CTlvaUWw5IOz6g7qlQX1GNY 0fzXjWCGmtkR0SlDzCpsY6ZsEF+mVLr9yQajAGhY0w6xtomxV4hCXjOQ+hotVE984MJI BPYD/U7kKyt6GaM75wArhYGMUtnZ9rJN1UO/NYvdutOXDcJrcx9/hqVBojt+uYnFQWd0 gmkA== X-Gm-Message-State: AOAM5323L8KSRgYadxjwaqnXT6KZQgIL6RvcOyNg0zRajFFVglgT8eeS vhoYUcCLUNhG7hBbMytQpDglBw== X-Google-Smtp-Source: ABdhPJxbFMp8hlqX5hP0ON+Zp+I2WxqvbEFtnxYMKFSDFp1BnU9g+quzdbUwAY2/4dnJPDVyo99fXw== X-Received: by 2002:a92:cdaa:0:b0:2c6:6751:dd18 with SMTP id g10-20020a92cdaa000000b002c66751dd18mr1129241ild.314.1646861709660; Wed, 09 Mar 2022 13:35:09 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id i14-20020a056e02152e00b002bee249710csm1689110ilu.15.2022.03.09.13.35.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Mar 2022 13:35:09 -0800 (PST) Subject: Re: [PATCH v1 1/3] kselftest/arm64: Fix comment for ptrace_sve_get_fpsimd_data() To: Mark Brown , Catalin Marinas , Will Deacon , Shuah Khan Cc: linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20220309115918.22469-1-broonie@kernel.org> <20220309115918.22469-2-broonie@kernel.org> From: Shuah Khan Message-ID: Date: Wed, 9 Mar 2022 14:35:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220309115918.22469-2-broonie@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220309_133511_774092_77F139B8 X-CRM114-Status: GOOD ( 17.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/9/22 4:59 AM, Mark Brown wrote: > The comment for ptrace_sve_get_fpsimd_data() doesn't describe what the test > does at all, fix that. > > Signed-off-by: Mark Brown > --- > tools/testing/selftests/arm64/fp/sve-ptrace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/arm64/fp/sve-ptrace.c b/tools/testing/selftests/arm64/fp/sve-ptrace.c > index a3c1e67441f9..6b139d5f67f1 100644 > --- a/tools/testing/selftests/arm64/fp/sve-ptrace.c > +++ b/tools/testing/selftests/arm64/fp/sve-ptrace.c > @@ -397,7 +397,7 @@ static void ptrace_set_sve_get_sve_data(pid_t child, > free(write_buf); > } > > -/* Validate attempting to set SVE data and read SVE data */ > +/* Validate attempting to set SVE data and read it via the FPSIMD regset */ > static void ptrace_set_sve_get_fpsimd_data(pid_t child, > const struct vec_type *type, > unsigned int vl) > Looks good to me. Reviewed-by: Shuah Khan thanks, -- Shuah _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel