RE: [PATCH V5] regulator: da9062: Make the use of IRQ optional

Christoph Niedermaier
2023-07-14T19:04:35Z

From: Mark Brown [mailto:broonie@kernel.org]
Sent: Thursday, July 13, 2023 6:34 PM
> On Thu, Jul 13, 2023 at 03:36:38PM +0000, Christoph Niedermaier wrote:
>> From: Mark Brown [mailto:broonie@kernel.org]
>
>>> Are there any dependencies for this patch? The fact that I acked it
>>> makes me think there were MFD parts
>
>> It's a patch series. This patch is the last one in this series, that is
>> missing to have the ability to run the DA9061/62 without a connected IRQ
>> pin. The other patches are already upstreamed and yes there are MFD parts,
>> see below:
>
> Oh, dear. Why weren't they applied, it's not even the confusion there
> was over what Reviewed-by means...
>
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>> Link: https://lore.kernel.org/oe-kbuild-all/202303082246.GuLdPL0t-lkp@intel.com/
>
>>> I really doubt that the LKP bot ran into an issue due to a system with
>>> this device without an IRQ wired up...
>
>> In V3 of this patch the kernel test robot found an issue. I had really
>> overlooked that. Thanks to LKP. I forgot to replace the irq variable in
>> the function devm_request_threaded_irq(). So it affected the path with
>> IRQ. In V4 I fixed that. In V5 I only rebased it on the current next
>> 20230713 and add Marek's Reviewed-by tag.
>
> That doesn't mean you should include tags like this, it makes it look
> like they reported the commit...

Thanks for helping me. May I asked which tags are you referring to here?

Regards
Christoph