Re: [PATCH V5] regulator: da9062: Make the use of IRQ optional

Mark Brown
2023-07-13T16:34:59Z

[-- Attachment #1.1: Type: text/plain, Size: 1277 bytes --]

On Thu, Jul 13, 2023 at 03:36:38PM +0000, Christoph Niedermaier wrote:
> From: Mark Brown [mailto:broonie@kernel.org]

> > Are there any dependencies for this patch? The fact that I acked it
> > makes me think there were MFD parts

> It's a patch series. This patch is the last one in this series, that is
> missing to have the ability to run the DA9061/62 without a connected IRQ
> pin. The other patches are already upstreamed and yes there are MFD parts,
> see below:

Oh, dear. Why weren't they applied, it's not even the confusion there
was over what Reviewed-by means...

> >> Reported-by: kernel test robot <lkp@intel.com>
> >> Link: https://lore.kernel.org/oe-kbuild-all/202303082246.GuLdPL0t-lkp@intel.com/

> > I really doubt that the LKP bot ran into an issue due to a system with
> > this device without an IRQ wired up...

> In V3 of this patch the kernel test robot found an issue. I had really
> overlooked that. Thanks to LKP. I forgot to replace the irq variable in
> the function devm_request_threaded_irq(). So it affected the path with
> IRQ. In V4 I fixed that. In V5 I only rebased it on the current next
> 20230713 and add Marek's Reviewed-by tag.

That doesn't mean you should include tags like this, it makes it look
like they reported the commit...

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]