From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: cpuidle: Avoid memleak if init fail
Date: Tue, 3 Oct 2017 15:21:27 +0200 [thread overview]
Message-ID: <d785929a-a6af-b803-d34d-a7138102f55f@linaro.org> (raw)
In-Reply-To: <1504211076-2331-1-git-send-email-stefan.wahren@i2se.com>
On 31/08/2017 22:24, Stefan Wahren wrote:
> In case there are no DT idle states defined or
> cpuidle_register_driver() fails, the copy of the idle driver is leaked:
>
> unreferenced object 0xede0dc00 (size 1024):
> comm "swapper/0", pid 1, jiffies 4294937431 (age 744.510s)
> hex dump (first 32 bytes):
> 94 9e 0b c1 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 57 46 49 00 00 00 00 00 00 00 00 00 00 00 00 00 WFI.............
> backtrace:
> [<c1295f04>] arm_idle_init+0x44/0x1ac
> [<c0301e6c>] do_one_initcall+0x3c/0x16c
> [<c1200d70>] kernel_init_freeable+0x110/0x1d0
> [<c0cb3624>] kernel_init+0x8/0x114
> [<c0307a98>] ret_from_fork+0x14/0x3c
>
> So fix this by freeing the unregistered copy in error case.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Fixes: d50a7d8acd78 ("ARM: cpuidle: Support asymmetric idle definition")
> ---
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2017-10-03 13:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 20:24 [PATCH] ARM: cpuidle: Avoid memleak if init fail Stefan Wahren
2017-09-01 1:33 ` Leo Yan
2017-09-01 5:49 ` Stefan Wahren
2017-09-01 6:56 ` Leo Yan
2017-09-01 7:08 ` Stefan Wahren
2017-09-01 8:10 ` Leo Yan
2017-10-03 13:21 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d785929a-a6af-b803-d34d-a7138102f55f@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).