From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA3F7EC8732 for ; Thu, 7 Sep 2023 14:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3xLUOpfBR7x/L7+9ybDLrjvnKtX/MN9c7nJq0jksaag=; b=kVEpTImSRiLwea vOUVt78kuU3w3L2YXwmlv0AFLkxrxCq0xBAYOGTC6iybtjxyI+uSCafV445zKuVVD0GltO6Vyfd// /hqWGp9cMLrGrPAEAbElh+3TbzTEpkCVMzdqfE8gExtUp1k6gfMQ3fpZroZOufzgczq/rDf6lvRdt X4LX3AbHP3Wr9Srh3YVJPDiQ79NZ/l3TciePquPj634Y63uhgGlYalMwEp+kSQLvCJauTh9wUC/K8 XnrOi+JEgZXJV0klmzNdGiQRlpX6yDxOERsPDeSl48b0PNRyMCjW703B4TmAWIfCYK/8bYdo4/jU4 fEV6AFl28zq0mfZQ/zuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qeFru-00CBoW-27; Thu, 07 Sep 2023 14:20:26 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qeFrq-00CBnS-2W for linux-arm-kernel@lists.infradead.org; Thu, 07 Sep 2023 14:20:24 +0000 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 387DtEDL004974; Thu, 7 Sep 2023 14:20:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=t0M+lC4rAAagaeLRUqBbxq9Tce0AeCSEV2tAjKZ6dY8=; b=Jwdnhl850xaIrfI9nDU2q0MLnU79ixvnWamUIsjgcX9xmiXN6ErU9xpYydt/t5AkxhbK H/C0Ox1QI4Zu2i57/0KSDQWeOySn8FASWLDgmd/Hq+W2VuEMbOn0y9tup4nn0HlFMlJl Z7SSXjG+FNlTJg3QF1ETM7r3fC8ihvcPUe82WI8B3A2Fp+Nu59JMuturi7+YXXeU7l47 l/Vw3c1oBAirI/svlRvNlgVkr0BvAh7T6EGeBTSySrEXnKuaq/9oxDpEuI0QyCOGD5ek dUpn6SRTdwz+wqFWqd9Xqr5F+X6D0b6SH08HmNouZ3i3lU0L9G3CMzD8gqLVjG6HNAQ6 LQ== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3sy4bqhftn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Sep 2023 14:20:02 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 387EK1GB011421 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 7 Sep 2023 14:20:01 GMT Received: from [10.110.56.75] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Thu, 7 Sep 2023 07:20:00 -0700 Message-ID: Date: Thu, 7 Sep 2023 07:20:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 0/3] Add qcom hvc/shmem transport To: Sudeep Holla CC: Krzysztof Kozlowski , , , , , , , , , , , References: <20230718160833.36397-1-quic_nkela@quicinc.com> <20230811175719.28378-1-quic_nkela@quicinc.com> <3342d8bf-5281-c082-cb9a-7a027b413237@quicinc.com> <20230907103619.2kqh7tfivwdfm5rd@bogus> Content-Language: en-US From: Nikunj Kela In-Reply-To: <20230907103619.2kqh7tfivwdfm5rd@bogus> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: weVwHyWYPHpU_KGtnAQ4_EN4Hk8UIdIE X-Proofpoint-ORIG-GUID: weVwHyWYPHpU_KGtnAQ4_EN4Hk8UIdIE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-07_07,2023-09-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1011 priorityscore=1501 lowpriorityscore=0 malwarescore=0 suspectscore=0 phishscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 impostorscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309070127 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230907_072022_868850_BD7A0F3D X-CRM114-Status: GOOD ( 32.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/7/2023 3:36 AM, Sudeep Holla wrote: > On Tue, Sep 05, 2023 at 06:37:14PM +0200, Krzysztof Kozlowski wrote: >> On 05/09/2023 18:06, Nikunj Kela wrote: >>> On 8/11/2023 10:57 AM, Nikunj Kela wrote: >>>> This change introduce a new transport channel for Qualcomm virtual >>>> platforms. The transport is mechanically similar to ARM_SCMI_TRANSPORT_SMC. >>>> The difference between the two transports is that a parameter is passed in >>>> the hypervisor call to identify which doorbell to assert. This parameter is >>>> dynamically generated at runtime on the device and insuitable to pass via >>>> the devicetree. >>>> >>>> The function ID and parameter are stored by firmware in the shmem region. >>>> >>>> This has been tested on ARM64 virtual Qualcomm platform. >>>> >>>> --- >>>> v3 -> fix the compilation error reported by the test bot, >>>> add support for polling based instances >>>> >>>> v2 -> use allOf construct in dtb schema, >>>> remove wrappers from mutexes, >>>> use architecture independent channel layout >>>> >>>> v1 -> original patches >>>> >>>> Nikunj Kela (3): >>>> dt-bindings: arm: convert nested if-else construct to allOf >>>> dt-bindings: arm: Add qcom specific hvc transport for SCMI >>>> firmware: arm_scmi: Add qcom hvc/shmem transport >>>> >>>> .../bindings/firmware/arm,scmi.yaml | 67 ++--- >>>> drivers/firmware/arm_scmi/Kconfig | 13 + >>>> drivers/firmware/arm_scmi/Makefile | 2 + >>>> drivers/firmware/arm_scmi/common.h | 3 + >>>> drivers/firmware/arm_scmi/driver.c | 4 + >>>> drivers/firmware/arm_scmi/qcom_hvc.c | 232 ++++++++++++++++++ >>>> 6 files changed, 293 insertions(+), 28 deletions(-) >>>> create mode 100644 drivers/firmware/arm_scmi/qcom_hvc.c >>> Gentle Ping! > Pong ! > >> It's third ping these two weeks from Qualcomm. Folks, it is merge >> window. What do you think will happen with your ping during this time? >> > +1 > > Okay, here is the deal with this patch set. As you are aware that a previous > merged solution was abandoned by Qcom in a single kernel release cycle. So > I decided to ignore this for one or 2 kernel release cycle to make sure > Qcom makes up their mind on the design and then we can see how to proceed. > Qcom must understand upstream kernel is not a playground to push their > design which they might decided to drop support for in such short period. > Please understand the upstream kernel supports platforms that are more than > few decades old. It is not like the mobile platforms that are hardly supported > for couple of years. And similarly, we push core support if and only if we > know for sure it will be used on some platform. I trusted Qcom with the > previous extension of SMC/HVC transport but I was proven wrong. > > Also, I definitely don't like the way you have copied the whole smc.c > and changed it to Qcom's need and made it qcom_hvc.c. Just add the required > changes in smc.c. > > -- > Regards, > Sudeep Completely understand your concerns and extending my apologies once again on the patch that was abandoned. I will rework the patch to include changes in smc.c. Thanks so much for your response! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel