From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8730C5479D for ; Fri, 6 Jan 2023 08:42:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pNiAXbDpVINyrpLIp5By2qpYFULdq51frK7RbyT2LIg=; b=2Rm9MuJZCJI9t1 ZjxjqGtPG58NKghawK0kmQ1OQ2f5mkuTT7uiK7FkL6YNrBwPrt5UEJm5kS7juLpE4DnMgfxQlGsJa w4lLc3kVSh9s+I8hj1bY5zVpvLXJT3V0rStERVu19NiKmkh5nvwVS70e3dqD80lnuTFzoE57ZY600 DXvpp6ED8zOeNl/tTqJTBPw/ZAP2dS4grM+ufWjiHdj2C6F9AWg7IA9+0BsopvkReV3B+TWmOjgmu NYySlWn1GI0miKn0AgdsaCUpM9qLk1cLE/fnIru8PQz+yLitkBHc5bkWhnI/Cs/Nsx3Ji2Lhnd1z8 YXAIBe+hYJaXzEu8/ZmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDiHn-006hro-IY; Fri, 06 Jan 2023 08:41:11 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDiHi-006hpQ-1d for linux-arm-kernel@lists.infradead.org; Fri, 06 Jan 2023 08:41:10 +0000 Received: by mail-wm1-x334.google.com with SMTP id b24-20020a05600c4a9800b003d21efdd61dso598325wmp.3 for ; Fri, 06 Jan 2023 00:41:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZQ+8HIJ9qo+uvPNDlSOLAl09pspajE/jGQLqn+GctwE=; b=g+bL/kz4N0u4j4m6b4dDBq0ByVqnqvm8x9MhPflvSwxNOKVlwjRWcDcjMewidd8pDi KiqhilCqKeGSqkBcg/g9XoUm0PScgVbw50cAMEhe2o5ozxTYa+ecG/5Z8/dP8B7LPr+i +cNPiQXI3ohZaWPQQvFmFjlsZGaQz4UZ9e+CPZNFwyKPWZhznsbIOK2h0oQQ1MZucR5/ AW0h7Vc1AQ7cUhcmnwJbQRoWFhcKWwTR7n6p4oKA+myDvrizjOgCCzwYg1MjCg6iRD/U KlcqvTWvjL8YAvdd9sZ21E+/ROXzlA8hPwl2ZWmvPm4r5ehf7jFFxpIpNA2MJvdkcZiY HULg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZQ+8HIJ9qo+uvPNDlSOLAl09pspajE/jGQLqn+GctwE=; b=39/xFUmlOguKiR3aAVO/FlXFh+uNQHzBFk3O6cPx7BV3fGCj3F+Kw3PP/pUmNpo2SP TVOgt6QEveRRilVE4Nm8URrNuz8JO83bJdZ85+wDAzWQieB3sqwlLnCOl5fSIT8SmG+F GpnLsk+5Ef/2rcby4Fd3iau1GQtZ8WKERR1ZtGlxJWzlMO8MTsbQQQ6IlDC9MtNulchS O8B3c1CwzLtxwcVzvn6SPIjB+J5v2cgaIxPU3+tgb3f9FoQvFtmtFsqOWah7oRfmo9/u Ac01nVmFsEvA0KwmMjAuJdVyUOFzJ7bxUjUSrXOdOv2qxIccxyrZ0RMKfCAAQH6PJe1e DFSA== X-Gm-Message-State: AFqh2krjlAQuxW6vmSyn3x5xuVbut26eDKrb/vtNk17XXnf4122Nq1C+ 12lwkLhkyy5F/jK/TO1nWSYS4ERCQjUfA6jS X-Google-Smtp-Source: AMrXdXuO0btZmX5/hPLbDyMyJluSzegGErfB/GYYPmycI3+Pub+W4ovVH+QCq3bP5pijUvTokbz/JQ== X-Received: by 2002:a7b:c39a:0:b0:3d2:640:c4e5 with SMTP id s26-20020a7bc39a000000b003d20640c4e5mr37028702wmj.8.1672994464000; Fri, 06 Jan 2023 00:41:04 -0800 (PST) Received: from [192.168.1.102] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id f15-20020a7bcd0f000000b003d9a71ee54dsm854874wmj.36.2023.01.06.00.41.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 00:41:03 -0800 (PST) Message-ID: Date: Fri, 6 Jan 2023 09:41:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] dt-bindings: mmc: fsl-imx-esdhc: allow more compatible combinations Content-Language: en-US To: Andreas Kemnade , ulf.hansson@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230105213856.1828360-1-andreas@kemnade.info> From: Krzysztof Kozlowski In-Reply-To: <20230105213856.1828360-1-andreas@kemnade.info> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230106_004106_121416_DC891ABD X-CRM114-Status: GOOD ( 16.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/01/2023 22:38, Andreas Kemnade wrote: > Currently make dtbs_check shows lots of errors because imx*.dtsi does > not use single compatibles but combinations of them. > Allow all the combinations used there. > > Patches fixing the dtsi files according to binding documentation were > submitted multiple times and are commonly rejected, so relax the rules. > Example: > https://lore.kernel.org/linux-devicetree/72e1194e10ccb4f87aed96265114f0963e805092.camel@pengutronix.de/ > > Reason: compatibility of new dtbs with old kernels or bootloaders. > > This will significantly reduce noise on make dtbs_check. > > Signed-off-by: Andreas Kemnade > --- > .../bindings/mmc/fsl-imx-esdhc.yaml | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > index dc6256f04b42..118ebb75f136 100644 > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > @@ -37,6 +37,30 @@ properties: > - fsl,imx8mm-usdhc > - fsl,imxrt1050-usdhc > - nxp,s32g2-usdhc You must drop the items from enum above. Binding saying: compatible="A" or: compatible="A", "B" is not correct. Either A is or is not compatible with B. > + - items: > + - const: fsl,imx50-esdhc > + - const: fsl,imx53-esdhc > + - items: > + - const: fsl,imx6sl-usdhc > + - const: fsl,imx6q-usdhc > + - items: > + - const: fsl,imx6sll-usdhc > + - const: fsl,imx6sx-usdhc > + - items: > + - const: fsl,imx6sx-usdhc > + - const: fsl,imx6sl-usdhc > + - items: > + - const: fsl,imx6ul-usdhc > + - const: fsl,imx6sx-usdhc > + - items: > + - const: fsl,imx6ull-usdhc > + - const: fsl,imx6sx-usdhc > + - items: > + - const: fsl,imx7d-usdhc > + - const: fsl,imx6sl-usdhc > + - items: > + - const: fsl,imx7ulp-usdhc > + - const: fsl,imx6sx-usdhc Half of these should be enum (6ul, 7ulp etc) with fallback. > - items: > - enum: > - fsl,imx8mq-usdhc Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel